mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-19 08:15:31 +00:00
a75561bd62
This is a follow-up to bug 1409249. There are a lot of places where our factory singleton constructors either don't correctly handle their returned references being released by the component manager, or do handle it, but in ways that are not obvious. This patch handles a few places where we can sometimes wind up with dangling singleton pointers, adds some explanatory comments and sanity check assertions, and replaces some uses of manual refcounting with StaticRefPtr and ClearOnShutdown. There are still some places where we may wind up with odd behavior if the first QI for a getService call fails. In those cases, we wind up destroying the first instance of a service that we create, and re-creating a new one later. MozReview-Commit-ID: ANYndvd7aZx --HG-- extra : rebase_source : acfb0611a028fef6b9387eb5d1d9e285782fbc7c
181 lines
4.3 KiB
C++
181 lines
4.3 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "mozilla/ClearOnShutdown.h"
|
|
#include "nsAutoPtr.h"
|
|
#include "nsJARProtocolHandler.h"
|
|
#include "nsIIOService.h"
|
|
#include "nsCRT.h"
|
|
#include "nsIComponentManager.h"
|
|
#include "nsIServiceManager.h"
|
|
#include "nsJARURI.h"
|
|
#include "nsIURL.h"
|
|
#include "nsJARChannel.h"
|
|
#include "nsString.h"
|
|
#include "nsNetCID.h"
|
|
#include "nsIMIMEService.h"
|
|
#include "nsMimeTypes.h"
|
|
#include "nsThreadUtils.h"
|
|
|
|
static NS_DEFINE_CID(kZipReaderCacheCID, NS_ZIPREADERCACHE_CID);
|
|
|
|
#define NS_JAR_CACHE_SIZE 32
|
|
|
|
//-----------------------------------------------------------------------------
|
|
|
|
StaticRefPtr<nsJARProtocolHandler> gJarHandler;
|
|
|
|
nsJARProtocolHandler::nsJARProtocolHandler()
|
|
{
|
|
MOZ_ASSERT(NS_IsMainThread());
|
|
}
|
|
|
|
nsJARProtocolHandler::~nsJARProtocolHandler()
|
|
{}
|
|
|
|
nsresult
|
|
nsJARProtocolHandler::Init()
|
|
{
|
|
nsresult rv;
|
|
|
|
mJARCache = do_CreateInstance(kZipReaderCacheCID, &rv);
|
|
if (NS_FAILED(rv)) return rv;
|
|
|
|
rv = mJARCache->Init(NS_JAR_CACHE_SIZE);
|
|
return rv;
|
|
}
|
|
|
|
nsIMIMEService *
|
|
nsJARProtocolHandler::MimeService()
|
|
{
|
|
if (!mMimeService)
|
|
mMimeService = do_GetService("@mozilla.org/mime;1");
|
|
|
|
return mMimeService.get();
|
|
}
|
|
|
|
NS_IMPL_ISUPPORTS(nsJARProtocolHandler,
|
|
nsIJARProtocolHandler,
|
|
nsIProtocolHandler,
|
|
nsISupportsWeakReference)
|
|
|
|
already_AddRefed<nsJARProtocolHandler>
|
|
nsJARProtocolHandler::GetSingleton()
|
|
{
|
|
if (!gJarHandler) {
|
|
gJarHandler = new nsJARProtocolHandler();
|
|
if (NS_SUCCEEDED(gJarHandler->Init())) {
|
|
ClearOnShutdown(&gJarHandler);
|
|
} else {
|
|
gJarHandler = nullptr;
|
|
}
|
|
}
|
|
return do_AddRef(gJarHandler);
|
|
}
|
|
|
|
NS_IMETHODIMP
|
|
nsJARProtocolHandler::GetJARCache(nsIZipReaderCache* *result)
|
|
{
|
|
*result = mJARCache;
|
|
NS_ADDREF(*result);
|
|
return NS_OK;
|
|
}
|
|
|
|
////////////////////////////////////////////////////////////////////////////////
|
|
// nsIProtocolHandler methods:
|
|
|
|
NS_IMETHODIMP
|
|
nsJARProtocolHandler::GetScheme(nsACString &result)
|
|
{
|
|
result.AssignLiteral("jar");
|
|
return NS_OK;
|
|
}
|
|
|
|
NS_IMETHODIMP
|
|
nsJARProtocolHandler::GetDefaultPort(int32_t *result)
|
|
{
|
|
*result = -1; // no port for JAR: URLs
|
|
return NS_OK;
|
|
}
|
|
|
|
NS_IMETHODIMP
|
|
nsJARProtocolHandler::GetProtocolFlags(uint32_t *result)
|
|
{
|
|
// URI_LOADABLE_BY_ANYONE, since it's our inner URI that will matter
|
|
// anyway.
|
|
*result = URI_NORELATIVE | URI_NOAUTH | URI_LOADABLE_BY_ANYONE;
|
|
/* Although jar uris have their own concept of relative urls
|
|
it is very different from the standard behaviour, so we
|
|
have to say norelative here! */
|
|
return NS_OK;
|
|
}
|
|
|
|
NS_IMETHODIMP
|
|
nsJARProtocolHandler::NewURI(const nsACString &aSpec,
|
|
const char *aCharset,
|
|
nsIURI *aBaseURI,
|
|
nsIURI **result)
|
|
{
|
|
nsresult rv = NS_OK;
|
|
|
|
RefPtr<nsJARURI> jarURI = new nsJARURI();
|
|
if (!jarURI)
|
|
return NS_ERROR_OUT_OF_MEMORY;
|
|
|
|
rv = jarURI->Init(aCharset);
|
|
NS_ENSURE_SUCCESS(rv, rv);
|
|
|
|
rv = jarURI->SetSpecWithBase(aSpec, aBaseURI);
|
|
if (NS_FAILED(rv))
|
|
return rv;
|
|
|
|
NS_ADDREF(*result = jarURI);
|
|
return rv;
|
|
}
|
|
|
|
NS_IMETHODIMP
|
|
nsJARProtocolHandler::NewChannel2(nsIURI* uri,
|
|
nsILoadInfo* aLoadInfo,
|
|
nsIChannel** result)
|
|
{
|
|
nsJARChannel *chan = new nsJARChannel();
|
|
if (!chan)
|
|
return NS_ERROR_OUT_OF_MEMORY;
|
|
NS_ADDREF(chan);
|
|
|
|
nsresult rv = chan->Init(uri);
|
|
if (NS_FAILED(rv)) {
|
|
NS_RELEASE(chan);
|
|
return rv;
|
|
}
|
|
|
|
// set the loadInfo on the new channel
|
|
rv = chan->SetLoadInfo(aLoadInfo);
|
|
if (NS_FAILED(rv)) {
|
|
NS_RELEASE(chan);
|
|
return rv;
|
|
}
|
|
|
|
*result = chan;
|
|
return NS_OK;
|
|
}
|
|
|
|
NS_IMETHODIMP
|
|
nsJARProtocolHandler::NewChannel(nsIURI *uri, nsIChannel **result)
|
|
{
|
|
return NewChannel2(uri, nullptr, result);
|
|
}
|
|
|
|
|
|
NS_IMETHODIMP
|
|
nsJARProtocolHandler::AllowPort(int32_t port, const char *scheme, bool *_retval)
|
|
{
|
|
// don't override anything.
|
|
*_retval = false;
|
|
return NS_OK;
|
|
}
|
|
|
|
////////////////////////////////////////////////////////////////////////////////
|