gecko-dev

mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-05 08:35:26 +00:00

History

timeless@mozdev.org 7e62613f50 Bug 421303 Crash [@ jsds_ScriptHookProc] r=caillon a=dsicore If we reach ~jsdService, that means our client doesn't care about us, so we can (and should) drop all references to any callbacks (if they cared, they'd have kept us alive!). I think jsdService::Off should clear all the hooks, the strange magic of not clearing it isn't really a great idea. So for Off, we'll now clear the ScriptHook too (consumers who use off should really drop any references they have to our objects...). I'm still on the fence on this point, I suspect we can actually move it from ::Off to ~jsdService (it must be cleared at some point, otherwise if jsd_xpc's library manages to get unloaded, the function pointer would be invalid, which would be BAD). jsds_NotifyPendingDeadScripts needs to clear gDeadScripts whether or not there's a service or hooks, so it does. Because it's a static callback and because of the scary way GC works, I'd rather ensure (deathgrip) that jsds is available (and consistent!) for the duration of the function call. The code already handles the lack of a hook, so there's no reason to do magical returns.... The real problem which mayhemer found was that jsdService::Off was returning early (failure) because gGCStatus wasn't JSGC_END when called from ~jsdService from JS_GC from the cyclecollector, so we make sure that ~jsdService forces ::Off to act as if it is JSGC_END (after ensuring that there are no callbacks available). a pure javascript (xpcom component, not DOM hosted!) version of a jsdService consumer means that jsdService will need to talk to the CycleCollector eventually (this is another bug for the future).		2008-03-10 17:13:48 -07:00
..
idl	Bug 378261: Replacing GC_MARK_DEBUG by DumpHeap. r=brendan	2007-04-25 06:43:18 -07:00
jsd1640.def
jsd1640.rc
jsd3240.rc
jsd_atom.c
jsd_high.c	Checking in Ben Turner <bent.mozilla@gmail.com> and timeless's patch to make Gecko use the JS engine's request model to help multithreaded embedders avoid GC races and crashes. bug 176182, r=mrbkap assumed-rs=brendan	2006-06-12 22:39:55 +00:00
jsd_hook.c
jsd_java.c
jsd_lock.c	Bug 405025 ASSERT_VALID_LOCK failed r=gijs a=dsicore	2008-02-26 07:07:05 -08:00
jsd_lock.h
jsd_obj.c
jsd_scpt.c	Bug 416293 unbalanced locking in jsd_SetExecutionHook r=crowder a=mtschrep	2008-02-09 20:16:54 -08:00
jsd_stak.c	Bug 343511 - Don't assert more than necessary. r=rginda	2006-07-20 15:25:32 +00:00
jsd_step.c
jsd_text.c
jsd_val.c	Bug 342573 - "Fix accidental return value switch from bug 176182". r=mrbkap.	2006-06-23 22:29:51 +00:00
jsd_xpc.cpp	Bug 421303 Crash [@ jsds_ScriptHookProc] r=caillon a=dsicore If we reach ~jsdService, that means our client doesn't care about us, so we can (and should) drop all references to any callbacks (if they cared, they'd have kept us alive!). I think jsdService::Off should clear all the hooks, the strange magic of not clearing it isn't really a great idea. So for Off, we'll now clear the ScriptHook too (consumers who use off should really drop any references they have to our objects...). I'm still on the fence on this point, I suspect we can actually move it from ::Off to ~jsdService (it must be cleared at some point, otherwise if jsd_xpc's library manages to get unloaded, the function pointer would be invalid, which would be BAD). jsds_NotifyPendingDeadScripts needs to clear gDeadScripts whether or not there's a service or hooks, so it does. Because it's a static callback and because of the scary way GC works, I'd rather ensure (deathgrip) that jsds is available (and consistent!) for the duration of the function call. The code already handles the lack of a hook, so there's no reason to do magical returns.... The real problem which mayhemer found was that jsdService::Off was returning early (failure) because gGCStatus wasn't JSGC_END when called from ~jsdService from JS_GC from the cyclecollector, so we make sure that ~jsdService forces ::Off to act as if it is JSGC_END (after ensuring that there are no callbacks available). a pure javascript (xpcom component, not DOM hosted!) version of a jsdService consumer means that jsdService will need to talk to the CycleCollector eventually (this is another bug for the future).	2008-03-10 17:13:48 -07:00
jsd_xpc.h	Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros.	2007-07-08 00:08:04 -07:00
jsd.h	More nukage of private API usage.	2006-04-27 01:33:45 +00:00
jsd.mak
jsd.pkg
jsdebug.c
jsdebug.h
jsdshell.mak
jsdstubs.c
Makefile.in	Bug 78081 - Don't export intermediate libraries, r=luser	2007-02-21 15:13:36 +00:00
mkshell.bat
README
resource.h

README

js/jsd contains code for debugging support for the C-based JavaScript engine 
in js/src.  jsd_xpc.cpp provides an XPCOM binding for the library.

js/jsd/jsdb is a console debugger using only native code (see README in that 
directory.)  This debugger is no longer being actively developed, though it
should work.