mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-09 11:25:00 +00:00
934828f009
The invalid variable test for #if{,n}def was only checking that the first character in the variable was alphanumeric or underscore, not the other characters. More generally, preprocessor instructions were also cut out such that whitespaces before and after arguments were part of the arguments. Subtly, some legitimate strings end with what, in ISO-8859-1, is considered as whitespaces, and because the preprocessor largely works on byte strings (str), and because the regexps are using re.U, those characters (e.g. 0xa0) that can legitimately appear in byte strings of UTF-8 encoding, are treated as whitespaces. So we remove the re.U from the instruction regexp, so that only plain ascii whitespaces only are stripped out. There's one place in layout/tools/reftest/manifest.jsm that was using a broken pattern, making the test never true, which, once fixed, unveils broken tests, so the branch that was never used is removed. --HG-- extra : rebase_source : b695dec025c55aee0e50f2a0047278fe9c849c9e |
||
---|---|---|
.. | ||
layout-debug | ||
recording | ||
reftest | ||
tests |