gecko-dev/storage
Gabriele Svelto aa43fa218e Bug 1831092 - Use the new pull-based API for all crash annotations and remove the global annotations table r=jgilbert,necko-reviewers,media-playback-reviewers,profiler-reviewers,win-reviewers,padenot,handyman,afranchuk,valentin,alwu,sotaro
This changes comes with several different refactorings all rolled into one,
unfotunately I couldn't find a way to pull them apart:
- First of all annotations now can either recorded (that is, we copy the value
  and have the crash reporting code own the copy) or registered. Several
  annotations are changed to use this functionality so that we don't need to
  update them as their value change.
- The code in the exception handler is modified to read the annotations from
  the mozannotation_client crate. This has the unfortunate side-effect that
  we need three different bits of code to serialize them: one for annotations
  read from a child process, one for reading annotations from the main process
  outside of the exception handler and one for reading annotations from the
  main process within the exception handler. As we move to fully
  out-of-process crash reporting the last two methods will go away.
- The mozannotation_client crate now doesn't record annotation types anymore.
  I realized as I was working on this that storing types at runtime has two
  issues: the first one is that buggy code might change the type of an
  annotation (that is record it under two different types at two different
  moments), the second issue is that types might become corrupt during a
  crash, so better enforce them at annotation-writing time. The end result is
  that the mozannotation_* crates now only store byte buffers, track the
  format the data is stored in (null-terminated string, fixed size buffer,
  etc...) but not the type of data each annotation is supposed to contain.
- Which brings us to the next change: concrete types for annotations are now
  enforced when they're written out. If an annotation doesn't match the
  expected type it's skipped. Storing an annotation with the wrong type will
  also trigger an assertion in debug builds.

Differential Revision: https://phabricator.services.mozilla.com/D195248
2024-03-04 10:24:43 +00:00
..
build
rust
test Bug 1864896: Autofix unused function arguments (storage). r=asuth 2024-03-01 23:43:54 +00:00
variant
BaseVFS.cpp
BaseVFS.h
FileSystemModule.cpp
FileSystemModule.h
IStorageBindingParamsInternal.h
moz.build
mozIStorageAsyncConnection.idl
mozIStorageAsyncStatement.idl
mozIStorageBaseStatement.idl
mozIStorageBindingParams.idl
mozIStorageBindingParamsArray.idl
mozIStorageCompletionCallback.idl
mozIStorageConnection.idl
mozIStorageError.idl
mozIStorageFunction.idl
mozIStoragePendingStatement.idl
mozIStorageProgressHandler.idl
mozIStorageResultSet.idl
mozIStorageRow.idl
mozIStorageService.idl
mozIStorageStatement.idl
mozIStorageStatementCallback.idl
mozIStorageVacuumParticipant.idl
mozIStorageValueArray.idl
mozStorageArgValueArray.cpp
mozStorageArgValueArray.h
mozStorageAsyncStatement.cpp
mozStorageAsyncStatement.h
mozStorageAsyncStatementExecution.cpp
mozStorageAsyncStatementExecution.h
mozStorageAsyncStatementJSHelper.cpp
mozStorageAsyncStatementJSHelper.h
mozStorageAsyncStatementParams.cpp
mozStorageAsyncStatementParams.h
mozStorageBindingParams.cpp
mozStorageBindingParams.h
mozStorageBindingParamsArray.cpp
mozStorageBindingParamsArray.h
mozStorageConnection.cpp
mozStorageConnection.h
mozStorageError.cpp
mozStorageError.h
mozStorageHelper.h
mozStoragePrivateHelpers.cpp
mozStoragePrivateHelpers.h
mozStorageResultSet.cpp
mozStorageResultSet.h
mozStorageRow.cpp
mozStorageRow.h
mozStorageService.cpp Bug 1831092 - Use the new pull-based API for all crash annotations and remove the global annotations table r=jgilbert,necko-reviewers,media-playback-reviewers,profiler-reviewers,win-reviewers,padenot,handyman,afranchuk,valentin,alwu,sotaro 2024-03-04 10:24:43 +00:00
mozStorageService.h
mozStorageSQLFunctions.cpp
mozStorageSQLFunctions.h
mozStorageStatement.cpp
mozStorageStatement.h
mozStorageStatementData.h
mozStorageStatementJSHelper.cpp
mozStorageStatementJSHelper.h
mozStorageStatementParams.cpp
mozStorageStatementParams.h
mozStorageStatementRow.cpp
mozStorageStatementRow.h
ObfuscatingVFS.cpp
ObfuscatingVFS.h
QuotaVFS.cpp
QuotaVFS.h
ReadOnlyNoLockVFS.cpp
SQLCollations.cpp
SQLCollations.h
SQLiteMutex.h
StatementCache.h
storage.h
StorageBaseStatementInternal.cpp
StorageBaseStatementInternal.h
style.txt
VacuumManager.cpp
VacuumManager.h
Variant_inl.h
Variant.cpp
Variant.h
variantToSQLiteT_impl.h