gecko-dev/dom/grid
Emilio Cobos Álvarez 1f3d6c04f2 Bug 1519958 - Refactor grid types to preserve repeat() at computed value time and use cbindgen. r=mats,boris
I'm _really_ sorry for the size of the patch. I tried to do this in two steps
but it was a lot of work and pretty ugly.

This patch makes us use cbindgen for grid-template-{rows,columns}, in order to:

 * Make us preserve repeat() at computed-value time. This is per spec since
   interpolation needs to know about repeat(). Except for subgrid, which did the
   repeat expansion at parse-time and was a bit more annoying (plus it doesn't
   really animate yet so we don't need it to comply with the spec).

 * Tweaks the WPT tests for interpolation to adopt the resolution at:
   https://github.com/w3c/csswg-drafts/issues/3503.

Trade-off here, as this patch stands, is that this change makes us use less
long-living memory, since we expand repeat() during layout, but at the cost of a
bit of CPU time during layout (conditional on the property applying though,
which wasn't the case before). It should be very easy to store a cached version
of the template, should this be too hot (I expect it isn't), or to change the
representation in other ways to optimize grid layout code if it's worth it.

Another trade-off: I've used SmallPointerArray to handle line-name merging,
pointing to the individual arrays in the style data, rather than actually
heap-allocating the merged lists. This would also be pretty easy to change
should we measure and see that it's not worth it.

This patch also opens the gate to potentially improving memory usage in some
other ways, by reference-counting line-name lists for example, though I don't
have data that suggests it is worth it.

In general, this patch makes much easier to tweak the internal representation of
the grid style data structures. Overall, I think it's a win, the amount of magic
going on in that mako code was a bit huge; it took a bit to wrap my head around
it.

This patch comments out the style struct size assertions. They will be
uncommented in a follow-up patch which contains some improvements for this type,
which are worth getting reviewed separately.

Also, this patch doesn't remove as much code as I would've hoped for because of
I tried not to change most of the dom/grid code for inspector, but I think a
fair bit of the nsGridContainerFrame.cpp code that collects information for it
can be simplified / de-copy-pasted to some extent. But that was a pre-existing
problem and this patch is already quite massive.

Differential Revision: https://phabricator.services.mozilla.com/D36598
2019-08-05 22:13:21 +02:00
..
test
Grid.cpp Bug 1559546 - Use atoms for grid line names. r=mats 2019-06-19 05:58:11 +00:00
Grid.h
GridArea.cpp Bug 1559546 - Use atoms for grid line names. r=mats 2019-06-19 05:58:11 +00:00
GridArea.h Bug 1559546 - Use atoms for grid line names. r=mats 2019-06-19 05:58:11 +00:00
GridDimension.cpp
GridDimension.h
GridLine.cpp Bug 1559546 - Use atoms for grid line names. r=mats 2019-06-19 05:58:11 +00:00
GridLine.h Bug 1559546 - Use atoms for grid line names. r=mats 2019-06-19 05:58:11 +00:00
GridLines.cpp Bug 1519958 - Refactor grid types to preserve repeat() at computed value time and use cbindgen. r=mats,boris 2019-08-05 22:13:21 +02:00
GridLines.h Bug 1559546 - Use atoms for grid line names. r=mats 2019-06-19 05:58:11 +00:00
GridTrack.cpp
GridTrack.h
GridTracks.cpp
GridTracks.h
moz.build