mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-01-27 15:55:16 +00:00
19d52d9edc
This commit prepares the decks for turning specific Raptor tasks into Raptor + browsertime tasks. The `--browsertime` flag to `mach try ...` flips the switch; eventually, the Raptor harness will recognize the `--browsertime` flag and use browsertime to perform the pageload measurements. To run browsertime, we need: 1) Node.js 2) the browsertime `node_modules` (provided by the `toolchain-browsertime` task) 3) ffmpeg (for producing videos from captured frames) 4) chromedriver (in the future, when targeting Chrome/Chromium) 5) geckodriver (provided by the `toolchain-*-geckodriver` tasks) 6) `PATH` configured This commit arranges those things. Since the configuration varies by test platform, and eventually we expect the changes implemented by the flag to be moved into YAML task definitions, we elect to use `by-test-platform` conditionals as much as possible. The end expression is pleasant, thanks to `evaluate_keyed_by`. Handling PATH, however, is a rabbit hole. At this time, it's not possible to use `fetch` task repackaging, because `releng-hardware` doesn't support `zstandard` (Bug 1576244) and there's no appetite to avoid `zstandard` entirely (Bug 1576698). Generally PATH is configured using `mozharness` configuration files, which can execute arbitrary Python and configure the PATH only for browsertime jobs. However, the Raptor mozharness script itself runs the Raptor harness in a stripped down environment, throwing away modifications to PATH. It's not clear what impacts changing that has, so we leave it alone, and add a `--browsertime-ffmpeg` flag and custom handling in the Raptor harness. This can transition smoothly into a browsertime flag (so that the PATH doesn't need to be set at all) and into a unified interface for Raptor and `mach browsertime` to configure the browsertime execution environment. Differential Revision: https://phabricator.services.mozilla.com/D38781 --HG-- extra : moz-landing-system : lando