Read-only Git mirror of the Mercurial gecko repositories at https://hg.mozilla.org. How to contribute: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
Go to file
Michael Hofmann 99540873a3 Bug 1684365 - Add a null pointer check so that Firefox won't crash when it can't initialize mRemoteServer r=stransky
Firefox 84.0.1 crashes under Gentoo Linux if it is started in
Wayland mode and if it was compiled WITH Wayland support and
WITHOUT dbus support.

I traced down the problem to line 172 of
toolkit/components/remote/nsRemoteService.cpp:

   nsresult rv = mRemoteServer->Startup(mProgram.get(), mProfile.get());

mRemoteServer is NULL and Firefox crashes.

This patch adds a NULL pointer check before that line.

See:
- Mozilla's Bugzilla, bug 1684365
- https://bugs.gentoo.org/762035
- https://forums.gentoo.org/viewtopic-t-1126235.html

Differential Revision: https://phabricator.services.mozilla.com/D101536
2021-01-25 09:29:42 +00:00
.cargo Bug 1686463 - Gather telemetry about automatic encoding detection outcomes. r=chutten,emk 2021-01-24 00:11:07 +00:00
.vscode Bug 1685030 - Remove rust from vscode extensions list. r=sylvestre DONTBUILD 2021-01-05 17:28:05 +00:00
accessible Bug 1686238: Only attempt to traverse containers menu if containers are enabled and defined r=yzen 2021-01-22 21:02:50 +00:00
browser Bug 1626600 - removed PiP from browser_contextmenu tests r=mhowell 2021-01-24 18:10:31 +00:00
build Bug 1684672 - Update mentions of macOS SDK v10.11 to v10.12. r=glandium DONTBUILD 2021-01-21 12:47:01 +00:00
caps Bug 1594234 remove extensions.content_script_csp preferences in favor of extensions.manifestV3.enabled r=robwu 2021-01-19 19:43:09 +00:00
chrome Bug 1660470 - Add missing include directives/forward declarations. r=nika 2020-11-23 16:21:38 +00:00
config Bug 1687433 - Don't build libffi assembly with -no-integrated-as. r=firefox-build-system-reviewers,mhentges 2021-01-19 14:10:59 +00:00
devtools Bug 1688132: Update MDN compat data. r=Honza 2021-01-25 08:36:12 +00:00
docs Bug 1684672 - Update mentions of macOS SDK v10.11 to v10.12. r=glandium DONTBUILD 2021-01-21 12:47:01 +00:00
docshell Bug 1686463 - Gather telemetry about automatic encoding detection outcomes. r=chutten,emk 2021-01-24 00:11:07 +00:00
dom Bug 1688312 - Consider to use nsAtoms in PerformanceEntry, r=sefeng 2021-01-24 12:16:55 +00:00
editor Bug 1687167 - Move IME handling guide to source tree. r=masayuki DONTBUILD 2021-01-19 06:07:27 +00:00
extensions Bug 1685427 - Crash when authenticating using SPNEGO on macOS (ARM) r=spohl 2021-01-20 01:29:16 +00:00
gfx Bug 1688323 - refactor WR gradient shaders with gradient_shared. r=gw 2021-01-24 19:51:18 +00:00
gradle/wrapper
hal Bug 1683553 - Make hal buildable outside of unified-build environment. r=gsvelto 2021-01-04 14:20:19 +00:00
image Bug 1685900 - Split internal and external contentPolicyType. r=ckerschb,smaug 2021-01-15 12:07:16 +00:00
intl Bug 1686463 - Gather telemetry about automatic encoding detection outcomes. r=chutten,emk 2021-01-24 00:11:07 +00:00
ipc Bug 1685900 - Split internal and external contentPolicyType. r=ckerschb,smaug 2021-01-15 12:07:16 +00:00
js Backed out 2 changesets (bug 1688327) as per request. 2021-01-23 19:45:30 +02:00
layout Bug 1685303: part 28) Add virtual AccessibleCaretManager::MaybeFlushLayout. r=TYLin,smaug 2021-01-22 12:18:05 +00:00
media Bug 1687487 - Update libcubeb to 4a83932. r=cubeb-reviewers,kinetik 2021-01-19 20:08:55 +00:00
memory Bug 1682556 - Increase vm_copy() threshold. r=glandium 2020-12-23 01:35:22 +00:00
mfbt Bug 1686219 - Add BitSet::SetAll and ResetAll methods r=heycam 2021-01-20 10:03:53 +00:00
mobile Bug 1679688 - make host permissions grant access to privileged parts of the tabs API and fix Bug 1686443 r=robwu,geckoview-reviewers,agi 2021-01-23 14:09:22 +00:00
modules Bug 1579064 - Remove preferences for bug fixes 1563695 and 1556491. r=necko-reviewers,valentin 2021-01-21 20:38:22 +00:00
mozglue Bug 1686229 - Part3. Display a module's loading status on about:support. r=Gijs,fluent-reviewers 2021-01-22 21:40:46 +00:00
netwerk Bug 1684038 - Add new SVCParam: ODoHConfig r=necko-reviewers,dragana 2021-01-22 12:59:24 +00:00
nsprpub
other-licenses Bug 1461690 Part 3: HttpPostFile plugin for uploading uninstall ping via POST. r=mhowell 2020-10-20 23:20:25 +00:00
parser Bug 1686463 - Gather telemetry about automatic encoding detection outcomes. r=chutten,emk 2021-01-24 00:11:07 +00:00
python Bug 1686331 - Library menu should not have a scroll bar. r=prathiksha,flod 2021-01-21 06:20:55 +00:00
remote Bug 1687108 - Remove unused content policy types. r=ckerschb,remote-protocol-reviewers,smaug 2021-01-19 09:42:13 +00:00
security Bug 1684061 - land NSS NSS_3_61_RTM UPGRADE_NSS_RELEASE, r=bbeurdouche 2021-01-22 17:36:32 +00:00
services Bug 1678619: Remove onManyFrecenciesChanged interface from nsINavHistoryService. r=mak 2021-01-21 15:51:03 +00:00
servo Bug 1686613 - Add a non-native-theme media query. r=heycam 2021-01-21 06:14:16 +00:00
startupcache Bug 1660470 - Add missing include directives/forward declarations. r=nika 2020-11-23 16:21:38 +00:00
storage Bug 1678062 - Remove unnecessary includes. r=andi 2020-11-23 16:12:02 +00:00
taskcluster Bug 1688039 - Build grcov with Clang. r=calixte DONTBUILD 2021-01-23 00:19:52 +00:00
testing Bug 1687820 - Fix bugs with null bytes in form payloads. r=smaug 2021-01-23 20:25:05 +00:00
third_party Bug 1686463 - Gather telemetry about automatic encoding detection outcomes. r=chutten,emk 2021-01-24 00:11:07 +00:00
toolkit Bug 1684365 - Add a null pointer check so that Firefox won't crash when it can't initialize mRemoteServer r=stransky 2021-01-25 09:29:42 +00:00
tools Bug 1686632 - Remove non-inclusive language r=jesup 2021-01-21 17:28:23 +00:00
uriloader Bug 1681249 - unbreak subframes navigating ancestor frames to custom protocols, r=nika 2021-01-14 20:17:44 +00:00
view Bug 1683226 - part 16: Get rid of WidgetPluginEvent r=smaug 2020-12-29 21:19:45 +00:00
widget Bug 1687868 - Prevent skia fuzziness in nsNativeBasicTheme. r=heycam 2021-01-23 19:31:33 +00:00
xpcom Bug 1688308 - Add a marker for "Perform microtasks". r=smaug 2021-01-22 21:43:16 +00:00
xpfe/appshell Bug 1686374, adjust margins if bookmarks toolbar is shown r=dthayer 2021-01-22 20:59:21 +00:00
.arcconfig
.babel-eslint.rc.js
.clang-format
.clang-format-ignore Bug 1686635 - Remove gfx/wr from .clang-format-ignore. r=sylvestre 2021-01-14 04:25:08 +00:00
.cron.yml Bug 1686969 - Make searchfox index both mozilla-central nightlies. r=kats,releng-reviewers,aki DONTBUILD 2021-01-15 20:13:32 +00:00
.eslintignore
.eslintrc.js Bug 1656295 - Enable ESLint rule no-unused-vars for all of netwerk/. r=necko-reviewers,dragana 2021-01-12 13:39:11 +00:00
.flake8 Bug 1622681 - Remove dom/encoding from flake8 excludes. r=sylvestre DONTBUILD 2021-01-21 20:50:40 +00:00
.git-blame-ignore-revs Bug 1648010 - Add revisions for the replacement of literal string macros by string literals to the ignore sets. r=marco,glandium DONTBUILD 2020-12-01 09:04:42 +00:00
.gitattributes
.gitignore Bug 1687154 - Add raptor's generated files to .gitignore. r=glandium DONTBUILD 2021-01-19 00:34:55 +00:00
.hg-annotate-ignore-revs Bug 1648010 - Add revisions for the replacement of literal string macros by string literals to the ignore sets. r=marco,glandium DONTBUILD 2020-12-01 09:04:42 +00:00
.hg-format-source
.hgignore Bug 1666347 - Delete assorted dead code after removal of vendored psutil r=firefox-build-system-reviewers,rstewart 2020-11-27 16:21:07 +00:00
.hgtags No bug - tagging 22fc47c968f29a47ed15b282e2148aa5024d861e with FIREFOX_NIGHTLY_85_END a=release DONTBUILD CLOSED TREE 2020-12-14 15:47:54 +00:00
.lldbinit
.mailmap
.prettierignore
.prettierrc
.taskcluster.yml
.trackerignore
.yamllint
.ycm_extra_conf.py Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
aclocal.m4
AUTHORS
build.gradle Bug 1685390 - Update apilint to 0.4.1. r=esawin 2021-01-08 16:17:22 +00:00
Cargo.lock Bug 1686463 - Gather telemetry about automatic encoding detection outcomes. r=chutten,emk 2021-01-24 00:11:07 +00:00
Cargo.toml Bug 1686463 - Gather telemetry about automatic encoding detection outcomes. r=chutten,emk 2021-01-24 00:11:07 +00:00
client.mk Bug 1671424 - Move configure execution from client.mk to mach configure. r=firefox-build-system-reviewers,rstewart 2020-10-20 20:41:52 +00:00
client.py Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
CLOBBER
configure.in Bug 1671424 - Move configure execution from client.mk to mach configure. r=firefox-build-system-reviewers,rstewart 2020-10-20 20:41:52 +00:00
configure.py Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
GNUmakefile
gradle.properties
gradlew
gradlew.bat
LICENSE
mach Bug 1687595 - Always get mach modules from subdirectories of where mach is. r=firefox-build-system-reviewers,mhentges 2021-01-21 01:39:56 +00:00
mach.ps1 Bug 1686256 - Add Windows friendly wrapper for mach r=mhentges,firefox-build-system-reviewers,dmajor 2021-01-20 02:08:40 +00:00
Makefile.in Bug 1675086 - drop reference to 'pgo' from Windows AArch EME artifact build. r=nalexander 2020-11-03 22:46:57 +00:00
moz.build Bug 1687640 - Cover mach.ps1 in moz.build r=dmajor,firefox-build-system-reviewers 2021-01-20 15:20:27 +00:00
moz.configure Bug 1687421 - Avoid error with --enable-bootstrap on platforms with no bootstrap artifacts. r=firefox-build-system-reviewers,mhentges 2021-01-19 14:10:16 +00:00
mozilla-config.h.in
old-configure.in Bug 1480005 - Move NM to python configure. r=firefox-build-system-reviewers,nalexander 2021-01-14 20:17:08 +00:00
package-lock.json
package.json
README.txt
settings.gradle
substitute-local-geckoview.gradle
test.mozbuild

An explanation of the Firefox Source Code Directory Structure and links to
project pages with documentation can be found at:

    https://firefox-source-docs.mozilla.org/contributing/directory_structure.html

For information on how to build Firefox from the source code and create the patch see:

    https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

If you have a question about developing Firefox, and can't find the solution
on https://firefox-source-docs.mozilla.org/, you can try asking your question on Matrix at chat.mozilla.org in `Introduction` (https://chat.mozilla.org/#/room/#introduction:mozilla.org) channel.


Nightly development builds can be downloaded from:

    https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/
            - or -
    https://www.mozilla.org/firefox/channel/desktop/#nightly

Keep in mind that nightly builds, which are used by Firefox developers for
testing, may be buggy.