gecko-dev/widget
Brad Werth 914d7dfb6a Bug 1879816: Make nsCocoaWindow::Destroy close the window and let destruction happen later. r=mstange
This allows mWindow to stay alive as long as there are still references
to the nsCocoaWindow that owns it. This was the original intent before
the landing of Bug 1865372, which instead destroyed mWindow as soon as
possible. The important behavior in Destroy() is that the native window
becomes not visible. There are at least two ways to hide the window:
orderOut, which merely hides the window, and close (used here) which has
some additional semantic meaning and posts NSWindowWillCloseNotification.
That notification is detected by our window state save/restore code, so
closing the window is a trigger to update the window state. It's
appropriate to update this state during Destroy().

The alternative of hiding the window with orderOut also seems to confuse
the window  manager when closing a fullscreen window (which was the
issue addressed  by Bug 1865372). So we use close. In order to make this
work, we have to ensure that all new native windows have the property
releaseWhenClosed set to NO, and that we explicitly release mWindow in
DestroyNativeWindow().

Differential Revision: https://phabricator.services.mozilla.com/D202363
2024-02-22 16:25:53 +00:00
..
android Bug 1881488 - Use a static pref for tooltip delay. r=masayuki,dom-core 2024-02-22 12:59:41 +00:00
cocoa Bug 1879816: Make nsCocoaWindow::Destroy close the window and let destruction happen later. r=mstange 2024-02-22 16:25:53 +00:00
crashtests
generic
gtk Backed out changeset fdcedb217978 (bug 1880323) for causing failures in nsWindow.cpp. CLOSED TREE 2024-02-22 16:56:07 +02:00
headless Bug 1881488 - Use a static pref for tooltip delay. r=masayuki,dom-core 2024-02-22 12:59:41 +00:00
reftests
tests Bug 1780071 - Manual fixes/disabling of no-comparison-or-assignment-inside-ok for exceptional cases, r=Standard8,devtools-reviewers,anti-tracking-reviewers,places-reviewers,dom-storage-reviewers,pbz,asuth,nchevobbe 2024-02-19 23:30:40 +00:00
uikit
windows Bug 1881488 - Use a static pref for tooltip delay. r=masayuki,dom-core 2024-02-22 12:59:41 +00:00
x11
BasicEvents.h
ClipboardReadRequestChild.h
ClipboardReadRequestParent.cpp
ClipboardReadRequestParent.h
ClipboardWriteRequestChild.cpp
ClipboardWriteRequestChild.h
ClipboardWriteRequestParent.cpp
ClipboardWriteRequestParent.h
ColorScheme.h
CommandList.h
components.conf
CompositorWidget.cpp
CompositorWidget.h
ContentCache.cpp
ContentCache.h
ContentData.cpp
ContentData.h
ContentEvents.h
DimensionRequest.cpp
DimensionRequest.h
EventClassList.h
EventForwards.h
EventMessageList.h
FontRange.h
GfxDriverInfo.cpp
GfxDriverInfo.h
GfxInfoBase.cpp Bug 1826412: Move the Linux Distro stuff to nsIGfxInfo also r=jfkthame 2024-02-05 21:19:16 +00:00
GfxInfoBase.h Bug 1826412: Rip out all the ugly and move it to nsIGfxInfo r=jfkthame,fluent-reviewers,flod 2024-02-05 21:19:16 +00:00
GfxInfoCollector.cpp
GfxInfoCollector.h
IconLoader.cpp
IconLoader.h
IMEData.cpp
IMEData.h
InitData.h Bug 1878037 - Fix some regressions on alert windows. r=saschanaz,win-reviewers,rkraesig 2024-02-12 19:45:48 +00:00
InProcessCompositorWidget.cpp
InProcessCompositorWidget.h
InputData.cpp
InputData.h
LookAndFeel.h Bug 1881488 - Use a static pref for tooltip delay. r=masayuki,dom-core 2024-02-22 12:59:41 +00:00
LookAndFeelTypes.ipdlh
LSBUtils.cpp Bug 1874226 - Use unique_ptr not Scoped in xpcom/*. r=xpcom-reviewers,necko-reviewers,valentin,emilio 2024-02-07 18:30:22 +00:00
LSBUtils.h
MediaKeysEventSourceFactory.h
MiscEvents.h
MouseEvents.h
moz.build
NativeKeyBindingsType.h
NativeKeyToDOMCodeName.h
NativeKeyToDOMKeyName.h
NativeMenu.h
NativeMenuSupport.h
nsAppShellSingleton.h
nsAutoRollup.cpp
nsAutoRollup.h
nsBaseAppShell.cpp
nsBaseAppShell.h
nsBaseClipboard.cpp Bug 1879182 - add a pref to make Content Analysis allow by default r=handyman 2024-02-14 16:10:53 +00:00
nsBaseClipboard.h Bug 1871135 - Add content analysis support to clipboard operations r=edgar,nika,masayuki,devtools-reviewers 2024-02-13 11:26:48 +00:00
nsBaseDragService.cpp
nsBaseDragService.h
nsBaseFilePicker.cpp Bug 1708289 - Implement AllowFileSelectionDialogs policy r=fluent-reviewers,mkaply,emilio,Gijs,bolsson,win-reviewers,rkraesig 2024-02-01 00:48:24 +00:00
nsBaseFilePicker.h Bug 1708289 - Implement AllowFileSelectionDialogs policy r=fluent-reviewers,mkaply,emilio,Gijs,bolsson,win-reviewers,rkraesig 2024-02-01 00:48:24 +00:00
nsBaseWidget.cpp Bug 1878793 - Some drag events aren't fired on xorigin frame. r=botond 2024-02-08 02:36:23 +00:00
nsBaseWidget.h
nsClipboardHelper.cpp
nsClipboardHelper.h
nsClipboardProxy.cpp Bug 1871135 - Add content analysis support to clipboard operations r=edgar,nika,masayuki,devtools-reviewers 2024-02-13 11:26:48 +00:00
nsClipboardProxy.h
nsColorPickerProxy.cpp
nsColorPickerProxy.h
nsContentProcessWidgetFactory.h
nsCUPSShim.cpp
nsCUPSShim.h
nsDeviceContextSpecProxy.cpp
nsDeviceContextSpecProxy.h
nsDragServiceProxy.cpp
nsDragServiceProxy.h
nsFilePickerProxy.cpp
nsFilePickerProxy.h
nsGUIEventIPC.h
nsHTMLFormatConverter.cpp
nsHTMLFormatConverter.h
nsIApplicationChooser.idl
nsIAppShell.idl
nsIBaseWindow.cpp
nsIBaseWindow.idl
nsIBidiKeyboard.idl
nsIClipboard.idl Bug 1871135 - Add content analysis support to clipboard operations r=edgar,nika,masayuki,devtools-reviewers 2024-02-13 11:26:48 +00:00
nsIClipboardHelper.idl
nsIClipboardOwner.idl
nsIColorPicker.idl
nsIDeviceContextSpec.cpp
nsIDeviceContextSpec.h
nsIDisplayInfo.idl
nsIDragService.idl
nsIDragSession.idl
nsIFilePicker.idl
nsIFormatConverter.idl
nsIGfxInfo.idl Bug 1826412: Rip out all the ugly and move it to nsIGfxInfo r=jfkthame,fluent-reviewers,flod 2024-02-05 21:19:16 +00:00
nsIGfxInfoDebug.idl
nsIGtkTaskbarProgress.idl
nsIJumpListBuilder.idl
nsILegacyJumpListBuilder.idl
nsILegacyJumpListItem.idl
nsIMacDockSupport.idl
nsIMacFinderProgress.idl
nsIMacSharingService.idl
nsIMacUserActivityUpdater.idl
nsIMacWebAppUtils.idl
nsIPaper.idl
nsIPaperMargin.idl
nsIPrintDialogService.idl
nsIPrinter.idl
nsIPrinterList.idl
nsIPrintSettings.idl
nsIPrintSettingsService.idl
nsIPrintSettingsWin.idl
nsIRollupListener.h
nsIScreen.idl
nsIScreenManager.idl
nsISharePicker.idl
nsISound.idl
nsIStandaloneNativeMenu.idl
nsISystemStatusBar.idl
nsITaskbarOverlayIconController.idl
nsITaskbarPreview.idl
nsITaskbarPreviewButton.idl
nsITaskbarPreviewController.idl
nsITaskbarProgress.idl
nsITaskbarTabPreview.idl
nsITaskbarWindowPreview.idl
nsITouchBarHelper.idl
nsITouchBarInput.idl
nsITouchBarUpdater.idl
nsITransferable.idl Bug 1871135 - Add content analysis support to clipboard operations r=edgar,nika,masayuki,devtools-reviewers 2024-02-13 11:26:48 +00:00
nsIUserIdleService.idl
nsIUserIdleServiceInternal.idl
nsIWidget.h
nsIWidgetListener.cpp
nsIWidgetListener.h
nsIWindowsUIUtils.idl
nsIWinTaskbar.idl
nsNativeTheme.cpp
nsNativeTheme.h
nsPaper.cpp
nsPaper.h
nsPaperMargin.cpp
nsPaperMargin.h
nsPrimitiveHelpers.cpp
nsPrimitiveHelpers.h
nsPrinterBase.cpp
nsPrinterBase.h
nsPrinterCUPS.cpp
nsPrinterCUPS.h
nsPrinterListBase.cpp
nsPrinterListBase.h
nsPrinterListCUPS.cpp
nsPrinterListCUPS.h
nsPrintSettingsImpl.cpp
nsPrintSettingsImpl.h
nsPrintSettingsService.cpp
nsPrintSettingsService.h
nsTransferable.cpp Bug 1871135 - Add content analysis support to clipboard operations r=edgar,nika,masayuki,devtools-reviewers 2024-02-13 11:26:48 +00:00
nsTransferable.h Bug 1871135 - Add content analysis support to clipboard operations r=edgar,nika,masayuki,devtools-reviewers 2024-02-13 11:26:48 +00:00
nsUserIdleService.cpp
nsUserIdleService.h
nsWidgetsCID.h
nsXPLookAndFeel.cpp Bug 1881488 - Use a static pref for tooltip delay. r=masayuki,dom-core 2024-02-22 12:59:41 +00:00
nsXPLookAndFeel.h Bug 1539998 [Linux] Implement nsLookAndFeel::GetTitlebarAction() r=emilio 2024-01-30 20:18:13 +00:00
PClipboardReadRequest.ipdl
PClipboardWriteRequest.ipdl
PrintBackgroundTask.h
PuppetBidiKeyboard.cpp
PuppetBidiKeyboard.h
PuppetWidget.cpp
PuppetWidget.h
RemoteLookAndFeel.cpp
RemoteLookAndFeel.h
Screen.cpp
Screen.h
ScreenManager.cpp
ScreenManager.h
ScrollbarDrawing.cpp
ScrollbarDrawing.h
ScrollbarDrawingAndroid.cpp
ScrollbarDrawingAndroid.h
ScrollbarDrawingCocoa.cpp
ScrollbarDrawingCocoa.h
ScrollbarDrawingGTK.cpp
ScrollbarDrawingGTK.h
ScrollbarDrawingWin11.cpp
ScrollbarDrawingWin11.h
ScrollbarDrawingWin.cpp
ScrollbarDrawingWin.h
SharedWidgetUtils.cpp
SwipeTracker.cpp
SwipeTracker.h
SystemTimeConverter.h
TextEventDispatcher.cpp
TextEventDispatcher.h
TextEventDispatcherListener.h
TextEvents.h Bug 1877019 - Reflect user activation modifiers for keyboard event only if it likely activates a link or a link-like button. r=smaug 2024-02-03 04:50:41 +00:00
TextRange.h
TextRecognition.cpp
TextRecognition.h
Theme.cpp
Theme.h
ThemeChangeKind.h
ThemeCocoa.cpp
ThemeCocoa.h
ThemeColors.cpp Bug 1879386 - Make sure we respect the "must use light colors" bit in non-native theme drawing. r=morgan 2024-02-12 20:12:39 +00:00
ThemeColors.h Bug 1879386 - Make sure we respect the "must use light colors" bit in non-native theme drawing. r=morgan 2024-02-12 20:12:39 +00:00
ThemeDrawing.cpp
ThemeDrawing.h
TouchEvents.h
TouchResampler.cpp
TouchResampler.h
VsyncDispatcher.cpp
VsyncDispatcher.h
WidgetEventImpl.cpp
WidgetMessageUtils.h
WidgetTraceEvent.h
WidgetUtils.cpp
WidgetUtils.h
WindowButtonType.h
WindowOcclusionState.h