gecko-dev/tools/profiler
Jon Coppeard 4bbdd05fd0 Bug 1896068 - Don't call into the JS engine with gecko profiler mutex held to avoid deadlock r=profiler-reviewers,mstange
Based on mstange's comment in https://phabricator.services.mozilla.com/D209919:

> I agree that it's a bad idea to call PollJSSampling() while the profiler
> lock is being held. I think we should move all calls to PollJSSampling() out
> of any locked_profiler_* functions.

I removed the calls to PollJSSampling() for the current thread from the places
this happened while the lock was held and moved them after the locked
region (replacing them with PollJSSamplingForCurrentThread()).

Mostly this was straightforward except for profiler_clear_js_context() since
PollJSSampling() needs to happen before ClearJSContext() clears mJSContext.

I confirmed that this fixes the deadlock.

Differential Revision: https://phabricator.services.mozilla.com/D210630
2024-05-24 08:59:53 +00:00
..
core Bug 1896068 - Don't call into the JS engine with gecko profiler mutex held to avoid deadlock r=profiler-reviewers,mstange 2024-05-24 08:59:53 +00:00
docs Bug 1715286 - Document the Android profiler marker API r=profiler-reviewers,julienw,aabh 2024-04-16 21:22:51 +00:00
gecko Bug 1831092 - Use the new pull-based API for all crash annotations and remove the global annotations table r=jgilbert,necko-reviewers,media-playback-reviewers,profiler-reviewers,win-reviewers,padenot,handyman,afranchuk,valentin,alwu,sotaro 2024-03-04 10:24:43 +00:00
lul
public Bug 1817163 - Add a profiler feature for memory tracking to enable the memory hooks r=profiler-reviewers,perftest-reviewers,android-reviewers,kshampur,aabh,gl 2024-04-30 10:35:47 +00:00
rust-api Bug 1877380 - Use AtomicU32::from_ptr implementation instead of a reference for RacyFeatures_sActiveAndFeatures r=aabh,profiler-reviewers,glandium 2024-02-02 15:33:28 +00:00
rust-helper Bug 1875006 - Upgrade memmap2 to 0.9.3. r=emilio,supply-chain-reviewers,profiler-reviewers,mstange 2024-01-24 20:33:52 +00:00
tests Bug 1896582 - Do not stream profilerOverhead if it's not explicitly requested r=florian,profiler-reviewers 2024-05-21 07:24:37 +00:00
moz.build Bug 1888483 - Support power profiling on Android, r=profiler-reviewers,canaltinova. 2024-04-05 19:10:34 +00:00