gecko-dev/dom/base/Comment.h
Nathan Froyd 846d8789ee Bug 1492894 - part 1 - make the node hierarchy consistently constructed with NodeInfo&&; r=mccr8
Various places in dom/ use the pattern:

  already_AddRefed<NodeInfo> ni = ...;

which is supposed to be disallowed by our static analysis code, but
isn't, for whatever reason.  To fix our static analysis code, we need to
eliminate instances of the above pattern.

Unfortunately, eliminating this pattern requires restructuring how Nodes
are created.  Most Node subclasses take `already_AddRefed<NodeInfo>&` in
their constructors, and a few accept `already_AddRefed<NodeInfo>&&`.  We
need to enforce the latter pattern consistently, which requires changing
dozens of source files.
2018-09-21 16:45:49 -04:00

70 lines
1.8 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef mozilla_dom_Comment_h
#define mozilla_dom_Comment_h
#include "mozilla/Attributes.h"
#include "mozilla/dom/CharacterData.h"
namespace mozilla {
namespace dom {
class Comment final : public CharacterData
{
private:
void Init()
{
MOZ_ASSERT(mNodeInfo->NodeType() == COMMENT_NODE,
"Bad NodeType in aNodeInfo");
}
virtual ~Comment();
public:
explicit Comment(already_AddRefed<mozilla::dom::NodeInfo>&& aNodeInfo)
: CharacterData(std::move(aNodeInfo))
{
Init();
}
explicit Comment(nsNodeInfoManager* aNodeInfoManager)
: CharacterData(aNodeInfoManager->GetCommentNodeInfo())
{
Init();
}
NS_IMPL_FROMNODE_HELPER(Comment, IsComment())
// nsISupports
NS_INLINE_DECL_REFCOUNTING_INHERITED(Comment, CharacterData)
virtual already_AddRefed<CharacterData>
CloneDataNode(mozilla::dom::NodeInfo *aNodeInfo,
bool aCloneText) const override;
#ifdef DEBUG
virtual void List(FILE* out, int32_t aIndent) const override;
virtual void DumpContent(FILE* out = stdout, int32_t aIndent = 0,
bool aDumpAll = true) const override
{
return;
}
#endif
static already_AddRefed<Comment>
Constructor(const GlobalObject& aGlobal, const nsAString& aData,
ErrorResult& aRv);
protected:
virtual JSObject* WrapNode(JSContext *aCx, JS::Handle<JSObject*> aGivenProto) override;
};
} // namespace dom
} // namespace mozilla
#endif // mozilla_dom_Comment_h