gecko-dev/mozglue/baseprofiler
Gerald Squelart e62f237161 Bug 1670547 - Made AutoArraySchemaWriter safer and more efficient - r=canaltinova
`AutoArraySchemaWriter::FreeFormElement()` is never used, we can remove it.

When constructed, `AutoArraySchemaWriter` was optionally taking a `UniqueStrings` reference, which was stored as a pointer.
Then `AutoArraySchemaWriter::StringElement()` would do a dangerous `MOZ_RELEASE_ASSERT(mStrings);`.

The class is now split in two:
- `AutoArraySchemaWriter`, which does not deal with strings at all, so we don't need a pointer to `UniqueStrings`.
- `AutoArraySchemaWithStringsWriter` that can also deal with strings, in which we store a (non-null) `UniqueStrings` reference.

This is both:
- Safer, because it's not possible to instantiate the non-string writer and try to write a string.
- More efficient, because we don't need to pass&store a `UniqueStrings` reference/pointer when we don't deal with strings.

Differential Revision: https://phabricator.services.mozilla.com/D93191
2020-10-12 23:26:10 +00:00
..
core Bug 1670547 - Made AutoArraySchemaWriter safer and more efficient - r=canaltinova 2020-10-12 23:26:10 +00:00
lul Bug 1654128 - Added missing #includes in baseprofiler/lul - r=canaltinova 2020-07-21 08:20:20 +00:00
public Bug 1670046 - If NoPayload marker has a stack and/or inner window id, convert to NoPayloadUserData - r=gregtatum 2020-10-09 13:00:48 +00:00
moz.build Bug 1646266 - ProfilerMarkers skeleton files - r=gregtatum 2020-09-02 03:55:43 +00:00