mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-14 13:55:43 +00:00
a1b715b5df
This change splits PLDHashTable::Iterator::NextEntry() into two separate
functions, which allow you to get the current element and advance the iterator
separately, which means you can use a for-loop to iterate instead of a
while-loop.
As part of this change, the internals of PLDHashTable::Iterator were
significantly changed and simplified (and modelled after js::HashTable's
equivalent code). It's no longer duplicating code from PL_DHashTableEnumerator.
The chaos mode code was a casualty of this, but given how unreliable that code
has proven to be (see bug 1173212, bug 1174046) this is for the best. (We can
reimplement chaos mode once PLDHashTable::Iterator is back on more solid
footing again, if we think it's important.)
All these changes will make it much easier to add an alternative Iterator that
removes elements, which was turning out to be difficult with the prior code.
In order to make the for-loop header usually fit on a single line, I
deliberately renamed a bunch of things to have shorter names.
In summary, you used to write this:
PLDHashTable::Iterator iter(&table);
while (iter.HasMoreEntries()) {
auto entry = static_cast<FooEntry*>(iter.NextEntry());
// ... do stuff with |entry| ...
}
// iter's scope extends beyond here
and now you write this:
for (auto iter = table.Iter(); !iter.Done(); iter.Next()) {
auto entry = static_cast<FooEntry*>(iter.Get());
// ... do stuff with |entry| ...
}
// iter's scope doesn't reach here
--HG--
extra : rebase_source : fa5cac2fc50b1ab7624030bced4763131280f4d8
|
||
|---|---|---|
| .. | ||
| bug656331_component | ||
| component | ||
| component_no_aslr | ||
| external | ||
| gtest | ||
| regorder | ||
| static-checker | ||
| unit | ||
| windows | ||
| Makefile.in | ||
| MoreTestingAtomList.h | ||
| MoreTestingAtoms.cpp | ||
| MoreTestingAtoms.h | ||
| moz.build | ||
| NotXPCOMTest.idl | ||
| nsIFileEnumerator.cpp | ||
| RegFactory.cpp | ||
| resources.h | ||
| ShowAlignments.cpp | ||
| SizeTest01.cpp | ||
| SizeTest02.cpp | ||
| SizeTest03.cpp | ||
| SizeTest04.cpp | ||
| SizeTest05.cpp | ||
| SizeTest06.cpp | ||
| test.properties | ||
| TestArguments.cpp | ||
| TestAtoms.cpp | ||
| TestAutoPtr.cpp | ||
| TestAutoRef.cpp | ||
| TestBase64.cpp | ||
| TestBlockingProcess.cpp | ||
| TestCallTemplates.cpp | ||
| TestCOMArray.cpp | ||
| TestCOMPtr.cpp | ||
| TestCOMPtrEq.cpp | ||
| TestDeadlockDetector.cpp | ||
| TestDeadlockDetectorScalability.cpp | ||
| TestDeque.cpp | ||
| TestFile.cpp | ||
| TestHarness.h | ||
| TestHashtables.cpp | ||
| TestID.cpp | ||
| TestingAtomList.h | ||
| TestingAtoms.cpp | ||
| TestingAtoms.h | ||
| TestINIParser.cpp | ||
| TestJemalloc.cpp | ||
| TestNsRefPtr.cpp | ||
| TestObserverArray.cpp | ||
| TestObserverService.cpp | ||
| TestPipe.cpp | ||
| TestPLDHash.cpp | ||
| TestPRIntN.cpp | ||
| TestQuickReturn.cpp | ||
| TestRacingServiceManager.cpp | ||
| TestRegistrationOrder.cpp | ||
| TestShutdown.cpp | ||
| TestStackCrawl.cpp | ||
| TestStaticAtoms.cpp | ||
| TestSTLWrappers.cpp | ||
| TestStreamUtils.cpp | ||
| TestStringAPI.cpp | ||
| TestTArray.cpp | ||
| TestTextFormatter.cpp | ||
| TestThreadPoolListener.cpp | ||
| TestThreadUtils.cpp | ||
| TestTimers.cpp | ||
| TestUnicodeArguments.cpp | ||
| TestWinReg.js | ||