timeless%mozdev.org cd70f66472 Bug 348627 O(N^2) or worse algorithm in error console ... r=bz sr=bz Perhaps an explanation. String concatenation is a chance for garbage collection. If you have unbounded input, this can be pretty bad. When you start running low on memory, the garbage collector gets desperate and won't take shortcuts. Worst of all, the original code generates one string of garbage every iteration starting with the second or third. This code uses a=[] to construct an array and a[n] to set the upper array boundary, 0 being the lower, and there are n slots between a[0] and a[n]. join() will build a string with n copies of the join argument, where n is the number of slots between between cells. So for: a=[]; a[1]=''; there's 1 slot between [0] and [1]. The array's length is actually 2, but the joined length will be 1. While it is possible to use new Array(x), the behavior is different because the array has length x and there are x-1 spaces between cells. This leads to code which would be both much longer and harder to read. And definitely not particularly intuitive. The code used here otoh, while magical will hopefully require you to pause, think, and quickly understand what's going on. If not, you paused long enough for this bubble to appear and explain it to you :).		2006-08-14 22:03:34 +00:00
..
appshell	Set the chromehidden attribute earlier, so we don't have to reresolve style and	2006-07-25 00:20:33 +00:00
bootstrap	Bug 348381 Tidy up browser-prefs.js and console ifdefs. r=Benjamin,sr=Neil	2006-08-14 18:01:27 +00:00
browser	Bug 347884 Building XULRunner with --embedding-profile=minimal failed, tkhstory	2006-08-14 15:49:06 +00:00
communicator	cvs remove files that are unused now, due to the checkin for bug 334936, this had r+sr=Neil	2006-07-29 15:30:35 +00:00
components	Bug 348627 O(N^2) or worse algorithm in error console	2006-08-14 22:03:34 +00:00
global	Bug 343884 Column order was reset on restart r=enn sr=jag	2006-08-14 10:28:15 +00:00
test
.cvsignore
Makefile.in
xpfe.pkg