mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-19 16:25:38 +00:00
a50a0700d4
If insertion string ends with ASCII whitespace and there is no following content in the block, `HTMLEditRules::AdjustWhitespaces()` needs to insert `<br>` element. It's called only by `HTMLEditRules::AfterEditInner()` and that does only simple things with `WSRunObject`. Therefore, this moves the code into `AfterEditInner()`. For making it adjust the whitespaces, `HTMLEditRules::WillInsertText()` needs to notify `AfterEditInner()` of dirty range with `mDocChangeRange`. Therefore, this patch makes it set `mDocChangeRange` manually after inserting composition string. On the other hand, there is another bug. `WSRunObject` was designed to treat only inserting text for `WSRunObject::InsertText()`. I.e., not designed to treat replacing existing composition string with new string. Therefore, `WSRunObject::InsertText()` adjusts whitespaces only around start of composition string. Therefore, if composition string ends with an ASCII whitespace, it's not replaced with NBSP and that causes: - failing `WSRunObject::AdjustWhitespaces()` inserts `<br>` element at `AfterEditInner()` of committing composition. - then, next composition's first `WSRunObject::InsertText()` removes the last whitespace due to not followed by `<br>` nor any other content. Therefore, this patch makes `WSRunObject` takes 2 DOM points to be able to treat replaced range. In strictly speaking, the latter change require more changes and tests for supporting replacement with any other methods. However, it's risky and out of scope of this bug. Differential Revision: https://phabricator.services.mozilla.com/D26423 --HG-- extra : moz-landing-system : lando |
||
|---|---|---|
| .. | ||
| browser | ||
| unit | ||
| .eslintrc.js | ||
| bug586713_window.xul | ||
| chrome_context_menus_win.xul | ||
| chrome.ini | ||
| empty_window.xul | ||
| file_bug596600.html | ||
| file_input_events_on_deactive_window.html | ||
| file_secure_input.html | ||
| mochitest.ini | ||
| moz.build | ||
| native_menus_window.xul | ||
| native_mouse_mac_window.xul | ||
| standalone_native_menu_window.xul | ||
| system_font_changes.xul | ||
| taskbar_previews.xul | ||
| test_actionhint.html | ||
| test_AltGr_key_events_in_web_content_on_windows.html | ||
| test_assign_event_data.html | ||
| test_bug343416.xul | ||
| test_bug413277.html | ||
| test_bug428405.xul | ||
| test_bug429954.xul | ||
| test_bug444800.xul | ||
| test_bug466599.xul | ||
| test_bug478536.xul | ||
| test_bug485118.xul | ||
| test_bug517396.xul | ||
| test_bug522217.xul | ||
| test_bug538242.xul | ||
| test_bug565392.html | ||
| test_bug586713.xul | ||
| test_bug593307.xul | ||
| test_bug596600.xul | ||
| test_bug673301.xul | ||
| test_bug760802.xul | ||
| test_bug1123480.xul | ||
| test_bug1151186.html | ||
| test_chrome_context_menus_win.xul | ||
| test_clipboard.xul | ||
| test_composition_text_querycontent.xul | ||
| test_imestate.html | ||
| test_input_events_on_deactive_window.xul | ||
| test_key_event_counts.xul | ||
| test_keycodes.xul | ||
| test_keypress_event_with_alt_on_mac.html | ||
| test_mouse_scroll.xul | ||
| test_native_key_bindings_mac.html | ||
| test_native_menus.xul | ||
| test_native_mouse_mac.xul | ||
| test_panel_mouse_coords.xul | ||
| test_picker_no_crash.html | ||
| test_platform_colors.xul | ||
| test_plugin_input_event.html | ||
| test_plugin_scroll_consistency.html | ||
| test_position_on_resize.xul | ||
| test_scrollbar_colors.html | ||
| test_secure_input.html | ||
| test_sizemode_events.xul | ||
| test_standalone_native_menu.xul | ||
| test_system_font_changes.xul | ||
| test_system_status_bar.xul | ||
| test_taskbar_progress.xul | ||
| test_transferable_overflow.xul | ||
| test_wheeltransaction.xul | ||
| TestAppShellSteadyState.cpp | ||
| TestChromeMargin.cpp | ||
| utils.js | ||
| window_bug429954.xul | ||
| window_bug478536.xul | ||
| window_bug522217.xul | ||
| window_bug538242.xul | ||
| window_bug593307_centerscreen.xul | ||
| window_bug593307_offscreen.xul | ||
| window_composition_text_querycontent.xul | ||
| window_imestate_iframes.html | ||
| window_mouse_scroll_win.html | ||
| window_picker_no_crash_child.html | ||
| window_state_windows.xul | ||
| window_wheeltransaction.xul | ||