mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-22 17:55:50 +00:00
ab700f9fc0
They were not displayed in the UI, and the instructions to initialize the line
field of a stack frame increased code size unnecessarily.
This change reduces the binary size on Linux x64 by around 100KB.
Here's a diff of the impact on the code generated for Attr_Binding::get_specified
in the Mac build:
@@ -20,17 +20,16 @@
movq 0x8(%rbx), %rax
movq %r12, %rcx
shlq $0x5, %rcx
leaq aGetAttrspecifi, %rdx ; "get Attr.specified"
movq %rdx, (%rax,%rcx)
movq $0x0, 0x8(%rax,%rcx)
leaq -40(%rbp), %rdx
movq %rdx, 0x10(%rax,%rcx)
- movl $0x106, 0x18(%rax,%rcx)
movl $0x1c, 0x1c(%rax,%rcx)
leal 0x1(%r12), %eax
movl %eax, 0x10(%rbx)
movq %r15, %rdi
call __ZNK7mozilla3dom4Attr9SpecifiedEv ; mozilla::dom::Attr::Specified() const
movzxl %al, %eax
movabsq $0xfff9000000000000, %rcx
Depends on D9193
Differential Revision: https://phabricator.services.mozilla.com/D9195
--HG--
extra : moz-landing-system : lando
60 lines
2.1 KiB
C++
60 lines
2.1 KiB
C++
/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef mozilla_AutoProfilerLabel_h
|
|
#define mozilla_AutoProfilerLabel_h
|
|
|
|
#include "mozilla/Attributes.h"
|
|
#include "mozilla/GuardObjects.h"
|
|
#include "mozilla/Types.h"
|
|
|
|
// The Gecko Profiler defines AutoProfilerLabel, an RAII class for
|
|
// pushing/popping frames to/from the ProfilingStack.
|
|
//
|
|
// This file defines a class of the same name that does much the same thing,
|
|
// but which can be used in (and only in) mozglue. A different class is
|
|
// necessary because mozglue cannot directly access sProfilingStack.
|
|
//
|
|
// Note that this class is slightly slower than the other AutoProfilerLabel,
|
|
// and it lacks the macro wrappers. It also is effectively hardwired to use
|
|
// js::ProfilingStackFrame::Category::OTHER as the category, because that's what
|
|
// the callbacks provided by the profiler use. (Specifying the category in
|
|
// this file would require #including ProfilingStack.h in mozglue, which we
|
|
// don't want to do.)
|
|
|
|
class ProfilingStack;
|
|
|
|
namespace mozilla {
|
|
|
|
typedef ProfilingStack* (*ProfilerLabelEnter)(const char*, const char*, void*);
|
|
typedef void (*ProfilerLabelExit)(ProfilingStack*);
|
|
|
|
// Register callbacks that do the entry/exit work involving sProfilingStack.
|
|
MFBT_API void RegisterProfilerLabelEnterExit(ProfilerLabelEnter aEnter,
|
|
ProfilerLabelExit aExit);
|
|
|
|
// This #ifdef prevents this AutoProfilerLabel from being defined in libxul,
|
|
// which would conflict with the one in the profiler.
|
|
#ifdef IMPL_MFBT
|
|
|
|
class MOZ_RAII AutoProfilerLabel
|
|
{
|
|
public:
|
|
AutoProfilerLabel(const char* aLabel, const char* aDynamicString
|
|
MOZ_GUARD_OBJECT_NOTIFIER_PARAM);
|
|
~AutoProfilerLabel();
|
|
|
|
private:
|
|
MOZ_DECL_USE_GUARD_OBJECT_NOTIFIER
|
|
ProfilingStack* mProfilingStack;
|
|
};
|
|
|
|
#endif
|
|
|
|
} // namespace mozilla
|
|
|
|
#endif // mozilla_AutoProfilerLabel_h
|