gecko-dev/js/xpconnect/idl
Daniel Holbert 3c368026cb Bug 1798068 part 2: Expand JS::MutableHandleIdVector to more verbose typename in nsIXPCScriptable.idl, to satisfy static-analysis rule. r=xpcom-reviewers,mccr8
This patch doesn't change behavior; it's just expanding an abbreviated typename.

Without this patch, my local static-analysis build fails with the following
error for mozStorageStatementJSHelper.h (which has a class that implements
nsIXPCScriptable and is outside of SpiderMonkey):

"error: The fully qualified types are preferred over the shorthand typedefs for
JS::Handle/JS::Rooted types outside SpiderMonkey."

The error message points to the NS_DECL_NSIXPCSCRIPTABLE macro, and
specifically to a usage of this typename inside of that macro.  This patch's
type-expansion seems to appease this static analysis rule.

Before this patch, the type here was `JS::MutableHandleIdVector` which is a
typedef for `MutableHandle<StackGCVector<JS::PropertyKey>>` as defined here:
https://searchfox.org/mozilla-central/rev/fe5c9c39a879b07d5b629257f63d825c3c8cd0ed/js/public/TypeDecls.h#98

After this patch, the type here is `JS::MutableHandleVector<JS::PropertyKey>`
(which I took from the static analysis error message's suggestion). That
expands to the same full-qualified type, since `MutableHandleVector<T>` is an
alias for `MutableHandle<StackGCVector<T>>` as defined here:
https://searchfox.org/mozilla-central/rev/fe5c9c39a879b07d5b629257f63d825c3c8cd0ed/js/public/TypeDecls.h#128

Differential Revision: https://phabricator.services.mozilla.com/D160690
2022-10-28 23:11:46 +00:00
..
moz.build Bug 1792334 - Decom nsIXPConnect and friends. r=mccr8 2022-10-12 22:26:12 +00:00
mozIJSSubScriptLoader.idl
nsIXPCScriptable.idl Bug 1798068 part 2: Expand JS::MutableHandleIdVector to more verbose typename in nsIXPCScriptable.idl, to satisfy static-analysis rule. r=xpcom-reviewers,mccr8 2022-10-28 23:11:46 +00:00
xpccomponents.idl Bug 1795164: Replace Cu.generateXPCWrappedJS with Cu.getDebugName. r=mccr8 2022-10-14 22:49:20 +00:00
xpcIJSWeakReference.idl