mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-25 03:05:34 +00:00
Read-only Git mirror of the Mercurial gecko repositories at https://hg.mozilla.org. How to contribute: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
aab95deee0
Automatic update from web-platform-tests[css-properties-values-api] Support repeated values in Typed OM. This patch fixes two similar problems: 1. Computed list-valued properties show up as a CSSStyleValue when calling computedStyleMap().get(name). 2. Computed list-valued properties show up as a CSSStyleValue when calling computedStyleMap().getAll(name). The fixes are also similar: 1. StylePropertyMapReadOnly::get only checked property.IsRepeated() when determining whether it should look inside a possible list. However, CSSPropertyVariable is never repeated. This is because CSSPropertyVariable does not represent a single, specific custom property, but rather _all_ custom properties. For CSSPropertyVariable, if we have a CSSValueList, it means that it is registered with either '<foo>+', or '<foo>#', and that makes it a "list valued property" [1]. 2. Similar to (1), the value would be treated as unsupported if property. IsRepeated() was false. Again, a situation of CSSPropertyVariable+ CSSValueList means that the property is registered as a list. Note1: The value for a custom property can only be a CSSValueList if the runtime enabled feature CSSVariables2 is enabled. In all other cases, it's a CSSCustomPropertyDeclaration. See ComputedStyleCSSValueMapping::Get ('registry' is nullptr without the feature). Note2: It might make more sense to ignore the repeatability of the property, and instead just look at whether we actually have a CSSValueList, but such a change would require a change of the css-typed-om spec. [1] https://drafts.css-houdini.org/css-typed-om-1/#list-valued-properties https://drafts.css-houdini.org/css-typed-om-1/#reify-stylevalue R=chrishtr@chromium.org Bug: 862152 Change-Id: Ic854f54f14313b6b683601d0677dcc1dd4205ccd Reviewed-on: https://chromium-review.googlesource.com/1136295 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#575166} -- wpt-commits: 59fa23d519b9d6ef0892170ba86ef0b9aee6ad24 wpt-pr: 11964 |
||
---|---|---|
.cargo | ||
.vscode | ||
accessible | ||
browser | ||
build | ||
caps | ||
chrome | ||
config | ||
db | ||
devtools | ||
docshell | ||
dom | ||
editor | ||
embedding | ||
extensions | ||
gfx | ||
gradle/wrapper | ||
hal | ||
image | ||
intl | ||
ipc | ||
js | ||
layout | ||
media | ||
memory | ||
mfbt | ||
mobile | ||
modules | ||
mozglue | ||
netwerk | ||
nsprpub | ||
other-licenses | ||
parser | ||
python | ||
security | ||
services | ||
servo | ||
startupcache | ||
storage | ||
taskcluster | ||
testing | ||
third_party | ||
toolkit | ||
tools | ||
uriloader | ||
view | ||
widget | ||
xpcom | ||
xpfe/appshell | ||
.arcconfig | ||
.clang-format | ||
.clang-format-ignore | ||
.cron.yml | ||
.eslintignore | ||
.eslintrc.js | ||
.flake8 | ||
.gdbinit | ||
.gdbinit_python | ||
.gitignore | ||
.hgignore | ||
.hgtags | ||
.inferconfig | ||
.lldbinit | ||
.mailmap | ||
.taskcluster.yml | ||
.yamllint | ||
.ycm_extra_conf.py | ||
aclocal.m4 | ||
AUTHORS | ||
build.gradle | ||
Cargo.lock | ||
Cargo.toml | ||
client.mk | ||
client.py | ||
CLOBBER | ||
configure.in | ||
configure.py | ||
GNUmakefile | ||
gradle.properties | ||
gradlew | ||
LEGAL | ||
LICENSE | ||
mach | ||
Makefile.in | ||
moz.build | ||
moz.configure | ||
mozilla-config.h.in | ||
old-configure.in | ||
package-lock.json | ||
package.json | ||
Pipfile | ||
Pipfile.lock | ||
README.txt | ||
settings.gradle | ||
test.mozbuild |
An explanation of the Mozilla Source Code Directory Structure and links to project pages with documentation can be found at: https://developer.mozilla.org/en/Mozilla_Source_Code_Directory_Structure For information on how to build Mozilla from the source code, see: https://developer.mozilla.org/en/docs/Build_Documentation To have your bug fix / feature added to Mozilla, you should create a patch and submit it to Bugzilla (https://bugzilla.mozilla.org). Instructions are at: https://developer.mozilla.org/en/docs/Creating_a_patch https://developer.mozilla.org/en/docs/Getting_your_patch_in_the_tree If you have a question about developing Mozilla, and can't find the solution on https://developer.mozilla.org, you can try asking your question in a mozilla.* Usenet group, or on IRC at irc.mozilla.org. [The Mozilla news groups are accessible on Google Groups, or news.mozilla.org with a NNTP reader.] You can download nightly development builds from the Mozilla FTP server. Keep in mind that nightly builds, which are used by Mozilla developers for testing, may be buggy. Firefox nightlies, for example, can be found at: https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/ - or - https://www.mozilla.org/firefox/channel/desktop/#nightly