mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-17 07:15:46 +00:00
fdb4ec179c
We can totally get there with a negative percentage basis, see comment 0 for an example. We could keep the warning like: NS_WARNING_ASSERTION(clamping_mode == StyleAllowedNumericType::All || basis >= 0, "nscoord overflow?"); Which will catch cases where the style system would refuse to parse a negative <length-percentage>, but we got a negative percent basis, which would be weird. But that's a bit misleading since right now at least we rely on the caller to do the appropriate clamping. I also think that NS_WARNING_ASSERTION is not very useful, since we're not very likely to catch stuff with it. But anyhow, your call. Differential Revision: https://phabricator.services.mozilla.com/D22328 --HG-- extra : moz-landing-system : lando |
||
---|---|---|
.. | ||
base | ||
build | ||
doc | ||
forms | ||
generic | ||
inspector | ||
ipc | ||
mathml | ||
media | ||
painting | ||
printing | ||
reftests | ||
style | ||
svg | ||
tables | ||
tools | ||
xul | ||
moz.build |