gecko-dev/editor/libeditor
Masayuki Nakano 2bde324acf Bug 1501663 - part 7: HTMLEditor::GetSelectedElement() shouldn't return element node when Selection starts before the element node r=m_kato
This fixes odd case of this API.  GetSelectedElement() ignores non-element
nodes before an element node.  This must be intended to allow Selection to
start from in an element node.  However, current code allows to select starting
from previous text node.  This patch changes this behavior to stop looking
for element node if non-element node appears before an element node.

Differential Revision: https://phabricator.services.mozilla.com/D10703

--HG--
extra : moz-landing-system : lando
2018-11-05 11:38:10 +00:00
..
crashtests Bug 1451503 Move most reftest resources from chrome: to resource: r=kmag 2018-09-06 16:01:39 -07:00
tests Bug 1501663 - part 7: HTMLEditor::GetSelectedElement() shouldn't return element node when Selection starts before the element node r=m_kato 2018-11-05 11:38:10 +00:00
ChangeAttributeTransaction.cpp
ChangeAttributeTransaction.h
ChangeStyleTransaction.cpp Bug 1408301: Remove getPropertyCSSValue. r=bz 2018-05-12 11:23:47 +02:00
ChangeStyleTransaction.h
CompositionTransaction.cpp Bug 1463287: Add QueryInterface helper macro for concrete class types. r=bz 2018-05-21 16:33:18 -07:00
CompositionTransaction.h
CreateElementTransaction.cpp Bug 1480055 - part 2: Rename EditorBase::GetShouldTxnSetSelection() to EditorBase::AllowsTransactionsToChangeSelection() r=m_kato 2018-08-01 20:53:57 +09:00
CreateElementTransaction.h Bug 1447213 - Change editor methods which take |const EditorRawDOMPoint&| but called with EditorDOMPoint.AsRaw() to template methods r=m_kato 2018-03-20 14:05:47 +09:00
CSSEditUtils.cpp Bug 1465702 - part 5: Remove unnecessary Selection argument from editor module r=m_kato 2018-10-30 10:01:38 +00:00
CSSEditUtils.h Bug 1408301: Remove getPropertyCSSValue. r=bz 2018-05-12 11:23:47 +02:00
DeleteNodeTransaction.cpp Bug 1480663 - Make EditorBase::IsModifiableNode() non-virtual r=m_kato 2018-08-03 11:10:46 +00:00
DeleteNodeTransaction.h
DeleteRangeTransaction.cpp Bug 1480055 - part 2: Rename EditorBase::GetShouldTxnSetSelection() to EditorBase::AllowsTransactionsToChangeSelection() r=m_kato 2018-08-01 20:53:57 +09:00
DeleteRangeTransaction.h
DeleteTextTransaction.cpp Bug 1480663 - Make EditorBase::IsModifiableNode() non-virtual r=m_kato 2018-08-03 11:10:46 +00:00
DeleteTextTransaction.h Bug 1446533 part 2. Rename nsGenericDOMDataNode.{h,cpp} to CharacterData. r=mystor 2018-03-19 15:18:07 -04:00
EditAction.h Bug 1503473 - part 4: Create a new path to handle Enter key press in TextEditor r=m_kato 2018-11-03 11:22:13 +00:00
EditActionListener.h
EditAggregateTransaction.cpp
EditAggregateTransaction.h
EditorBase.cpp Bug 1465702 - part 7: Make protected/private methods of EditorBase/TextEditor/HTMLEditor use SelectionRefPtr() instead of GetSelection() r=m_kato 2018-10-30 10:04:08 +00:00
EditorBase.h Bug 1503457 - Add some variation of EditAction values for composition r=m_kato 2018-11-01 08:07:04 +00:00
EditorCommands.cpp Bug 1503473 - part 1: Rename TextEditor::OnInputParagraphSeparator() and HTMLEditor::OnInputLineBreak() r=m_kato 2018-11-03 11:19:07 +00:00
EditorCommands.h
EditorController.cpp
EditorController.h Bug 1489790 - Part 8: Remove the XPCOM component registration for @mozilla.org/editor/editorcontroller;1; r=baku 2018-09-11 09:58:33 -04:00
EditorDOMPoint.h Bug 1465478: Introduce Element::FromNode. r=smaug 2018-05-31 02:46:10 +02:00
EditorEventListener.cpp Bug 1497815 - Rename EditorEventListener::EnsureCommitCompoisition() to EditorEventListener::EnsureCommitComposition() r=m_kato 2018-10-11 09:12:15 +00:00
EditorEventListener.h Bug 1497815 - Rename EditorEventListener::EnsureCommitCompoisition() to EditorEventListener::EnsureCommitComposition() r=m_kato 2018-10-11 09:12:15 +00:00
EditorUtils.cpp Bug 1500862 - part 3: Change all stack base helper classes which access protected members of EditorBase to nested classes of EditorBase r=m_kato 2018-10-24 09:42:06 +00:00
EditorUtils.h Bug 1503473 - part 2: Make TextEditRules::WillInsertBreak() and HTMLEditRules::WillInsertBreak() return EditActionResult r=m_kato 2018-11-03 11:20:06 +00:00
EditTransactionBase.cpp
EditTransactionBase.h
HTMLAbsPositionEditor.cpp Bug 1465702 - part 7: Make protected/private methods of EditorBase/TextEditor/HTMLEditor use SelectionRefPtr() instead of GetSelection() r=m_kato 2018-10-30 10:04:08 +00:00
HTMLAnonymousNodeEditor.cpp Bug 1465702 - part 5: Remove unnecessary Selection argument from editor module r=m_kato 2018-10-30 10:01:38 +00:00
HTMLEditor.cpp Bug 1501663 - part 7: HTMLEditor::GetSelectedElement() shouldn't return element node when Selection starts before the element node r=m_kato 2018-11-05 11:38:10 +00:00
HTMLEditor.h Bug 1501663 - part 7: HTMLEditor::GetSelectedElement() shouldn't return element node when Selection starts before the element node r=m_kato 2018-11-05 11:38:10 +00:00
HTMLEditorCommands.cpp Bug 1465702 - part 4: Make public methods of HTMLEditor create AutoEditActionDataSetter if necessary r=m_kato 2018-10-30 10:00:17 +00:00
HTMLEditorCommands.h Bug 1468708 - Part 6. Move HTMLEditorCommands and HTMLEditorController to libeditor. r=masayuki 2018-06-13 14:49:06 -07:00
HTMLEditorController.cpp Bug 1449564 - part 2: Make absolute positioned element editor disabled in default and make it possible to enable it with new command r=m_kato 2018-04-04 22:27:49 +09:00
HTMLEditorController.h Bug 1489790 - Part 10: Remove the XPCOM component registration for @mozilla.org/editor/editordocstatecontroller;1; r=baku 2018-09-11 09:58:33 -04:00
HTMLEditorDataTransfer.cpp Bug 1503565 - Make HTMLEditor::BlobReader::OnResult() create AutoEditActionDataSetter r=m_kato 2018-11-05 02:12:27 +00:00
HTMLEditorDocumentCommands.cpp Bug 1485935 - Use NS_IMETHODIMP for implementation of HTMLEditor::GetIsCSSEnabled() r=m_kato 2018-08-28 09:46:53 +00:00
HTMLEditorEventListener.cpp Bug 1465702 - part 5: Remove unnecessary Selection argument from editor module r=m_kato 2018-10-30 10:01:38 +00:00
HTMLEditorEventListener.h Bug 1461708 - part 6: Make EditorEventListener::MouseClick() use WidgetMouseEvent instead of dom::MouseEvent r=m_kato 2018-10-10 12:05:21 +00:00
HTMLEditorObjectResizer.cpp Bug 1504093 - Make DocumentResizeEventListener::HandleEvent() call public methods of HTMLEditor r=m_kato 2018-11-05 06:28:53 +00:00
HTMLEditorObjectResizerUtils.h
HTMLEditRules.cpp Bug 1503473 - part 4: Create a new path to handle Enter key press in TextEditor r=m_kato 2018-11-03 11:22:13 +00:00
HTMLEditRules.h Bug 1503473 - part 2: Make TextEditRules::WillInsertBreak() and HTMLEditRules::WillInsertBreak() return EditActionResult r=m_kato 2018-11-03 11:20:06 +00:00
HTMLEditUtils.cpp Bug 1465702 - part 4: Make public methods of HTMLEditor create AutoEditActionDataSetter if necessary r=m_kato 2018-10-30 10:00:17 +00:00
HTMLEditUtils.h Bug 1465702 - part 4: Make public methods of HTMLEditor create AutoEditActionDataSetter if necessary r=m_kato 2018-10-30 10:00:17 +00:00
HTMLInlineTableEditor.cpp Bug 1465702 - part 4: Make public methods of HTMLEditor create AutoEditActionDataSetter if necessary r=m_kato 2018-10-30 10:00:17 +00:00
HTMLStyleEditor.cpp Bug 1465702 - part 7: Make protected/private methods of EditorBase/TextEditor/HTMLEditor use SelectionRefPtr() instead of GetSelection() r=m_kato 2018-10-30 10:04:08 +00:00
HTMLTableEditor.cpp Bug 1465702 - part 7: Make protected/private methods of EditorBase/TextEditor/HTMLEditor use SelectionRefPtr() instead of GetSelection() r=m_kato 2018-10-30 10:04:08 +00:00
HTMLURIRefObject.cpp Bug 1463981 part 2. Remove use of nsIDOMNode in editor xpidl. r=masayuki 2018-05-24 13:18:34 -04:00
HTMLURIRefObject.h Bug 1463981 part 2. Remove use of nsIDOMNode in editor xpidl. r=masayuki 2018-05-24 13:18:34 -04:00
InsertNodeTransaction.cpp Bug 1480055 - part 2: Rename EditorBase::GetShouldTxnSetSelection() to EditorBase::AllowsTransactionsToChangeSelection() r=m_kato 2018-08-01 20:53:57 +09:00
InsertNodeTransaction.h Bug 1447213 - Change editor methods which take |const EditorRawDOMPoint&| but called with EditorDOMPoint.AsRaw() to template methods r=m_kato 2018-03-20 14:05:47 +09:00
InsertTextTransaction.cpp Bug 1480055 - part 2: Rename EditorBase::GetShouldTxnSetSelection() to EditorBase::AllowsTransactionsToChangeSelection() r=m_kato 2018-08-01 20:53:57 +09:00
InsertTextTransaction.h
InternetCiter.cpp Bug 1264876 - Remove StripCites() from nsIEditorMailSupport r=m_kato 2018-07-19 16:55:31 +09:00
InternetCiter.h Bug 1264876 - Remove StripCites() from nsIEditorMailSupport r=m_kato 2018-07-19 16:55:31 +09:00
JoinNodeTransaction.cpp Bug 1480663 - Make EditorBase::IsModifiableNode() non-virtual r=m_kato 2018-08-03 11:10:46 +00:00
JoinNodeTransaction.h
ManualNAC.h
moz.build Bug 1485890 - Remove dumpContentTree, debugDumpContent and debugUnitTests from nsIEditor. r=masayuki 2018-10-29 07:23:49 +00:00
nsIAbsorbingTransaction.h
PlaceholderTransaction.cpp Bug 1469769 - Part 6: Replace non-failing NS_NOTREACHED with MOZ_ASSERT_UNREACHABLE. r=froydnj 2018-06-17 22:43:11 -07:00
PlaceholderTransaction.h Bug 1503207 - Remove nsWeakPtr.h and cleanup all files including weak reference-related headers r=froydnj 2018-10-31 20:39:03 +00:00
SelectionState.cpp Bug 358033 - Part 1. Restore direction of Selection. r=masayuki 2018-07-23 02:44:42 +00:00
SelectionState.h Bug 358033 - Part 1. Restore direction of Selection. r=masayuki 2018-07-23 02:44:42 +00:00
SplitNodeTransaction.cpp Bug 1480055 - part 2: Rename EditorBase::GetShouldTxnSetSelection() to EditorBase::AllowsTransactionsToChangeSelection() r=m_kato 2018-08-01 20:53:57 +09:00
SplitNodeTransaction.h Bug 1447213 - Change editor methods which take |const EditorRawDOMPoint&| but called with EditorDOMPoint.AsRaw() to template methods r=m_kato 2018-03-20 14:05:47 +09:00
TextEditor.cpp Bug 1503473 - part 4: Create a new path to handle Enter key press in TextEditor r=m_kato 2018-11-03 11:22:13 +00:00
TextEditor.h Bug 1503473 - part 4: Create a new path to handle Enter key press in TextEditor r=m_kato 2018-11-03 11:22:13 +00:00
TextEditorDataTransfer.cpp Bug 1503588 - Remove aDataLen parameter from nsITransferable.getAnyTransferData. r=smaug 2018-11-02 11:02:25 +00:00
TextEditRules.cpp Bug 1503473 - part 4: Create a new path to handle Enter key press in TextEditor r=m_kato 2018-11-03 11:22:13 +00:00
TextEditRules.h Bug 1503473 - part 2: Make TextEditRules::WillInsertBreak() and HTMLEditRules::WillInsertBreak() return EditActionResult r=m_kato 2018-11-03 11:20:06 +00:00
TextEditRulesBidi.cpp Bug 1465702 - part 6: Remove unnecessary Selection argument from TextEditRules and HTMLEditRules and rename/reimplement TextEditRules::SelectionRef() as TextEditRules::SelectionRefPtr() r=m_kato 2018-10-30 10:02:58 +00:00
TextEditUtils.cpp Bug 1449147 - Clean up more nsIDOMNode usages in editor. r=masayuki 2018-03-27 20:19:35 +09:00
TextEditUtils.h Bug 1449147 - Clean up more nsIDOMNode usages in editor. r=masayuki 2018-03-27 20:19:35 +09:00
TypeInState.cpp Bug 1465702 - part 5: Remove unnecessary Selection argument from editor module r=m_kato 2018-10-30 10:01:38 +00:00
TypeInState.h Bug 1445569 - part 4: Get rid of EditorBase::GetStartNodeAndOffset() and EditorBase::GetEndNodeAndOffset() r=m_kato 2018-03-15 21:25:41 +09:00
WSRunObject.cpp Bug 1465702 - part 5: Remove unnecessary Selection argument from editor module r=m_kato 2018-10-30 10:01:38 +00:00
WSRunObject.h Bug 1500862 - part 3: Change all stack base helper classes which access protected members of EditorBase to nested classes of EditorBase r=m_kato 2018-10-24 09:42:06 +00:00