mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-12-02 01:48:05 +00:00
6917a38081
BindContext was going to have way more information at first, but then I realized
that most of the things I wanted to know were basically a flag away using the
parent node.
Still I think it's worth it, now experimenting with BindToTree will only mean
adding a field to a struct that's included from a couple cpp files, instead of a
massive pain.
I also think this is clearer, and doing this highlights quite a few
inconsistencies in our code which I've left untouched, but commented with
FIXMEs.
Steps are:
$ for file in $(rg 'nsresult BindToTree\(' | cut -d : -f 1 | sort | uniq); do sed -i 's#nsresult BindToTree(Document\* aDocument, nsIContent\* aParent,#nsresult BindToTree(BindContext\&, nsINode\& aParent)#g' $file; done
$ for file in $(rg 'nsresult BindToTree\(' | cut -d : -f 1 | sort | uniq); do sed -i 's# nsIContent\* aBindingParent) override#override#g' $file; done
$ for file in $(rg '::BindToTree\(' | cut -d : -f 1 | sort | uniq); do sed -i 's#::BindToTree(Document\* aDocument, nsIContent\* aParent,#::BindToTree(BindContext\& aContext, nsINode\& aParent)#g' $file; done
$ for file in $(rg '::BindToTree\(' | cut -d : -f 1 | sort | uniq); do sed -i 's#nsIContent\* aBindingParent)##g' $file; done
$ for file in $(rg '::BindToTree\(' | cut -d : -f 1 | sort | uniq); do sed -i 's#::BindToTree(aDocument, aParent, aBindingParent)#::BindToTree(aContext, aParent)#g' $file; done
$ ./mach clang-format
Then manual fixups.
Depends on D32948
Differential Revision: https://phabricator.services.mozilla.com/D32949
|
||
|---|---|---|
| .. | ||
| builtin | ||
| crashtests | ||
| test | ||
| moz.build | ||
| nsBindingManager.cpp | ||
| nsBindingManager.h | ||
| nsXBLBinding.cpp | ||
| nsXBLBinding.h | ||
| nsXBLContentSink.cpp | ||
| nsXBLContentSink.h | ||
| nsXBLDocumentInfo.cpp | ||
| nsXBLDocumentInfo.h | ||
| nsXBLEventHandler.cpp | ||
| nsXBLEventHandler.h | ||
| nsXBLMaybeCompiled.h | ||
| nsXBLProtoImpl.cpp | ||
| nsXBLProtoImpl.h | ||
| nsXBLProtoImplField.cpp | ||
| nsXBLProtoImplField.h | ||
| nsXBLProtoImplMember.h | ||
| nsXBLProtoImplMethod.cpp | ||
| nsXBLProtoImplMethod.h | ||
| nsXBLProtoImplProperty.cpp | ||
| nsXBLProtoImplProperty.h | ||
| nsXBLPrototypeBinding.cpp | ||
| nsXBLPrototypeBinding.h | ||
| nsXBLPrototypeHandler.cpp | ||
| nsXBLPrototypeHandler.h | ||
| nsXBLSerialize.cpp | ||
| nsXBLSerialize.h | ||
| nsXBLService.cpp | ||
| nsXBLService.h | ||
| nsXBLWindowKeyHandler.cpp | ||
| nsXBLWindowKeyHandler.h | ||
| XBLChildrenElement.cpp | ||
| XBLChildrenElement.h | ||