mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-21 09:15:35 +00:00
ae34b55b6a
The current default value for height of Infinity has the unfortunate side effect that, when combined with using a XUL wrapper, there will be a large filler element stretching vertically on one side of the tooltip that effectively neuters all content beneath it. While this is probably fine for tooltips that are shown on hover, it is problematic if we want to use this for DevTools menus because it means the user is unable to click anything above/below the menu so long as it is open (which can be particularly problematic once we make HTMLTooltip support the "Disable popup autohide" feature"). Even if we were to decide that clicks outside the tooltip should be consumed anyway we would still have the problem that hover styles don't apply in this "dead" region. As a result, this patch makes the { height: Infinity } behaviour opt-in for those tooltips that really need it. For most uses, however, a height calculated when the tooltip is shown should be sufficient (and later in this patch series we will add a mechanism to HTMLTooltip to explicitly request it recalculate its size and position in response to content changes). This patch introduces the { height: "auto" } mechanism and also reverses the order in which size/position properties are calculated to match the regular manner in which layout is performed: widths first, then heights. MozReview-Commit-ID: 7BeVkxGVhYn --HG-- extra : rebase_source : 4f0d88b377e00efc9d443db1a5ef0a7d29295929 |
||
---|---|---|
.. | ||
client | ||
docs | ||
platform | ||
server | ||
shared | ||
startup | ||
.eslintrc.js | ||
.eslintrc.mochitests.js | ||
.eslintrc.xpcshell.js | ||
CODE_OF_CONDUCT.md | ||
moz.build | ||
templates.mozbuild |