mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-15 06:15:43 +00:00
afba49d5ab
This version addresses some popup sizing bugs, and also a few other issues I ran into when debugging Blake's problems: * The standalone popup needs a max width of 800px for Chrome compatibility, which is wider than our default max width. * I added a flex attribute to our browser so that it fills the entire space of the slide-in panel. This is only necessary for browsers with content that is shorter than the height of the panel when it gets its desired width, but becomes longer when it doesn't, so it didn't show up in my initial tests. * I also added an extra pixel to the width calculations, since I noticed that a lot of single lines of text were unexpectedly wrapping without it. I'll look into this more in a follow-up bug. I also added some comments, and renamed a couple of variables, where things seemed unclear. The test changes are mostly just updates to older browser action tests to use newer helpers, rather than ad-hoc events, to open/close/click the widgets. A few tests also needed updates to explicitly close the panel when they were done with it. --HG-- extra : commitid : 9OyRnaMTqn8 extra : rebase_source : efd28a49ca5961e2cf545420a81bd19b796d8957 |
||
|---|---|---|
| .. | ||
| app | ||
| base | ||
| branding | ||
| components | ||
| config | ||
| docs | ||
| experiments | ||
| extensions | ||
| fuel | ||
| installer | ||
| locales | ||
| modules | ||
| themes | ||
| .eslintrc | ||
| app-rules.mk | ||
| app.mozbuild | ||
| build.mk | ||
| confvars.sh | ||
| defs.mk | ||
| LICENSE | ||
| Makefile.in | ||
| moz.build | ||