mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-19 16:25:38 +00:00
149e726153
<!-- Please describe your changes on the following line: --> This allows accurate line numbers when reporting stylesheet errors. @jdm This is going to require some effort to merge my changes with other recent changes to `ParserContext`. Because of that I would appreciate a quick sanity check before I put the time into performing the merge. For example, should I store the `offset` as a u64, or should it be an Option? --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #15693 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 94397ff0b4fed138241760770ff2d230985bed8a --HG-- extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear extra : subtree_revision : 3ebb0c3b05f4529ae61351b2c9120f013d1d3339
45 lines
1.6 KiB
Rust
45 lines
1.6 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
//! Types used to report parsing errors.
|
|
|
|
#![deny(missing_docs)]
|
|
|
|
use cssparser::{Parser, SourcePosition};
|
|
use log;
|
|
use stylesheets::UrlExtraData;
|
|
|
|
/// A generic trait for an error reporter.
|
|
pub trait ParseErrorReporter : Sync + Send {
|
|
/// Called when the style engine detects an error.
|
|
///
|
|
/// Returns the current input being parsed, the source position it was
|
|
/// reported from, and a message.
|
|
fn report_error(&self,
|
|
input: &mut Parser,
|
|
position: SourcePosition,
|
|
message: &str,
|
|
url: &UrlExtraData,
|
|
line_number_offset: u64);
|
|
}
|
|
|
|
/// An error reporter that reports the errors to the `info` log channel.
|
|
///
|
|
/// TODO(emilio): The name of this reporter is a lie, and should be renamed!
|
|
pub struct StdoutErrorReporter;
|
|
impl ParseErrorReporter for StdoutErrorReporter {
|
|
fn report_error(&self,
|
|
input: &mut Parser,
|
|
position: SourcePosition,
|
|
message: &str,
|
|
url: &UrlExtraData,
|
|
line_number_offset: u64) {
|
|
if log_enabled!(log::LogLevel::Info) {
|
|
let location = input.source_location(position);
|
|
let line_offset = location.line + line_number_offset as usize;
|
|
info!("Url:\t{}\n{}:{} {}", url.as_str(), line_offset, location.column, message)
|
|
}
|
|
}
|
|
}
|