gecko-dev/gfx/ipc/SharedDIB.cpp
Jed Davis 91efa87e62 Bug 1440199 - Part 2: Remove named mode from IPC shared memory. r=froydnj
We're not using named shared memory, and supporting only anonymous
shared memory allows using other backends that are more compatible
with preventing a process from accessing any shared memory it wasn't
explicitly granted (i.e., sandboxing).

Specifically: SharedMemory::Open is removed; SharedMemory::Create no
longer takes a name, no longer has the open_existing option which doesn't
apply to anonymous memory, and no longer supports read-only memory
(anonymous memory which can never have been written isn't very useful).

This patch also fixes some comments in what remains of SharedMemory::Create.

MozReview-Commit-ID: 4kBrURtxq20

--HG--
extra : rebase_source : f6b1fb2fc79b6e9cdd251b3d9041036c0be503f9
2018-02-20 13:07:32 -07:00

79 lines
1.3 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "SharedDIB.h"
namespace mozilla {
namespace gfx {
SharedDIB::SharedDIB() :
mShMem(nullptr)
{
}
SharedDIB::~SharedDIB()
{
Close();
}
nsresult
SharedDIB::Create(uint32_t aSize)
{
Close();
mShMem = new base::SharedMemory();
if (!mShMem || !mShMem->Create(aSize))
return NS_ERROR_OUT_OF_MEMORY;
return NS_OK;
}
bool
SharedDIB::IsValid()
{
if (!mShMem)
return false;
return base::SharedMemory::IsHandleValid(mShMem->handle());
}
nsresult
SharedDIB::Close()
{
delete mShMem;
mShMem = nullptr;
return NS_OK;
}
nsresult
SharedDIB::Attach(Handle aHandle, uint32_t aSize)
{
Close();
mShMem = new base::SharedMemory(aHandle, false);
if(!mShMem)
return NS_ERROR_OUT_OF_MEMORY;
return NS_OK;
}
nsresult
SharedDIB::ShareToProcess(base::ProcessId aTargetPid, Handle *aNewHandle)
{
if (!mShMem)
return NS_ERROR_UNEXPECTED;
if (!mShMem->ShareToProcess(aTargetPid, aNewHandle))
return NS_ERROR_UNEXPECTED;
return NS_OK;
}
} // namespace gfx
} // namespace mozilla