mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-16 06:45:42 +00:00
dc67bfc9a3
There's an antipattern where nsLiteralString is used as an unnecessary intermediary in converting from CharT* to CharT*,
e.g. CallAFunctionThatTakesACharPointer(NS_LITERAL_CSTRING("foo").get());
or
NS_NAMED_LITERAL_STRING(foo, "abc");
CallAFunctionThatTakesACharPointer(foo.get());
This patch rewrites the callsites that can be trivially changed to use char*/char16_t*.
I'd somewhat like to remove nsTLiteralString::get() altogether, but in code that's less straightforward than these examples, get() is useful enough to keep.
MozReview-Commit-ID: Kh1rUziVllo
--HG--
extra : rebase_source : c21a65694d6e1c42fd88f73632f7ac8f38d005ae
|
||
|---|---|---|
| .. | ||
| gtest | ||
| unit | ||
| windows | ||
| Makefile.in | ||
| moz.build | ||
| NotXPCOMTest.idl | ||
| RegFactory.cpp | ||
| resources.h | ||
| SizeTest01.cpp | ||
| SizeTest02.cpp | ||
| SizeTest03.cpp | ||
| SizeTest04.cpp | ||
| SizeTest05.cpp | ||
| SizeTest06.cpp | ||
| test.properties | ||
| TestArguments.cpp | ||
| TestBlockingProcess.cpp | ||
| TestHarness.h | ||
| TestingAtomList.h | ||
| TestPRIntN.cpp | ||
| TestQuickReturn.cpp | ||
| TestShutdown.cpp | ||
| TestStackCrawl.cpp | ||
| TestStreamUtils.cpp | ||
| TestUnicodeArguments.cpp | ||
| TestWinReg.js | ||