gecko-dev/docshell
Nika Layzell eb598b2ae9 Bug 1563542 - Correctly align usage of mIsDiscarded and mClosed for BrowsingContext, r=peterv
In the bug which introduced mIsDiscarded, the code was changed to not set
mClosed during Detach, and only set mIsDiscarded. This was a mistake because a
bunch of places are only reading mClosed. Specifically when creating a
BrowsingContext for an iframe, we check GetClosed() to see whether to skip
creating it. Not doing this check can lead to assertions like the one in this
bug.

This patch changes the behaviour to continue setting `mClosed`, and also updates
the relevant `GetClosed()` checks to correctly check `IsDiscarded()`

Differential Revision: https://phabricator.services.mozilla.com/D37267

--HG--
extra : moz-landing-system : lando
2019-07-08 17:27:27 +00:00
..
base Bug 1563542 - Correctly align usage of mIsDiscarded and mClosed for BrowsingContext, r=peterv 2019-07-08 17:27:27 +00:00
build Bug 1553498 - Inserts an empty page for about:certviewer and redirects to it when the user put that URL in the browser. r=johannh,smaug 2019-05-23 22:12:30 +00:00
resources/content Bug 1561435 - Format docshell/, a=automatic-formatting 2019-07-05 09:59:46 +02:00
shistory Bug 1557887 - Part 2: Add the nsISHEntry.storagePrincipalToInherit attribute; r=baku 2019-06-12 23:01:56 +00:00
test Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb 2019-07-08 16:37:45 +00:00
moz.build Bug 1529088 - Hold the HTML-based about:config to Nightly until we get Product sign-off. r=florian,paolo 2019-02-27 21:54:57 +00:00