mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-08 02:14:43 +00:00
c2db81c2b7
With clang 12, win32 debug tests run out of stack in the 1000-deep layout crashtests. Usually when this type of thing happens, it's because the compiler made a drastically heavier inlining decision along the recursive part of the stack, with a difference in the hundreds of bytes, and we pay that price of that space 1000 times. In those cases we normally try to snip out the heavy piece with a MOZ_NEVER_INLINE. However, in this case, the difference between old and new compilers was only something like 16 bytes of the cyclical piece. This suggests that we're already up pretty close against the limit, and we're only a bad day away from failing tests even with existing clang. This only happens in debug builds since they have lots of logging helpers on the stack. Release builds are still well under the limit. So I propose to increase the stack limit in debug. While we normally have to be pretty careful about address space on win32, it should be less of a concern with these non-shipping builds. Differential Revision: https://phabricator.services.mozilla.com/D101196
415 lines
12 KiB
Makefile
415 lines
12 KiB
Makefile
#
|
|
# This Source Code Form is subject to the terms of the Mozilla Public
|
|
# License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
|
|
#
|
|
# config.mk
|
|
#
|
|
# Determines the platform and builds the macros needed to load the
|
|
# appropriate platform-specific .mk file, then defines all (most?)
|
|
# of the generic macros.
|
|
#
|
|
|
|
varize = $(subst -,_,$(subst a,A,$(subst b,B,$(subst c,C,$(subst d,D,$(subst e,E,$(subst f,F,$(subst g,G,$(subst h,H,$(subst i,I,$(subst j,J,$(subst k,K,$(subst l,L,$(subst m,M,$(subst n,N,$(subst o,O,$(subst p,P,$(subst q,Q,$(subst r,R,$(subst s,S,$(subst t,T,$(subst u,U,$(subst v,V,$(subst w,W,$(subst x,X,$(subst y,Y,$(subst z,Z,$1)))))))))))))))))))))))))))
|
|
|
|
# Define an include-at-most-once flag
|
|
ifdef INCLUDED_CONFIG_MK
|
|
$(error Do not include config.mk twice!)
|
|
endif
|
|
INCLUDED_CONFIG_MK = 1
|
|
|
|
EXIT_ON_ERROR = set -e; # Shell loops continue past errors without this.
|
|
|
|
ifndef topsrcdir
|
|
topsrcdir = $(DEPTH)
|
|
endif
|
|
|
|
ifndef INCLUDED_AUTOCONF_MK
|
|
include $(DEPTH)/config/autoconf.mk
|
|
endif
|
|
|
|
-include $(DEPTH)/.mozconfig.mk
|
|
|
|
# MDDEPDIR is the subdirectory where dependency files are stored
|
|
MDDEPDIR := .deps
|
|
|
|
ifndef EXTERNALLY_MANAGED_MAKE_FILE
|
|
# Import the automatically generated backend file. If this file doesn't exist,
|
|
# the backend hasn't been properly configured. We want this to be a fatal
|
|
# error, hence not using "-include".
|
|
ifndef STANDALONE_MAKEFILE
|
|
GLOBAL_DEPS += backend.mk
|
|
include backend.mk
|
|
|
|
# Add e.g. `export:: $(EXPORT_TARGETS)` rules. The *_TARGETS variables are defined
|
|
# in backend.mk.
|
|
$(foreach tier,$(RUNNABLE_TIERS),$(eval $(tier):: $($(call varize,$(tier))_TARGETS)))
|
|
endif
|
|
|
|
endif
|
|
|
|
space = $(NULL) $(NULL)
|
|
|
|
# Include defs.mk files that can be found in $(srcdir)/$(DEPTH),
|
|
# $(srcdir)/$(DEPTH-1), $(srcdir)/$(DEPTH-2), etc., and $(srcdir)
|
|
# where $(DEPTH-1) is one level less of depth, $(DEPTH-2), two, etc.
|
|
# i.e. for DEPTH=../../.., DEPTH-1 is ../.. and DEPTH-2 is ..
|
|
# These defs.mk files are used to define variables in a directory
|
|
# and all its subdirectories, recursively.
|
|
__depth := $(subst /, ,$(DEPTH))
|
|
ifeq (.,$(__depth))
|
|
__depth :=
|
|
endif
|
|
$(foreach __d,$(__depth) .,$(eval __depth = $(wordlist 2,$(words $(__depth)),$(__depth))$(eval -include $(subst $(space),/,$(strip $(srcdir) $(__depth) defs.mk)))))
|
|
|
|
COMMA = ,
|
|
|
|
# Sanity check some variables
|
|
CHECK_VARS := \
|
|
XPI_NAME \
|
|
LIBRARY_NAME \
|
|
MODULE \
|
|
DEPTH \
|
|
XPI_PKGNAME \
|
|
INSTALL_EXTENSION_ID \
|
|
SHARED_LIBRARY_NAME \
|
|
SONAME \
|
|
STATIC_LIBRARY_NAME \
|
|
$(NULL)
|
|
|
|
# checks for internal spaces or trailing spaces in the variable
|
|
# named by $x
|
|
check-variable = $(if $(filter-out 0 1,$(words $($(x))z)),$(error Spaces are not allowed in $(x)))
|
|
|
|
$(foreach x,$(CHECK_VARS),$(check-variable))
|
|
|
|
ifndef INCLUDED_FUNCTIONS_MK
|
|
include $(MOZILLA_DIR)/config/makefiles/functions.mk
|
|
endif
|
|
|
|
RM = rm -f
|
|
|
|
# FINAL_TARGET specifies the location into which we copy end-user-shipped
|
|
# build products (typelibs, components, chrome). It may already be specified by
|
|
# a moz.build file.
|
|
#
|
|
# If XPI_NAME is set, the files will be shipped to $(DIST)/xpi-stage/$(XPI_NAME)
|
|
# instead of $(DIST)/bin. In both cases, if DIST_SUBDIR is set, the files will be
|
|
# shipped to a $(DIST_SUBDIR) subdirectory.
|
|
FINAL_TARGET ?= $(if $(XPI_NAME),$(DIST)/xpi-stage/$(XPI_NAME),$(DIST)/bin)$(DIST_SUBDIR:%=/%)
|
|
# Override the stored value for the check to make sure that the variable is not
|
|
# redefined in the Makefile.in value.
|
|
FINAL_TARGET_FROZEN := '$(FINAL_TARGET)'
|
|
|
|
ifdef XPI_NAME
|
|
ACDEFINES += -DXPI_NAME=$(XPI_NAME)
|
|
endif
|
|
|
|
CC := $(CC_WRAPPER) $(CC)
|
|
CXX := $(CXX_WRAPPER) $(CXX)
|
|
MKDIR ?= mkdir
|
|
SLEEP ?= sleep
|
|
TOUCH ?= touch
|
|
|
|
#
|
|
# Build using PIC by default
|
|
#
|
|
_ENABLE_PIC=1
|
|
|
|
# Don't build SIMPLE_PROGRAMS with PGO, since they don't need it anyway,
|
|
# and we don't have the same build logic to re-link them in the second pass.
|
|
ifdef SIMPLE_PROGRAMS
|
|
NO_PROFILE_GUIDED_OPTIMIZE = 1
|
|
endif
|
|
|
|
# No sense in profiling unit tests
|
|
ifdef CPP_UNIT_TESTS
|
|
NO_PROFILE_GUIDED_OPTIMIZE = 1
|
|
endif
|
|
|
|
# Enable profile-based feedback
|
|
ifneq (1,$(NO_PROFILE_GUIDED_OPTIMIZE))
|
|
ifdef MOZ_PROFILE_GENERATE
|
|
PGO_CFLAGS += -DNS_FREE_PERMANENT_DATA=1
|
|
PGO_CFLAGS += $(if $(filter $(notdir $<),$(notdir $(NO_PROFILE_GUIDED_OPTIMIZE))),,$(PROFILE_GEN_CFLAGS))
|
|
PGO_LDFLAGS += $(PROFILE_GEN_LDFLAGS)
|
|
endif # MOZ_PROFILE_GENERATE
|
|
|
|
ifdef MOZ_PROFILE_USE
|
|
PGO_CFLAGS += $(if $(filter $(notdir $<),$(notdir $(NO_PROFILE_GUIDED_OPTIMIZE))),,$(PROFILE_USE_CFLAGS))
|
|
PGO_LDFLAGS += $(PROFILE_USE_LDFLAGS)
|
|
endif # MOZ_PROFILE_USE
|
|
endif # NO_PROFILE_GUIDED_OPTIMIZE
|
|
|
|
# Overloaded by comm builds to refer to $(commtopsrcdir), so that
|
|
# `mail` resolves in en-US builds and in repacks.
|
|
LOCALE_TOPDIR ?= $(topsrcdir)
|
|
MAKE_JARS_FLAGS = \
|
|
-t $(LOCALE_TOPDIR) \
|
|
-f $(MOZ_JAR_MAKER_FILE_FORMAT) \
|
|
$(NULL)
|
|
|
|
ifdef USE_EXTENSION_MANIFEST
|
|
MAKE_JARS_FLAGS += -e
|
|
endif
|
|
|
|
TAR_CREATE_FLAGS = -chf
|
|
|
|
#
|
|
# Default command macros; can be overridden in <arch>.mk.
|
|
#
|
|
CCC = $(CXX)
|
|
|
|
INCLUDES = \
|
|
-I$(srcdir) \
|
|
-I$(CURDIR) \
|
|
$(LOCAL_INCLUDES) \
|
|
-I$(ABS_DIST)/include \
|
|
$(NULL)
|
|
|
|
include $(MOZILLA_DIR)/config/static-checking-config.mk
|
|
|
|
ifndef MOZ_LTO
|
|
MOZ_LTO_CFLAGS :=
|
|
MOZ_LTO_LDFLAGS :=
|
|
endif
|
|
|
|
LDFLAGS = $(MOZ_LTO_LDFLAGS) $(COMPUTED_LDFLAGS) $(PGO_LDFLAGS)
|
|
|
|
COMPILE_CFLAGS = $(MOZ_LTO_CFLAGS) $(COMPUTED_CFLAGS) $(PGO_CFLAGS) $(_DEPEND_CFLAGS) $(MK_COMPILE_DEFINES)
|
|
COMPILE_CXXFLAGS = $(MOZ_LTO_CFLAGS) $(COMPUTED_CXXFLAGS) $(PGO_CFLAGS) $(_DEPEND_CFLAGS) $(MK_COMPILE_DEFINES)
|
|
COMPILE_CMFLAGS = $(MOZ_LTO_CFLAGS) $(OS_COMPILE_CMFLAGS) $(MOZBUILD_CMFLAGS)
|
|
COMPILE_CMMFLAGS = $(MOZ_LTO_CFLAGS) $(OS_COMPILE_CMMFLAGS) $(MOZBUILD_CMMFLAGS)
|
|
ASFLAGS = $(COMPUTED_ASFLAGS)
|
|
SFLAGS = $(COMPUTED_SFLAGS)
|
|
|
|
HOST_CFLAGS = $(COMPUTED_HOST_CFLAGS) $(_HOST_DEPEND_CFLAGS)
|
|
HOST_CXXFLAGS = $(COMPUTED_HOST_CXXFLAGS) $(_HOST_DEPEND_CFLAGS)
|
|
HOST_C_LDFLAGS = $(COMPUTED_HOST_C_LDFLAGS)
|
|
HOST_CXX_LDFLAGS = $(COMPUTED_HOST_CXX_LDFLAGS)
|
|
|
|
WASM_CFLAGS = $(COMPUTED_WASM_CFLAGS) $(_DEPEND_CFLAGS) $(MK_COMPILE_DEFINES)
|
|
WASM_CXXFLAGS = $(COMPUTED_WASM_CXXFLAGS) $(_DEPEND_CFLAGS) $(MK_COMPILE_DEFINES)
|
|
WASM_LDFLAGS = $(COMPUTED_WASM_LDFLAGS)
|
|
|
|
ifdef MOZ_LTO
|
|
ifeq (Darwin,$(OS_TARGET))
|
|
# When linking on macOS, debug info is not linked along with the final binary,
|
|
# and the dwarf data stays in object files until they are "linked" with the
|
|
# dsymutil tool.
|
|
# With LTO, object files are temporary, and are not kept around, which
|
|
# means there's no object file for dsymutil to do its job. Consequently,
|
|
# there is no debug info for LTOed compilation units.
|
|
# The macOS linker has however an option to explicitly keep those object
|
|
# files, which dsymutil will then find.
|
|
# The catch is that the linker uses sequential numbers for those object
|
|
# files, and doesn't avoid conflicts from multiple linkers running at
|
|
# the same time. So in directories with multiple binaries, object files
|
|
# from the first linked binaries would be overwritten by those of the
|
|
# last linked binary. So we use a subdirectory containing the name of the
|
|
# linked binary.
|
|
LDFLAGS += -Wl,-object_path_lto,$(@F).lto.o/
|
|
endif
|
|
endif
|
|
|
|
# We only add color flags if neither the flag to disable color
|
|
# (e.g. "-fno-color-diagnostics" nor a flag to control color
|
|
# (e.g. "-fcolor-diagnostics=never") is present.
|
|
define colorize_flags
|
|
ifeq (,$(filter $(COLOR_CFLAGS:-f%=-fno-%),$$(1))$(findstring $(COLOR_CFLAGS),$$(1)))
|
|
$(1) += $(COLOR_CFLAGS)
|
|
endif
|
|
endef
|
|
|
|
color_flags_vars := \
|
|
COMPILE_CFLAGS \
|
|
COMPILE_CXXFLAGS \
|
|
COMPILE_CMFLAGS \
|
|
COMPILE_CMMFLAGS \
|
|
LDFLAGS \
|
|
WASM_LDFLAGS \
|
|
WASM_CFLAGS \
|
|
WASM_CXXFLAGS \
|
|
$(NULL)
|
|
|
|
ifdef MACH_STDOUT_ISATTY
|
|
ifdef COLOR_CFLAGS
|
|
# TODO Bug 1319166 - iTerm2 interprets some bytes sequences as a
|
|
# request to show a print dialog. Don't enable color on iTerm2 until
|
|
# a workaround is in place.
|
|
ifneq ($(TERM_PROGRAM),iTerm.app)
|
|
$(foreach var,$(color_flags_vars),$(eval $(call colorize_flags,$(var))))
|
|
endif
|
|
endif
|
|
endif
|
|
|
|
#
|
|
# Name of the binary code directories
|
|
#
|
|
# Override defaults
|
|
|
|
DEPENDENCIES = .md
|
|
|
|
ifdef MACOSX_DEPLOYMENT_TARGET
|
|
export MACOSX_DEPLOYMENT_TARGET
|
|
endif # MACOSX_DEPLOYMENT_TARGET
|
|
|
|
# Export to propagate to cl and submake for third-party code.
|
|
# Eventually, we'll want to just use -I.
|
|
ifdef INCLUDE
|
|
export INCLUDE
|
|
endif
|
|
|
|
# Export to propagate to link.exe and submake for third-party code.
|
|
# Eventually, we'll want to just use -LIBPATH.
|
|
ifdef LIB
|
|
export LIB
|
|
endif
|
|
|
|
ifdef MOZ_USING_CCACHE
|
|
ifdef CLANG_CXX
|
|
export CCACHE_CPP2=1
|
|
endif
|
|
endif
|
|
|
|
ifdef CCACHE_PREFIX
|
|
export CCACHE_PREFIX
|
|
endif
|
|
|
|
# Set link flags according to whether we want a console.
|
|
ifeq ($(OS_ARCH),WINNT)
|
|
ifdef MOZ_WINCONSOLE
|
|
ifeq ($(MOZ_WINCONSOLE),1)
|
|
WIN32_EXE_LDFLAGS += $(WIN32_CONSOLE_EXE_LDFLAGS)
|
|
else # MOZ_WINCONSOLE
|
|
WIN32_EXE_LDFLAGS += $(WIN32_GUI_EXE_LDFLAGS)
|
|
endif
|
|
else
|
|
# For setting subsystem version
|
|
WIN32_EXE_LDFLAGS += $(WIN32_CONSOLE_EXE_LDFLAGS)
|
|
endif
|
|
endif # WINNT
|
|
|
|
ifeq ($(OS_ARCH),WINNT)
|
|
ifneq (,$(filter msvc clang-cl,$(CC_TYPE)))
|
|
ifneq ($(CPU_ARCH),x86)
|
|
# Normal operation on 64-bit Windows needs 2 MB of stack. (Bug 582910)
|
|
# ASAN requires 6 MB of stack.
|
|
# Setting the stack to 8 MB to match the capability of other systems
|
|
# to deal with frame construction for unreasonably deep DOM trees
|
|
# with worst-case styling. This uses address space unnecessarily for
|
|
# non-main threads, but that should be tolerable on 64-bit systems.
|
|
# (Bug 256180)
|
|
WIN32_EXE_LDFLAGS += -STACK:8388608
|
|
else
|
|
# Since this setting affects the default stack size for non-main
|
|
# threads, too, to avoid burning the address space, increase only
|
|
# 512 KB over the default. Just enough to be able to deal with
|
|
# reasonable styling applied to DOM trees whose depth is near what
|
|
# Blink's HTML parser can output, esp.
|
|
# layout/base/crashtests/507119.html (Bug 256180)
|
|
ifndef MOZ_DEBUG
|
|
WIN32_EXE_LDFLAGS += -STACK:1572864
|
|
else
|
|
# In debug builds, layout code has extra logging helpers on the stack,
|
|
# which can go over the 1.5MB limit on some deeply-nested crashtests.
|
|
WIN32_EXE_LDFLAGS += -STACK:2097152
|
|
endif
|
|
endif
|
|
else
|
|
ifneq ($(CPU_ARCH),x86)
|
|
MOZ_PROGRAM_LDFLAGS += -Wl,-Xlink=-STACK:8388608
|
|
else
|
|
MOZ_PROGRAM_LDFLAGS += -Wl,-Xlink=-STACK:1572864
|
|
endif
|
|
endif
|
|
endif
|
|
|
|
-include $(topsrcdir)/$(MOZ_BUILD_APP)/app-config.mk
|
|
|
|
######################################################################
|
|
|
|
ifeq ($(OS_ARCH),Darwin)
|
|
ifndef NSDISTMODE
|
|
NSDISTMODE=absolute_symlink
|
|
endif
|
|
PWD := $(CURDIR)
|
|
endif
|
|
|
|
NSINSTALL_PY := $(PYTHON3) $(abspath $(MOZILLA_DIR)/config/nsinstall.py)
|
|
ifneq (,$(or $(filter WINNT,$(HOST_OS_ARCH)),$(if $(COMPILE_ENVIRONMENT),,1)))
|
|
NSINSTALL = $(NSINSTALL_PY)
|
|
else
|
|
NSINSTALL = $(DEPTH)/config/nsinstall$(HOST_BIN_SUFFIX)
|
|
endif # WINNT
|
|
|
|
|
|
ifeq (,$(CROSS_COMPILE)$(filter-out WINNT, $(OS_ARCH)))
|
|
INSTALL = $(NSINSTALL) -t
|
|
|
|
else
|
|
|
|
# This isn't laid out as conditional directives so that NSDISTMODE can be
|
|
# target-specific.
|
|
INSTALL = $(if $(filter absolute_symlink, $(NSDISTMODE)), $(NSINSTALL) -L $(PWD), $(NSINSTALL) -R)
|
|
|
|
endif # WINNT
|
|
|
|
# The default for install_cmd is simply INSTALL
|
|
install_cmd ?= $(INSTALL) $(1)
|
|
|
|
# Use nsinstall in copy mode to install files on the system
|
|
SYSINSTALL = $(NSINSTALL) -t
|
|
# This isn't necessarily true, just here
|
|
sysinstall_cmd = install_cmd
|
|
|
|
#
|
|
# Localization build automation
|
|
#
|
|
|
|
# Because you might wish to "make locales AB_CD=ab-CD", we don't hardcode
|
|
# MOZ_UI_LOCALE directly, but use an intermediate variable that can be
|
|
# overridden by the command line. (Besides, AB_CD is prettier).
|
|
AB_CD = $(MOZ_UI_LOCALE)
|
|
|
|
include $(MOZILLA_DIR)/config/AB_rCD.mk
|
|
|
|
# Many locales directories want this definition.
|
|
ACDEFINES += -DAB_CD=$(AB_CD)
|
|
|
|
EXPAND_LOCALE_SRCDIR = $(if $(filter en-US,$(AB_CD)),$(LOCALE_TOPDIR)/$(1)/en-US,$(REAL_LOCALE_MERGEDIR)/$(subst /locales,,$(1)))
|
|
|
|
ifdef relativesrcdir
|
|
LOCALE_RELATIVEDIR ?= $(relativesrcdir)
|
|
endif
|
|
|
|
ifdef LOCALE_RELATIVEDIR
|
|
LOCALE_SRCDIR ?= $(call EXPAND_LOCALE_SRCDIR,$(LOCALE_RELATIVEDIR))
|
|
endif
|
|
|
|
ifdef relativesrcdir
|
|
MAKE_JARS_FLAGS += --relativesrcdir=$(LOCALE_RELATIVEDIR)
|
|
ifneq (en-US,$(AB_CD))
|
|
ifdef IS_LANGUAGE_REPACK
|
|
MAKE_JARS_FLAGS += --l10n-base=$(REAL_LOCALE_MERGEDIR)
|
|
endif
|
|
else
|
|
MAKE_JARS_FLAGS += -c $(LOCALE_SRCDIR)
|
|
endif # en-US
|
|
else
|
|
MAKE_JARS_FLAGS += -c $(LOCALE_SRCDIR)
|
|
endif # ! relativesrcdir
|
|
|
|
MERGE_FILE = $(LOCALE_SRCDIR)/$(1)
|
|
MERGE_RELATIVE_FILE = $(call EXPAND_LOCALE_SRCDIR,$(2))/$(1)
|
|
|
|
ifneq (WINNT,$(OS_ARCH))
|
|
RUN_TEST_PROGRAM = $(DIST)/bin/run-mozilla.sh
|
|
endif # ! WINNT
|
|
|
|
# Enable verbose logs when not using `make -s`
|
|
ifeq (,$(findstring s, $(filter-out --%, $(MAKEFLAGS))))
|
|
export BUILD_VERBOSE_LOG = 1
|
|
endif
|