gecko-dev/toolkit
Eric Chen 4bced98a4c Bug 1922010 Change WindowsLaunchOnLogin functions that interacts with registry keys to be private r=settings-reviewers,mossop
This patch includes 4 main changes

1. Created a guard in `removeLaunchOnLogin` with `getLaunchOnLoginApproved` to make sure the setting is not already disabled before removing the registry key made by Firefox.

2. Change the method doc for `removeLaunchOnLogin` to better describe why we need to guard the function and provide necessary context.

3. Prefixed the functions called within `removeLaunchOnLogin` with "_", to signify that they should not be used as a public API. We should only call those functions after we've checked the return value of `getLaunchOnLoginApproved`.

4. Modified existing unit test, and added a new unit test to make sure `removeLaunchOnLogin` is non-op when Windows has disabled such feature.

Differential Revision: https://phabricator.services.mozilla.com/D227399
2024-11-12 14:51:10 +00:00
..
actors Bug 1929377 - Add warning to about:neterror on OSX to check Local Network permissions r=necko-reviewers,fluent-reviewers,frontend-codestyle-reviewers,kershaw,flod 2024-11-12 10:56:21 +00:00
components Bug 1929531 - Change the ESLint mozilla/reject-addtask-only rule to highlight only the .only() section. r=frontend-codestyle-reviewers,mossop 2024-11-12 14:32:33 +00:00
content Bug 1929377 - Add warning to about:neterror on OSX to check Local Network permissions r=necko-reviewers,fluent-reviewers,frontend-codestyle-reviewers,kershaw,flod 2024-11-12 10:56:21 +00:00
crashreporter Bug 1923782 - Include minidump-analyzer library on android r=glandium,geckoview-reviewers,owlish,gsvelto 2024-10-30 16:54:27 +00:00
docs
library Bug 1921713 - Skip MSVCRT when generating dependentlibs.list. r=firefox-build-system-reviewers,ahochheiden 2024-10-29 20:36:09 +00:00
locales Bug 1929377 - Add warning to about:neterror on OSX to check Local Network permissions r=necko-reviewers,fluent-reviewers,frontend-codestyle-reviewers,kershaw,flod 2024-11-12 10:56:21 +00:00
locales-preview Bug 1879933 - Add a button to change the translation direction in about:translations. r=translations-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,nordzilla,dao 2024-09-05 18:24:08 +00:00
modules Bug 1922010 Change WindowsLaunchOnLogin functions that interacts with registry keys to be private r=settings-reviewers,mossop 2024-11-12 14:51:10 +00:00
mozapps Bug 1930518 - Log result when signedState is SIGNEDSTATE_UNKNOWN r=rpl 2024-11-11 18:54:59 +00:00
profile Bug 1894239: Enable MOZ_SELECTABLE_PROFILES by default. r=jhirsch,omc-reviewers,niklas,emcminn,mconley 2024-11-05 12:59:04 +00:00
system Bug 1920718 - Annotate all global variable with runtime initialization attributes r=glandium,application-update-reviewers,media-playback-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,gfx-reviewers,aosmond,lina,nalexander,aabh,geckoview-reviewers,win-reviewers,gstoll,m_kato 2024-10-30 11:05:24 +00:00
themes Bug 1851327 - Respect font settings in Reader mode r=reader-mode-reviewers,desktop-theme-reviewers,Gijs,emilio 2024-11-12 14:20:13 +00:00
xre Bug 1925425: Only consider -allow-content-analysis command line flag in nightly and local builds r=haik,dlp-reviewers,gstoll 2024-11-06 23:32:08 +00:00
.eslintrc.js
jsconfig.json
l10n-registry.manifest
moz.build
moz.configure Bug 1915191 - Provide a minimal linter for configure help r=glandium,geckoview-reviewers,owlish 2024-11-07 10:43:43 +00:00
toolkit.mozbuild Bug 1920521 - Remove jprof from m-c r=jesup,zeid 2024-10-01 14:13:43 +00:00