gecko-dev/image
Emilio Cobos Álvarez e076e40ab1 Bug 1610165 - Failing to insert an SVG into the surface cache continuously repaints the image. r=tnikkel
I was poking at the missing images bug by dropping cache sizes and such and
found that we always ended up repainting some SVGs over and over. This seems to
be the cause. When we fail to insert into the cache we still end up notifying
over and over (because we forget to say aWillCache=false), so we'd end up
repainting, and failing again, etc.

This is easy to see adding some logging to
nsDisplayBackgroundImage::PaintInternal.

Any ideas as to how to add a test for it?

Differential Revision: https://phabricator.services.mozilla.com/D60372

--HG--
extra : moz-landing-system : lando
2020-01-19 23:02:52 +00:00
..
build Bug 1550422 - P23. Remove now unused gfxPrefs. r=jrmuizel 2019-05-26 14:31:53 +00:00
decoders Bug 1552176 - Add nsIRequest.set/getTRRMode r=dragana 2020-01-07 20:20:38 +00:00
encoders Bug 1552317 - Fix codespell errors for image/. r=tnikkel 2019-09-12 09:00:52 +00:00
test Bug 1608582 - tighten reftest annotation, part 1 r=jmaher 2020-01-11 12:32:27 +00:00
AnimationFrameBuffer.cpp
AnimationFrameBuffer.h
AnimationParams.h Bug 1530774 - Part 3. Remove decoder support for producing paletted frames. r=tnikkel 2019-03-18 07:30:34 -04:00
AnimationSurfaceProvider.cpp Bug 1570499 - Part 1: Replace MOZ_FALLTHROUGH macro with C++17's [[fallthrough]] attribute. r=froydnj 2019-12-20 07:16:43 +00:00
AnimationSurfaceProvider.h
BMPHeaders.h
ClippedImage.cpp Bug 1594425 - Part 2. Switch image decoders to use SurfaceFormat::OS_RGBA. r=tnikkel 2019-11-12 18:22:33 +00:00
ClippedImage.h Bug 1547792 - AspectRatio should be a single ratio, not a size. r=dholbert 2019-05-02 23:28:21 +00:00
CopyOnWrite.h
DecodedSurfaceProvider.cpp Bug 1563139 - Remove StaticPrefs.h. r=glandium 2019-07-26 01:10:23 +00:00
DecodedSurfaceProvider.h
DecodePool.cpp Bug 1602710 - Do not shut down threads not found in the image decode thread pool. r=tnikkel 2020-01-06 23:40:08 +00:00
DecodePool.h
Decoder.cpp Bug 1255106 - Part 1. Move color transform state to image decoder base class. r=tnikkel 2019-05-28 11:38:46 -04:00
Decoder.h Bug 1255106 - Part 1. Move color transform state to image decoder base class. r=tnikkel 2019-05-28 11:38:46 -04:00
DecoderFactory.cpp Bug 1561491 - Make image.* static prefs follow the naming convention. r=KrisWright 2019-06-26 13:24:21 +10:00
DecoderFactory.h
DecoderFlags.h Bug 1530774 - Part 3. Remove decoder support for producing paletted frames. r=tnikkel 2019-03-18 07:30:34 -04:00
Downscaler.cpp Bug 1550422 - P23. Remove now unused gfxPrefs. r=jrmuizel 2019-05-26 14:31:53 +00:00
Downscaler.h
DownscalingFilter.h Bug 1594425 - Part 2. Switch image decoders to use SurfaceFormat::OS_RGBA. r=tnikkel 2019-11-12 18:22:33 +00:00
DynamicImage.cpp Bug 1594425 - Part 2. Switch image decoders to use SurfaceFormat::OS_RGBA. r=tnikkel 2019-11-12 18:22:33 +00:00
DynamicImage.h
FrameAnimator.cpp Bug 1563139 - Remove StaticPrefs.h. r=glandium 2019-07-26 01:10:23 +00:00
FrameAnimator.h Bug 1563139 - Remove StaticPrefs.h. r=glandium 2019-07-26 01:10:23 +00:00
FrameTimeout.h
FrozenImage.cpp Bug 1550523 - Ensure that decoding methods for frozen images request the correct frame. r=tnikkel 2019-05-22 06:22:50 -04:00
FrozenImage.h Bug 1550523 - Ensure that decoding methods for frozen images request the correct frame. r=tnikkel 2019-05-22 06:22:50 -04:00
ICOFileHeaders.h
IDecodingTask.cpp Bug 1550422 - P23. Remove now unused gfxPrefs. r=jrmuizel 2019-05-26 14:31:53 +00:00
IDecodingTask.h
Image.cpp Bug 1558915 - Use infallible nsIURI::SchemeIs in image/ r=tnikkel 2019-08-03 09:44:12 +00:00
Image.h Bug 1552317 - Fix codespell errors for image/. r=tnikkel 2019-09-12 09:00:52 +00:00
ImageCacheKey.cpp Bug 1600545 - Remove useless inclusions of header files generated from IDL files in accessible/, browser/, caps/, chrome/, devtools/, docshell/, editor/, extensions/, gfx/, hal/, image/, intl/, ipc/, js/, layout/, and media/ r=Ehsan 2019-12-06 09:16:44 +00:00
ImageCacheKey.h Bug 1558915 - Use infallible nsIURI::SchemeIs in image/ r=tnikkel 2019-08-03 09:44:12 +00:00
ImageFactory.cpp Bug 1600545 - Remove useless inclusions of header files generated from IDL files in accessible/, browser/, caps/, chrome/, devtools/, docshell/, editor/, extensions/, gfx/, hal/, image/, intl/, ipc/, js/, layout/, and media/ r=Ehsan 2019-12-06 09:16:44 +00:00
ImageFactory.h
ImageLogging.h
ImageMemoryReporter.cpp Bug 1563139 - Remove StaticPrefs.h. r=glandium 2019-07-26 01:10:23 +00:00
ImageMemoryReporter.h Bug 1552317 - Fix codespell errors for image/. r=tnikkel 2019-09-12 09:00:52 +00:00
ImageMetadata.h
ImageOps.cpp Bug 1545567 - Ensure ImageOps decode methods can handle unbuffered input streams properly. r=baku 2019-04-26 11:58:24 -04:00
ImageOps.h
ImageRegion.h
ImageWrapper.cpp Bug 1550523 - Ensure that decoding methods for frozen images request the correct frame. r=tnikkel 2019-05-22 06:22:50 -04:00
ImageWrapper.h
ImgDrawResult.h
imgFrame.cpp Bug 1604535 - Avoid copying image surfaces when used with OMTP. r=tnikkel 2019-12-25 21:27:46 +00:00
imgFrame.h Bug 1600545 - Remove useless inclusions of header files generated from IDL files in accessible/, browser/, caps/, chrome/, devtools/, docshell/, editor/, extensions/, gfx/, hal/, image/, intl/, ipc/, js/, layout/, and media/ r=Ehsan 2019-12-06 09:16:44 +00:00
imgICache.idl
imgIContainer.idl Bug 1598480 - Make SVG images respond to theme changes. r=tnikkel,emilio 2019-12-13 02:04:07 +00:00
imgIContainerDebug.idl
imgIEncoder.idl
imgILoader.idl Bug 1552317 - Fix codespell errors for image/. r=tnikkel 2019-09-12 09:00:52 +00:00
imgINotificationObserver.idl
imgIRequest.idl Bug 1554847 - Improve cross-origin checks in canvas API - imgIRequest.hadCrossOriginRedirects, r=aosmond 2019-06-04 06:31:42 +00:00
imgIScriptedNotificationObserver.idl
imgITools.idl Bug 1530402 - Provide imgTools.decodeFromChannelAsync. r=aosmond,snorp 2019-11-18 16:48:53 +00:00
imgLoader.cpp Bug 1600545 - Remove useless inclusions of header files generated from IDL files in accessible/, browser/, caps/, chrome/, devtools/, docshell/, editor/, extensions/, gfx/, hal/, image/, intl/, ipc/, js/, layout/, and media/ r=Ehsan 2019-12-06 09:16:44 +00:00
imgLoader.h Bug 1580820. Update the inner window id as well as the context (document) pointer on an imgRequest if we validate it for that document/inner window id. r=aosmond 2019-09-17 13:16:19 +00:00
imgRequest.cpp Bug 1558915 - Use infallible nsIURI::SchemeIs everywhere. r=smaug 2019-08-09 15:17:06 +00:00
imgRequest.h Bug 1580820. Update the inner window id as well as the context (document) pointer on an imgRequest if we validate it for that document/inner window id. r=aosmond 2019-09-17 13:16:19 +00:00
imgRequestProxy.cpp Bug 1552176 - Add nsIRequest.set/getTRRMode r=dragana 2020-01-07 20:20:38 +00:00
imgRequestProxy.h Bug 1552317 - Fix codespell errors for image/. r=tnikkel 2019-09-12 09:00:52 +00:00
imgTools.cpp Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 2020-01-09 21:50:11 +00:00
imgTools.h
IProgressObserver.h
ISurfaceProvider.h
LookupResult.h Bug 1543584 - Always rasterize SVGs but clamp the maximum size. r=tnikkel 2019-04-18 14:35:58 -04:00
moz.build Bug 1530190. De-unify image/DecodePool.cpp on Windows. r=aosmond 2019-04-22 17:30:40 -05:00
MultipartImage.cpp
MultipartImage.h
nsIIconURI.idl
Orientation.h
OrientedImage.cpp Bug 1594425 - Part 2. Switch image decoders to use SurfaceFormat::OS_RGBA. r=tnikkel 2019-11-12 18:22:33 +00:00
OrientedImage.h Bug 1547792 - AspectRatio should be a single ratio, not a size. r=dholbert 2019-05-02 23:28:21 +00:00
PlaybackType.h
ProgressTracker.cpp Bug 1600545 - Remove useless inclusions of header files generated from IDL files in accessible/, browser/, caps/, chrome/, devtools/, docshell/, editor/, extensions/, gfx/, hal/, image/, intl/, ipc/, js/, layout/, and media/ r=Ehsan 2019-12-06 09:16:44 +00:00
ProgressTracker.h Bug 1552317 - Fix codespell errors for image/. r=tnikkel 2019-09-12 09:00:52 +00:00
RasterImage.cpp Bug 1552317 - Fix codespell errors for image/. r=tnikkel 2019-09-12 09:00:52 +00:00
RasterImage.h Bug 1600545 - Remove useless inclusions of header files generated from IDL files in accessible/, browser/, caps/, chrome/, devtools/, docshell/, editor/, extensions/, gfx/, hal/, image/, intl/, ipc/, js/, layout/, and media/ r=Ehsan 2019-12-06 09:16:44 +00:00
RecyclingSourceSurface.h
ScriptedNotificationObserver.cpp
ScriptedNotificationObserver.h
ShutdownTracker.cpp Bug 1523969 part 10 - Move method definition inline comments to new line in 'image/'. r=aosmond 2019-02-25 16:07:58 -06:00
ShutdownTracker.h
SourceBuffer.cpp Bug 1523969 part 10 - Move method definition inline comments to new line in 'image/'. r=aosmond 2019-02-25 16:07:58 -06:00
SourceBuffer.h
StreamingLexer.h
SurfaceCache.cpp Bug 1284651. Allow the image surface cache to grow beyond 1GB on 64bit builds with sufficient memory. r=aosmond 2019-09-10 00:55:13 +00:00
SurfaceCache.h Bug 1543584 - Always rasterize SVGs but clamp the maximum size. r=tnikkel 2019-04-18 14:35:58 -04:00
SurfaceCacheUtils.cpp Bug 1523969 part 10 - Move method definition inline comments to new line in 'image/'. r=aosmond 2019-02-25 16:07:58 -06:00
SurfaceCacheUtils.h
SurfaceFilters.h Bug 1551088 - Part 6. Make image decoders use accelerated methods for swizzling and premultiplication. r=tnikkel 2019-10-02 13:37:29 +00:00
SurfaceFlags.h
SurfacePipe.cpp Bug 1551088 - Part 5. Expose SurfaceFilter input row directly to avoid copy if possible. r=tnikkel 2019-10-02 13:37:28 +00:00
SurfacePipe.h Bug 1551088 - Part 5. Expose SurfaceFilter input row directly to avoid copy if possible. r=tnikkel 2019-10-02 13:37:28 +00:00
SurfacePipeFactory.h Bug 1594425 - Part 2. Switch image decoders to use SurfaceFormat::OS_RGBA. r=tnikkel 2019-11-12 18:22:33 +00:00
SVGDocumentWrapper.cpp Bug 1523638 - Part 9: Use provided 'WindowGlobalChild' actors to create the initial about:blank document, r=kmag 2019-08-08 16:07:12 +00:00
SVGDocumentWrapper.h Bug 1544215 - Make nsIContentVewer::GetPresShell() return mozilla::PresShell instead of nsIPresShell r=bzbarsky 2019-04-16 02:47:26 +00:00
SVGDrawingParameters.h
VectorImage.cpp Bug 1610165 - Failing to insert an SVG into the surface cache continuously repaints the image. r=tnikkel 2020-01-19 23:02:52 +00:00
VectorImage.h Bug 1598480 - Make SVG images respond to theme changes. r=tnikkel,emilio 2019-12-13 02:04:07 +00:00