mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-13 05:15:45 +00:00
bbd3ba0a18
Currently there are 3 things that can impact the result of a lint run: 1. The list of lint issues found 2. The set of failures that happened during the setup phase 3. The set of failures that happened during the execution phase All three of these things are stored as instance variables on the LintRoller object, and then passed into a formatter when it comes time to print the results. I'd like to add even more things that can impact the result, and it became clear that the current scenario does not scale well. This patch moves all data that could impact the end result of a lint run off of the LintRoller object and onto a new 'result.ResultSummary' class. To avoid confusion, this patch also renames the 'result.ResultContainer' class to 'result.Issue'. With this new nomenclature: result -> overall state of an entire lint run (can comprise multiple linters) issue -> one specific lint infraction (at either 'warning' or 'error' level) failure -> a non-recoverable error in the linter implementation itself A "result" is comprised of 0 or more "issues" and 0 or more "failures". Differential Revision: https://phabricator.services.mozilla.com/D3819 --HG-- extra : moz-landing-system : lando |
||
|---|---|---|
| .. | ||
| mozlint | ||
| test | ||
| setup.py | ||