mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-17 23:35:34 +00:00
57887f2601
Currently manifestparser will only look for line continuations *after* looking for a key. This means
that line continuations cannot contain key separators. For example, this:
[test]
foo=
bar=baz
gets treated as:
{'name': 'test', 'foo': '', 'bar': 'baz'}
Here, bar=baz will be treated as a new key/value pair despite the indentation. This patch switches
the order around, so we look for a continuation first. Now, it is only treated as a continuation if
the indent is greater than the indent of the preceding key.
So this manifest:
[test]
foo=bar
baz=fleem
is a continuation and results in:
{'name': 'test', 'foo': 'bar\nbaz=fleem'}
But this manifest:
[test]
foo=bar
baz=fleem
is not a continuation, and yields:
{'name': 'test', 'foo': 'bar', 'baz': 'fleem'}
MozReview-Commit-ID: FAMP5TUIo9q
--HG--
extra : rebase_source : 624c53cfe0565374c1224dd86a3fffc8831279d3
|
||
|---|---|---|
| .. | ||
| include | ||
| parent | ||
| verifyDirectory | ||
| comment-example.ini | ||
| default-skipif.ini | ||
| default-suppfiles.ini | ||
| filter-example.ini | ||
| fleem | ||
| include-example.ini | ||
| include-invalid.ini | ||
| just-defaults.ini | ||
| manifest.ini | ||
| missing-path.ini | ||
| mozmill-example.ini | ||
| mozmill-restart-example.ini | ||
| no-tests.ini | ||
| path-example.ini | ||
| relative-path.ini | ||
| subsuite.ini | ||
| test_chunking.py | ||
| test_convert_directory.py | ||
| test_convert_symlinks.py | ||
| test_default_overrides.py | ||
| test_expressionparser.py | ||
| test_filters.py | ||
| test_manifestparser.py | ||
| test_read_ini.py | ||
| test_testmanifest.py | ||