mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-19 16:25:38 +00:00
487e463bb5
It removes a script blocker. Therefore, although it depends on the caller whether it causes running script or not. However, we should mark it as `MOZ_CAN_RUN_SCRIPT` for safer code. It's called only by the destructor of `nsAutoCauseReflowNotifier`. Therefore, this patch also marks its constructor as `MOZ_CAN_RUN_SCRIPT` for making each creator method marked as `MOZ_CAN_RUN_SCRIPT` or `MOZ_CAN_RUN_SCRIPT_BOUNDARY`. Most of the creators is mutation listener methods. However, `PresShell` does nothing after destroying `nsAutoCauseReflowNotifier`. Therefore, this patch does not change the callers in MutationObserver.cpp to use `RefPtr<PresShell>` at calling them because changing it may cause performance regression. Perhaps, we should create another methods of `WillCauseReflow()` and `DidCauseReflow()` to avoid unnecessary `MOZ_CAN_RUN_SCRIPT` marking. However, I'm not sure whether most callers may run script or not because of outside of my knowledge. Differential Revision: https://phabricator.services.mozilla.com/D55805 --HG-- extra : moz-landing-system : lando
117 lines
3.3 KiB
C++
117 lines
3.3 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "DOMSVGPoint.h"
|
|
|
|
#include "DOMSVGPointList.h"
|
|
#include "gfx2DGlue.h"
|
|
#include "mozAutoDocUpdate.h"
|
|
#include "nsCOMPtr.h"
|
|
#include "nsError.h"
|
|
#include "SVGPoint.h"
|
|
#include "mozilla/dom/SVGElement.h"
|
|
#include "mozilla/dom/SVGMatrix.h"
|
|
|
|
// See the architecture comment in DOMSVGPointList.h.
|
|
|
|
using namespace mozilla::gfx;
|
|
|
|
namespace mozilla {
|
|
namespace dom {
|
|
|
|
//----------------------------------------------------------------------
|
|
// Helper class: AutoChangePointNotifier
|
|
// Stack-based helper class to pair calls to WillChangePointList and
|
|
// DidChangePointList.
|
|
class MOZ_RAII AutoChangePointNotifier : public mozAutoDocUpdate {
|
|
public:
|
|
explicit AutoChangePointNotifier(
|
|
DOMSVGPoint* aPoint MOZ_GUARD_OBJECT_NOTIFIER_PARAM)
|
|
: mozAutoDocUpdate(aPoint->Element()->GetComposedDoc(), true),
|
|
mPoint(aPoint) {
|
|
MOZ_GUARD_OBJECT_NOTIFIER_INIT;
|
|
MOZ_ASSERT(mPoint, "Expecting non-null point");
|
|
MOZ_ASSERT(mPoint->HasOwner(),
|
|
"Expecting list to have an owner for notification");
|
|
mEmptyOrOldValue = mPoint->Element()->WillChangePointList(*this);
|
|
}
|
|
|
|
~AutoChangePointNotifier() {
|
|
mPoint->Element()->DidChangePointList(mEmptyOrOldValue, *this);
|
|
// Null check mPoint->mList, since DidChangePointList can run script,
|
|
// potentially removing mPoint from its list.
|
|
if (mPoint->mList && mPoint->mList->AttrIsAnimating()) {
|
|
mPoint->Element()->AnimationNeedsResample();
|
|
}
|
|
}
|
|
|
|
private:
|
|
DOMSVGPoint* const mPoint;
|
|
nsAttrValue mEmptyOrOldValue;
|
|
MOZ_DECL_USE_GUARD_OBJECT_NOTIFIER
|
|
};
|
|
|
|
float DOMSVGPoint::X() {
|
|
if (mIsAnimValItem && HasOwner()) {
|
|
Element()->FlushAnimations(); // May make HasOwner() == false
|
|
}
|
|
return HasOwner() ? InternalItem().mX : mPt.mX;
|
|
}
|
|
|
|
void DOMSVGPoint::SetX(float aX, ErrorResult& rv) {
|
|
if (mIsAnimValItem || mIsReadonly) {
|
|
rv.Throw(NS_ERROR_DOM_NO_MODIFICATION_ALLOWED_ERR);
|
|
return;
|
|
}
|
|
|
|
if (HasOwner()) {
|
|
if (InternalItem().mX == aX) {
|
|
return;
|
|
}
|
|
AutoChangePointNotifier notifier(this);
|
|
InternalItem().mX = aX;
|
|
return;
|
|
}
|
|
mPt.mX = aX;
|
|
}
|
|
|
|
float DOMSVGPoint::Y() {
|
|
if (mIsAnimValItem && HasOwner()) {
|
|
Element()->FlushAnimations(); // May make HasOwner() == false
|
|
}
|
|
return HasOwner() ? InternalItem().mY : mPt.mY;
|
|
}
|
|
|
|
void DOMSVGPoint::SetY(float aY, ErrorResult& rv) {
|
|
if (mIsAnimValItem || mIsReadonly) {
|
|
rv.Throw(NS_ERROR_DOM_NO_MODIFICATION_ALLOWED_ERR);
|
|
return;
|
|
}
|
|
|
|
if (HasOwner()) {
|
|
if (InternalItem().mY == aY) {
|
|
return;
|
|
}
|
|
AutoChangePointNotifier notifier(this);
|
|
InternalItem().mY = aY;
|
|
return;
|
|
}
|
|
mPt.mY = aY;
|
|
}
|
|
|
|
already_AddRefed<nsISVGPoint> DOMSVGPoint::MatrixTransform(
|
|
dom::SVGMatrix& matrix) {
|
|
float x = HasOwner() ? InternalItem().mX : mPt.mX;
|
|
float y = HasOwner() ? InternalItem().mY : mPt.mY;
|
|
|
|
Point pt = ToMatrix(matrix.GetMatrix()).TransformPoint(Point(x, y));
|
|
nsCOMPtr<nsISVGPoint> newPoint = new DOMSVGPoint(pt);
|
|
return newPoint.forget();
|
|
}
|
|
|
|
} // namespace dom
|
|
} // namespace mozilla
|