mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-08 20:47:44 +00:00
175115e709
These scriptable interfaces use uint_64 arguments with sentinel values of UINT64_MAX. However, UINT64_MAX exceeds MAX_SAFE_INTEGER and cannot be gatewayed to/from javascript - so they cannot be used correctly. Change them to use signed 64 bit numbers and -1 as the sentinnel. C++ implementations ought to be enough to audit as the special value could never be used correctly in JS anyhow - also audited OnProgressChange() uses for downstream use of this data. --- dom/base/nsXMLHttpRequest.cpp | 19 +++++++---- dom/base/nsXMLHttpRequest.h | 10 +++--- dom/plugins/base/nsPluginStreamListenerPeer.cpp | 4 +-- .../webbrowserpersist/nsWebBrowserPersist.cpp | 14 ++++---- image/src/imgLoader.cpp | 4 +-- modules/libjar/nsJARChannel.cpp | 3 +- netwerk/base/public/nsIProgressEventSink.idl | 8 ++--- netwerk/base/public/nsITransport.idl | 8 ++--- netwerk/base/public/nsNetUtil.h | 24 ++++++++++++++ netwerk/base/src/Dashboard.cpp | 2 +- netwerk/base/src/nsBaseChannel.cpp | 12 +++---- netwerk/base/src/nsIncrementalDownload.cpp | 4 +-- netwerk/base/src/nsSocketTransport2.cpp | 5 +-- netwerk/base/src/nsStreamTransportService.cpp | 38 +++++++++++++--------- netwerk/base/src/nsTransportUtils.cpp | 12 +++---- netwerk/protocol/file/nsFileChannel.cpp | 8 +++-- netwerk/protocol/ftp/nsFtpConnectionThread.cpp | 4 +-- netwerk/protocol/http/Http2Push.cpp | 2 +- netwerk/protocol/http/Http2Session.cpp | 2 +- netwerk/protocol/http/HttpChannelChild.cpp | 31 +++++++++--------- netwerk/protocol/http/HttpChannelChild.h | 6 ++-- netwerk/protocol/http/HttpChannelParent.cpp | 4 +-- netwerk/protocol/http/HttpChannelParent.h | 4 +-- netwerk/protocol/http/NullHttpTransaction.cpp | 2 +- netwerk/protocol/http/PHttpChannel.ipdl | 2 +- netwerk/protocol/http/SpdyPush31.cpp | 2 +- netwerk/protocol/http/SpdySession31.cpp | 2 +- netwerk/protocol/http/TunnelUtils.cpp | 2 +- netwerk/protocol/http/nsAHttpTransaction.h | 4 +-- netwerk/protocol/http/nsHttpChannel.cpp | 30 +++++++++++------ netwerk/protocol/http/nsHttpConnection.cpp | 4 +-- netwerk/protocol/http/nsHttpConnectionMgr.cpp | 4 +-- netwerk/protocol/http/nsHttpPipeline.cpp | 4 +-- netwerk/protocol/http/nsHttpPipeline.h | 6 ++-- netwerk/protocol/http/nsHttpResponseHead.cpp | 2 +- netwerk/protocol/http/nsHttpResponseHead.h | 2 +- netwerk/protocol/http/nsHttpTransaction.cpp | 32 +++++++++--------- netwerk/protocol/http/nsHttpTransaction.h | 2 +- netwerk/protocol/wyciwyg/WyciwygChannelChild.cpp | 2 +- netwerk/protocol/wyciwyg/nsWyciwygChannel.cpp | 3 +- netwerk/test/TestIncrementalDownload.cpp | 7 ++-- uriloader/base/nsDocLoader.cpp | 14 ++++---- 42 files changed, 203 insertions(+), 151 deletions(-) |
||
|---|---|---|
| .. | ||
| browser | ||
| crashtests | ||
| httpserver | ||
| mochitests | ||
| reftest | ||
| unit | ||
| unit_ipc | ||
| moz.build | ||
| PropertiesTest.cpp | ||
| ReadNTLM.cpp | ||
| sites.txt | ||
| TestBind.cpp | ||
| TestBlockingSocket.cpp | ||
| TestCacheBlockFiles.cpp | ||
| TestCachePrefixKeyParser.cpp | ||
| TestCallbacks.cpp | ||
| TestCommon.h | ||
| TestCookie.cpp | ||
| TestDNS.cpp | ||
| TestDNSDaemon.cpp | ||
| TestFileInput2.cpp | ||
| TestHttp.cpp | ||
| TestIDN.cpp | ||
| TestIncrementalDownload.cpp | ||
| TestIOThreads.cpp | ||
| TestMakeAbs.cpp | ||
| TestOpen.cpp | ||
| TestOverlappedIO.cpp | ||
| TestProtocols.cpp | ||
| TestRes.cpp | ||
| TestServ.cpp | ||
| TestServ.js | ||
| TestSocketInput.cpp | ||
| TestSocketIO.cpp | ||
| TestSocketTransport.cpp | ||
| TestStandardURL.cpp | ||
| TestStreamChannel.cpp | ||
| TestStreamLoader.cpp | ||
| TestStreamPump.cpp | ||
| TestStreamTransport.cpp | ||
| TestSTSParser.cpp | ||
| TestUDPSocket.cpp | ||
| TestUDPSocketProvider.cpp | ||
| TestUpload.cpp | ||
| TestURLManipulation.html | ||
| TestURLParser.cpp | ||
| TestWriteSpeed.cpp | ||
| urlparse_mac.dat | ||
| urlparse_unx.dat | ||
| urlparse_win.dat | ||
| urlparse.dat | ||
| urltest.cpp | ||
| urltests.dat | ||