gecko-dev

mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-27 12:50:09 +00:00

History

Tim Taubert 0294a21add Bug 1413841 - Check for integer overflow in AesTask::DoCrypto() r=keeler

Summary:
After calling mResult.SetLength(mData.Length() + 16) we should check that the
integer addition didn't overflow. It seems at the moment impossible to create
ArrayBuffers of size >= 0x0xfffffff0, however adding a check here doesn't hurt.

mResult.Length() is passed to the PK11 API functions as a maxOut parameter and
/should/ be checked by the softoken crypto algorithm implementations. AES-ECB
and AES-GCM seem to do that correctly.

Reviewers: keeler

Reviewed By: keeler

Subscribers: mcote, ttaubert, jcj, keeler

Bug #: 1413841

Differential Revision: https://phabricator.services.mozilla.com/D188

2017-11-28 10:00:47 +01:00

test

Bug 1368859 - Test that the Web Crypto API rejects 0-length AES-GCM IVs r=keeler

2017-06-21 12:48:04 +02:00

CryptoBuffer.cpp

Bug 1401803 - WebAuthn types need to return ArrayBuffers r=keeler

2017-09-20 07:32:07 -07:00

CryptoBuffer.h

Bug 1401803 - WebAuthn types need to return ArrayBuffers r=keeler

2017-09-20 07:32:07 -07:00

CryptoKey.cpp

Bug 1329238 - Make public CryptoKey.h methods return UniqueX NSS types instead of raw pointers. r=ttaubert