mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-03-01 22:07:41 +00:00
bf49dba88f
This is in response to an issue that's affecting the new app update doorhangers on OSX, where the problem is more obvious. On OSX, the panel styling makes it so that the doorhanger overflows the window a little bit. This is fine until you enter fullscreen with ctrl+command+F. At this point, the doorhanger should come back onto the screen and the arrow should be rooted to its anchor element (in our case the hamburger menu icon), but instead it lags and the panel is not adjusted right away. This is because right after the window is resized, which ends up calling SetPopupPosition with aIsMove == false, SetPopupPosition is called again from CheckForAnchorChange with aIsMove set to true. There could be other solutions to this particular problem, but since the aIsMove boolean is intended to limit the visual noise when moving a window between screens, it seemed appropriate for it to only prevent sliding or flipping if the panel isn't already slid or flipped. There was another issue affecting specifically the arrow, where the logic for notifying observers of a positioning change in the panel doesn't account for changes only to the position of the anchor rect. This change adds tracking of that and sets aNotify to true when called from ReflowFinished, since this is where the position of the anchor element relative to the window can need to change, even when the screen position of the panel rect doesn't change. MozReview-Commit-ID: Lpfokwkgl33 --HG-- extra : rebase_source : b05adc0b3f876196ff45499f0d70533f78cafb0e
An explanation of the Mozilla Source Code Directory Structure and links to
project pages with documentation can be found at:
https://developer.mozilla.org/en/Mozilla_Source_Code_Directory_Structure
For information on how to build Mozilla from the source code, see:
https://developer.mozilla.org/en/docs/Build_Documentation
To have your bug fix / feature added to Mozilla, you should create a patch and
submit it to Bugzilla (https://bugzilla.mozilla.org). Instructions are at:
https://developer.mozilla.org/en/docs/Creating_a_patch
https://developer.mozilla.org/en/docs/Getting_your_patch_in_the_tree
If you have a question about developing Mozilla, and can't find the solution
on https://developer.mozilla.org, you can try asking your question in a
mozilla.* Usenet group, or on IRC at irc.mozilla.org. [The Mozilla news groups
are accessible on Google Groups, or news.mozilla.org with a NNTP reader.]
You can download nightly development builds from the Mozilla FTP server.
Keep in mind that nightly builds, which are used by Mozilla developers for
testing, may be buggy. Firefox nightlies, for example, can be found at:
https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/
- or -
https://nightly.mozilla.org/