Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-28 15:23:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
c1143c12ba
gecko-dev/editor/libeditor
History
Magnus Melin 53d4e1215b Bug 1649005 - fix crash when rewrapping an empty message via mozilla::HTMLEditor::InsertTextWithQuotationsInternal. r=masayuki 
If empty input, aStringToInsert.First() will crash at https://searchfox.org/mozilla-central/rev/c2e3ac11be4837718c2604e58085fbc8252b69dd/xpcom/string/nsTSubstring.cpp#968

Needed to adjust whether rewrap needs beforeinput handling:
NeedsBeforeInputEventHandling would return false, because rewrap was set not to need that
https://searchfox.org/mozilla-central/rev/803b368879fa332e8e2c1840bf1ec164f7ed2c32/editor/libeditor/EditorBase.h#1152
.. so EditorBase::AutoEditActionDataSetter::MaybeDispatchBeforeInputEvent would assert

rewrap also needs to be allowed for MayEditActionDeleteSelection (not to assert)

Differential Revision: https://phabricator.services.mozilla.com/D93167
2020-10-14 12:55:00 +00:00
..
crashtests Bug 1664109 - Fix != operator of EditorDOMRangeBase r=m_kato 2020-09-16 02:17:33 +00:00
tests Bug 1649005 - fix crash when rewrapping an empty message via mozilla::HTMLEditor::InsertTextWithQuotationsInternal. r=masayuki 2020-10-14 12:55:00 +00:00
ChangeAttributeTransaction.cpp Bug 1650145 - Replace all value uses of Empty[C]String by 0-length _ns literals. r=froydnj,geckoview-reviewers,agi 2020-09-23 15:17:15 +00:00
ChangeAttributeTransaction.h
ChangeStyleTransaction.cpp Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj 2020-07-01 08:29:29 +00:00
ChangeStyleTransaction.h
CompositionTransaction.cpp Bug 1623413 - Part 2: Rename Collapse() to CollapseInLimiter() r=masayuki 2020-09-03 03:45:26 +00:00
CompositionTransaction.h Bug 1653011 - Simplify and make WeakPtr<Derived> usable and compact. r=froydnj,sg,geckoview-reviewers,jgilbert,kvark,snorp 2020-07-23 14:51:46 +00:00
CreateElementTransaction.cpp Bug 1623413 - Part 2: Rename Collapse() to CollapseInLimiter() r=masayuki 2020-09-03 03:45:26 +00:00
CreateElementTransaction.h
CSSEditUtils.cpp Bug 1650145 - Replace all value uses of Empty[C]String by 0-length _ns literals. r=froydnj,geckoview-reviewers,agi 2020-09-23 15:17:15 +00:00
CSSEditUtils.h Bug 1665258 - Shrink CSSEquivTable. r=heycam 2020-09-23 01:08:21 +00:00
DeleteNodeTransaction.cpp Bug 1644903 - Make nsINode::InsertBefore() callers call ErrorResult::WouldReportJSException() when inserting node may be in another document r=m_kato 2020-07-01 13:13:13 +00:00
DeleteNodeTransaction.h
DeleteRangeTransaction.cpp Bug 1623413 - Part 2: Rename Collapse() to CollapseInLimiter() r=masayuki 2020-09-03 03:45:26 +00:00
DeleteRangeTransaction.h
DeleteTextTransaction.cpp Bug 1623413 - Part 2: Rename Collapse() to CollapseInLimiter() r=masayuki 2020-09-03 03:45:26 +00:00
DeleteTextTransaction.h
EditAction.h Bug 1649005 - fix crash when rewrapping an empty message via mozilla::HTMLEditor::InsertTextWithQuotationsInternal. r=masayuki 2020-10-14 12:55:00 +00:00
EditActionListener.h
EditAggregateTransaction.cpp
EditAggregateTransaction.h
EditorBase.cpp Bug 1668134 - part 3: Add telemetry probes to collect how percentage of HTMLEditor is or is not handled with beforeinput event listeners r=smaug data-review=tdsmith 2020-10-09 23:54:19 +00:00
EditorBase.h Bug 1649005 - fix crash when rewrapping an empty message via mozilla::HTMLEditor::InsertTextWithQuotationsInternal. r=masayuki 2020-10-14 12:55:00 +00:00
EditorCommands.cpp Bug 1650145 - Replace all value uses of Empty[C]String by 0-length _ns literals. r=froydnj,geckoview-reviewers,agi 2020-09-23 15:17:15 +00:00
EditorCommands.h
EditorController.cpp
EditorController.h
EditorDOMPoint.h Bug 1664109 - Fix != operator of EditorDOMRangeBase r=m_kato 2020-09-16 02:17:33 +00:00
EditorEventListener.cpp Bug 1623918 - part 2: Mark nsINode::GetSelectionRootContent() and its root callers as MOZ_CAN_RUN_SCRIPT as far as possible r=smaug 2020-10-09 02:37:47 +00:00
EditorEventListener.h Bug 1623918 - part 2: Mark nsINode::GetSelectionRootContent() and its root callers as MOZ_CAN_RUN_SCRIPT as far as possible r=smaug 2020-10-09 02:37:47 +00:00
EditorUtils.cpp Bug 1665850 - Remove specifics for reference error types from mozilla::Result. r=emilio,jandem 2020-09-21 13:14:28 +00:00
EditorUtils.h Bug 1658702 - part 8: Add AutoDeleteRangesHandler::ComputeRangesToDeleteAtomicContent() to compute atomic content deleting target range r=m_kato 2020-09-07 04:59:22 +00:00
EditTransactionBase.cpp
EditTransactionBase.h
HTMLAbsPositionEditor.cpp Bug 1650145 - Replace all value uses of Empty[C]String by 0-length _ns literals. r=froydnj,geckoview-reviewers,agi 2020-09-23 15:17:15 +00:00
HTMLAnonymousNodeEditor.cpp Bug 1663638 - Don't use edit transaction for editing UI. r=masayuki 2020-09-14 05:10:08 +00:00
HTMLEditor.cpp Bug 1668134 - part 3: Add telemetry probes to collect how percentage of HTMLEditor is or is not handled with beforeinput event listeners r=smaug data-review=tdsmith 2020-10-09 23:54:19 +00:00
HTMLEditor.h Bug 1668134 - part 3: Add telemetry probes to collect how percentage of HTMLEditor is or is not handled with beforeinput event listeners r=smaug data-review=tdsmith 2020-10-09 23:54:19 +00:00
HTMLEditorCommands.cpp Bug 1650145 - Replace all value uses of Empty[C]String by 0-length _ns literals. r=froydnj,geckoview-reviewers,agi 2020-09-23 15:17:15 +00:00
HTMLEditorController.cpp
HTMLEditorController.h
HTMLEditorDataTransfer.cpp Bug 1649005 - fix crash when rewrapping an empty message via mozilla::HTMLEditor::InsertTextWithQuotationsInternal. r=masayuki 2020-10-14 12:55:00 +00:00
HTMLEditorDocumentCommands.cpp Bug 1623918 - part 2: Mark nsINode::GetSelectionRootContent() and its root callers as MOZ_CAN_RUN_SCRIPT as far as possible r=smaug 2020-10-09 02:37:47 +00:00
HTMLEditorEventListener.cpp Bug 1623413 - Part 2: Rename Collapse() to CollapseInLimiter() r=masayuki 2020-09-03 03:45:26 +00:00
HTMLEditorEventListener.h Bug 1632425 - Part 3: Triple click to select anchors r=masayuki 2020-06-03 23:47:55 +00:00
HTMLEditorObjectResizer.cpp Bug 1650145 - Replace all value uses of Empty[C]String by 0-length _ns literals. r=froydnj,geckoview-reviewers,agi 2020-09-23 15:17:15 +00:00
HTMLEditSubActionHandler.cpp Bug 1668134 - part 1: Make nsPIDOMWindowInner have an API to know whether the window or its descendants has had beforeinput event listeners r=smaug 2020-10-08 02:25:35 +00:00
HTMLEditUtils.cpp Bug 1649121: part 95) Update ElementInfo's documentation. r=m_kato 2020-09-24 17:10:48 +00:00
HTMLEditUtils.h Bug 1658702 - part 2: Make AutoDeleteRangesHandler::ComputeRangesToDelete() handle the case deleting empty ancestor(s) r=m_kato 2020-09-01 02:02:50 +00:00
HTMLInlineTableEditor.cpp Bug 1663638 - Don't use edit transaction for editing UI. r=masayuki 2020-09-14 05:10:08 +00:00
HTMLStyleEditor.cpp Bug 1650145 - Replace all value uses of Empty[C]String by 0-length _ns literals. r=froydnj,geckoview-reviewers,agi 2020-09-23 15:17:15 +00:00
HTMLTableEditor.cpp Bug 1659276 - Make AutoPlaceholderBatch choose whether do or do not ScrollSelectionIntoView r=m_kato 2020-08-24 06:39:50 +00:00
InsertNodeTransaction.cpp Bug 1623413 - Part 2: Rename Collapse() to CollapseInLimiter() r=masayuki 2020-09-03 03:45:26 +00:00
InsertNodeTransaction.h
InsertTextTransaction.cpp Bug 1623413 - Part 2: Rename Collapse() to CollapseInLimiter() r=masayuki 2020-09-03 03:45:26 +00:00
InsertTextTransaction.h
InternetCiter.cpp Bug 1642594 - part 4: Stop using "whitespace" in under libeditor r=m_kato 2020-06-10 13:44:10 +00:00
InternetCiter.h
JoinNodeTransaction.cpp Bug 1644903 - Make nsINode::InsertBefore() callers call ErrorResult::WouldReportJSException() when inserting node may be in another document r=m_kato 2020-07-01 13:13:13 +00:00
JoinNodeTransaction.h
ManualNAC.h
moz.build
PlaceholderTransaction.cpp
PlaceholderTransaction.h Bug 1653011 - Simplify and make WeakPtr<Derived> usable and compact. r=froydnj,sg,geckoview-reviewers,jgilbert,kvark,snorp 2020-07-23 14:51:46 +00:00
ReplaceTextTransaction.cpp Bug 1623413 - Part 2: Rename Collapse() to CollapseInLimiter() r=masayuki 2020-09-03 03:45:26 +00:00
ReplaceTextTransaction.h
SelectionState.cpp
SelectionState.h Bug 1656799 - part 2: Create range tracker r=m_kato 2020-08-08 02:57:16 +00:00
SplitNodeTransaction.cpp Bug 1623413 - Part 2: Rename Collapse() to CollapseInLimiter() r=masayuki 2020-09-03 03:45:26 +00:00
SplitNodeTransaction.h
TextEditor.cpp Bug 1664411 - Factor out a condition to unconditionally enable clipboard events in some documents. r=masayuki 2020-09-11 11:08:35 +00:00
TextEditor.h Bug 1649121: part 90) Declare some editor methods const or static. r=m_kato 2020-09-22 16:03:55 +00:00
TextEditorDataTransfer.cpp Bug 1649121: part 90) Declare some editor methods const or static. r=m_kato 2020-09-22 16:03:55 +00:00
TextEditSubActionHandler.cpp Bug 1623413 - Part 2: Rename Collapse() to CollapseInLimiter() r=masayuki 2020-09-03 03:45:26 +00:00
TypeInState.cpp Bug 1650145 - Replace all value uses of Empty[C]String by 0-length _ns literals. r=froydnj,geckoview-reviewers,agi 2020-09-23 15:17:15 +00:00
TypeInState.h
WSRunObject.cpp Bug 1668134 - part 1: Make nsPIDOMWindowInner have an API to know whether the window or its descendants has had beforeinput event listeners r=smaug 2020-10-08 02:25:35 +00:00
WSRunObject.h Bug 1658702 - part 22: Get rid of wrong MOZ_ASSERTs in WSRunScanner::GetRangeExtendToContainInvisibleWhiteSpacesAtRangeBoundaries() r=m_kato 2020-09-27 06:02:38 +00:00