mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-12-04 02:57:38 +00:00
034a395cfb
#selectedElement may end up pointing to disconnected nodes. And so the public .selectedElement getter. This is how it was happening: a first call to onQueryResults adds and selects a heuristic result. Then a second call to onQueryResults brings a new heuristic result that requires new content (not compatible with the previous one), so the old heuristic is emptied out, and new DOM is generated. Because the code in onQueryResults relies on .selectedElement, at the second invokation it thinks the selection is still valid, and doesn't select the new heuristic. In reality .selectedElement at that time is pointing to a removed DOM node. The patch introduces a #rawSelectedElement and converts #selectedElement into a getter. Plus some minor logging improvements, and removing unused #mainContainer property. Differential Revision: https://phabricator.services.mozilla.com/D195779 |
||
|---|---|---|
| .. | ||
| actors | ||
| app | ||
| base | ||
| branding | ||
| components | ||
| config | ||
| docs | ||
| extensions | ||
| fonts | ||
| fxr | ||
| installer | ||
| locales | ||
| locales-preview | ||
| modules | ||
| themes | ||
| tools/mozscreenshots | ||
| .eslintrc.js | ||
| app.mozbuild | ||
| build.mk | ||
| confvars.sh | ||
| defs.mk | ||
| l10n-registry.manifest | ||
| LICENSE | ||
| Makefile.in | ||
| moz.build | ||
| moz.configure | ||