mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-02-22 18:32:00 +00:00
0b1b86082e
We don't follow this bit intentionally because we know that even if it's set,
when none of the other two bits are set there are no other restyle / change
hints down the tree.
We rely on the frame constructor to clean the mess up, though, and it doesn't
really do a good work about it.
In particular, the case we're hitting on the test-case is:
<body descendant-need-frames change=reconstruct style="display: table-column-group">
<div descendant-need-frames>
<div descendant-need-frames>
<span needs-frame></span>
</div>
</div>
</body>
When we see we need to reconstruct the body, we call
ClearRestyleStateFromSubtree, but that doesn't do much now, since we don't
follow the descendant-need-frames bits.
Then, when we reconstruct the content, we arrive at[1] when constructing the
first child <div>. The <div> flags have been cleared, but not the children's!
Then a text-node is inserted in a <div>, breaking all sorts of invariants.
This is the easiest fix. Other fixes include clearing the flags on
SetAsUndisplayedContent. But that implies not clearing them in
ShouldCreateItemsForChild, and doing that somewhere more sensible.
I suspect it's not too hard, but that's a slightly more risky change, will do it
if you prefer it.
[1]: http://searchfox.org/mozilla-central/rev/3dbb47302e114219c53e99ebaf50c5cb727358ab/layout/base/nsCSSFrameConstructor.cpp#6092
MozReview-Commit-ID: 7026wkQLQkz
25 lines
673 B
HTML
25 lines
673 B
HTML
<html class="reftest-wait">
|
|
<script>
|
|
window.onload = () => {
|
|
a = document.createElement("body")
|
|
b = document.createElement("span")
|
|
a.appendChild(b)
|
|
c = document.createElement("div")
|
|
d = document.createElement("div")
|
|
c.appendChild(d)
|
|
a.appendChild(c)
|
|
document.documentElement.appendChild(a)
|
|
requestIdleCallback(() => {
|
|
a.style.display = "table-column-group"
|
|
d.appendChild(document.createTextNode("\u05D2"))
|
|
requestIdleCallback(() => {
|
|
d.appendChild(document.createElement("span"))
|
|
b.style.zIndex = "1073741824"
|
|
document.documentElement.offsetTop;
|
|
document.documentElement.className = "";
|
|
})
|
|
})
|
|
}
|
|
</script>
|
|
</html>
|