gecko-dev/layout/reftests
Timothy Nikkel a57976fc90 Bug 1714763. When computing the local scale use the local transform and the parent scale rather than the local transform and parent transform. r=jrmuizel
When the scale of the parent transform is increasing the parent scale will be much larger than the scale of the parent transform.

The bug in the testcase happens because there are two nested transforms. The outer is animating in scale between 0 and 1. So the choosen mScale for the parent is 1 and the scale of the transform at any instantaneous point is usually smaller, say 0.2. The inner transform is just a flip and is not animated. We combine that parent transform with our local flip transform and get a transform with a scale of 0.2 and use that as our mScale. However this ignores the animating aspect of the parent transform and the fact we choose an mScale of 1 for the parent.

To fix this we bring how we use ChooseScale with webrender more into alignment with how we used ChooseScale with non-wr/FrameLayerBuilder.

https://searchfox.org/mozilla-esr91/rev/f3f439e007bdd4b5b1c2ba05ca706b68563413b2/layout/painting/FrameLayerBuilder.cpp#6047

The old code was structured a little differently which obscured this difference. The old code had ChooseScale (the code shared by webrender and FrameLayerBuilder) and a wrapper function ChooseScaleAndSetTransform which only FrameLayerBuilder used. The old code passed the local transform to ChooseScaleAndSetTransform, and then ChooseScaleAndSetTransform combined it with the parent scale and then passed that transform to ChooseScale. Whereas webrender passed the combined transform to ChooseScale. This would produce the same results except if the scale was animating.

This mimics how we compute the scale in HasAnimationsForCompositor branch above, where we compute a scale for the local transform and then combine that with the parent scale.

See also bug 1569215 where we first started passing the parent scale into ChooseScale so that the HasAnimationsForCompositor would choose the correct scale.

Differential Revision: https://phabricator.services.mozilla.com/D178996
2023-06-08 10:20:07 +00:00
..
abs-pos Bug 1392106 - remove obsolete reftest win7 conditions. r=aryx 2022-05-19 12:27:29 +00:00
apng-mime
async-scrolling Bug 1828571 - Update some perma tier 2 reftest fuzziness r=gfx-reviewers,lsalzman 2023-04-18 20:40:28 +00:00
backgrounds Bug 1834079 - Move stroke fallback heuristic to after we attempt AA-Stroke. r=jrmuizel 2023-05-20 02:30:12 +00:00
bidi Bug 1108425 - Fix dir=auto for textarea with rtl text. r=smaug 2023-05-22 12:35:01 +00:00
border-dotted Bug 1821512 - Update fuzz for Skia update. r=jrmuizel 2023-04-16 15:34:50 +00:00
border-image Bug 1821512 - Update fuzz for Skia update. r=jrmuizel 2023-04-16 15:34:50 +00:00
border-radius Bug 1823578 - Add new clip-mask rendering path r=gfx-reviewers,ahale 2023-04-17 04:04:17 +00:00
box-properties
box-shadow Bug 1821512 - Update fuzz for Skia update. r=jrmuizel 2023-04-16 15:34:50 +00:00
box-sizing
bugs Bug 1714763. When computing the local scale use the local transform and the parent scale rather than the local transform and parent transform. r=jrmuizel 2023-06-08 10:20:07 +00:00
canvas Bug 1818820. Fix drawing of some blend modes with non-complex clips. r=bas 2023-03-03 11:54:49 +00:00
color-scheme Bug 1764354 - Propagate color-scheme preference to SVG images on chrome documents. r=aosmond 2022-04-17 20:38:01 +00:00
columns
conditional
counter-style
counters Bug 1392106 - remove obsolete reftest win7 conditions. r=aryx 2022-05-19 12:27:29 +00:00
css-animations Bug 1807685 - Rename scroll-linked (animations) to scroll-driven (excluding WPT tests). r=dholbert 2023-01-04 00:50:45 +00:00
css-blending Bug 1787089 - Fix interactions between root level mix-blend containers and backdrop-filter r=gfx-reviewers,lsalzman 2022-08-29 00:30:24 +00:00
css-break Bug 1392106 - remove obsolete reftest win7 conditions. r=aryx 2022-05-19 12:27:29 +00:00
css-calc Bug 1392106 - remove obsolete reftest win7 conditions. r=aryx 2022-05-19 12:27:29 +00:00
css-charset
css-default
css-disabled
css-display
css-enabled
css-gradients Bug 1821512 - Update fuzz for Skia update. r=jrmuizel 2023-04-16 15:34:50 +00:00
css-grid Bug 1807963 - Remove non-standard values of caption-side for good. r=TYLin,layout-reviewers 2023-01-09 18:02:23 +00:00
css-import
css-invalid Bug 1795887 - Fix IsValueMissing update for certain input types. r=edgar 2022-10-22 16:34:48 +00:00
css-mediaqueries Bug 1834382 - Remove overflow-block optional-paged r=emilio 2023-05-22 20:44:09 +00:00
css-optional
css-page Bug 1828020 - Remove the layout.css.named-pages.enabled pref r=emilio 2023-05-16 20:32:11 +00:00
css-parsing
css-placeholder Bug 1809742 - Remove nativeThemePref annotations. r=dshin 2023-01-13 21:18:08 +00:00
css-required
css-ruby Bug 1825394 - Backed out changeset fcc38c48c35a (bug 1824531) due to tscrollx regressions. r=layout-reviewers,emilio,tnikkel 2023-04-03 10:11:04 +00:00
css-scroll-snap
css-scrollbars Bug 1748181 - Provide a pref to make scrollbar-width: thin behave as auto. r=morgan 2022-02-07 18:14:31 +00:00
css-selectors
css-shapes
css-sizing
css-transitions
css-ui
css-ui-invalid Bug 1809742 - Remove nativeThemePref annotations. r=dshin 2023-01-13 21:18:08 +00:00
css-ui-valid Bug 1795887 - Fix IsValueMissing update for certain input types. r=edgar 2022-10-22 16:34:48 +00:00
css-valid Bug 1795887 - Fix IsValueMissing update for certain input types. r=edgar 2022-10-22 16:34:48 +00:00
css-valuesandunits Bug 1809742 - Remove nativeThemePref annotations. r=dshin 2023-01-13 21:18:08 +00:00
css-variables
css-visited
cssom
datalist
details-summary Bug 1308080 - Make <details> use a shadow tree as per spec. r=TYLin,smaug 2022-09-16 14:54:12 +00:00
display-list Bug 1677568. Handle a rare case of a placeholder and its out of flow frame not being in the same continuation of it's containing block frame in retained display list code. r=mstange 2023-04-12 10:52:05 +00:00
dom
first-letter Bug 290125 - Adjust first-letter reftests to be robust against change to floating-firstletter metrics. r=emilio 2022-12-20 07:55:24 +00:00
first-line Bug 1769842 - remove old osx annotations in reftest. r=aryx 2022-05-18 18:57:11 +00:00
flexbox Bug 1809742 - Remove nativeThemePref annotations. r=dshin 2023-01-13 21:18:08 +00:00
floats Bug 1809742 - Remove nativeThemePref annotations. r=dshin 2023-01-13 21:18:08 +00:00
font-face Bug 1825394 - Backed out changeset fcc38c48c35a (bug 1824531) due to tscrollx regressions. r=layout-reviewers,emilio,tnikkel 2023-04-03 10:11:04 +00:00
font-features Bug 1392106 - remove obsolete reftest win7 conditions. r=aryx 2022-05-19 12:27:29 +00:00
font-inflation Bug 1725028 - Use reftest-zoom rather than tweaking devPixelsPerPx in this reftest. r=hiro 2023-02-08 14:39:17 +00:00
font-loading-api
font-matching Bug 1794298 - Add a reftest for Twemoji Mozilla keycap on Windows. r=emilio 2023-02-01 13:25:39 +00:00
font-variations Bug 1392106 - remove obsolete reftest win7 conditions. r=aryx 2022-05-19 12:27:29 +00:00
fonts Bug 1802290 - Remove +x permissions on more files r=linter-reviewers,andi 2023-01-03 08:17:50 +00:00
forms Backed out 2 changesets (bug 1774315) for causing bc failures in browser_test_position_sticky.js CLOSED TREE 2023-04-25 22:24:22 -04:00
frameset
generated-content Bug 1769842 - remove old osx annotations in reftest. r=aryx 2022-05-18 18:57:11 +00:00
high-contrast Bug 1818227 - Prevent drawing backplate when forced-color-adjust is none r=emilio 2023-03-24 16:48:35 +00:00
ib-split Bug 1631441 - Remove no longer relevant tests with XBL bindings. r=emilio DONTBUILD 2022-11-23 13:41:15 +00:00
image Bug 1655598 - Cross origin image request should not respect image orientation. r=emilio 2022-09-28 03:56:57 +00:00
image-element Bug 1828363. Allow decreased fuzz in image-element/gradient-html-06a/b.html r=gfx-reviewers,lsalzman 2023-04-17 02:19:31 +00:00
image-rect
indic-shaping
inline
inline-borderpadding
invalidation Bug 1822131 - Allow XUL elements to shrink-by-default. r=dholbert 2023-03-14 12:22:11 +00:00
layers Bug 1801824 - Enable accelerated canvas on Android nightly r=lsalzman,gfx-reviewers,jmaher 2023-01-17 02:30:01 +00:00
line-breaking Bug 1392106 - remove obsolete reftest win7 conditions. r=aryx 2022-05-19 12:27:29 +00:00
list-item
margin-collapsing Bug 1809742 - Remove nativeThemePref annotations. r=dshin 2023-01-13 21:18:08 +00:00
marquee
mathml Bug 1808757 - [refactor] Migrate defines to constexpr vars r=emilio 2023-01-09 09:03:42 +00:00
meta-viewport Bug 1803740 - Apply the minimum-scale for desktop mode. r=botond 2023-06-06 02:08:41 +00:00
mp4-video
native-theme Bug 1833403 - Simplify some appearance code. r=stransky,mac-reviewers,handyman,devtools-reviewers,mstange 2023-05-24 11:13:58 +00:00
object Bug 1392106 - remove obsolete reftest win7 conditions. r=aryx 2022-05-19 12:27:29 +00:00
ogg-video
outline Bug 1809742 - Remove nativeThemePref annotations. r=dshin 2023-01-13 21:18:08 +00:00
pagination Bug 1835951 - Tweak fuzz factors for swgl+win+asan. 2023-05-31 09:48:43 +00:00
percent-overflow-sizing
pixel-rounding
position-dynamic-changes
position-relative
position-sticky Bug 1392106 - remove obsolete reftest win7 conditions. r=aryx 2022-05-19 12:27:29 +00:00
printing
reftest-sanity Bug 1814047 - Add support for testing print-background options on reftests. r=jfkthame 2023-02-01 09:33:54 +00:00
scrolling Bug 1809742 - Remove nativeThemePref annotations. r=dshin 2023-01-13 21:18:08 +00:00
selection Bug 1832275 - Fix up focused selection when focus returns to something else. r=masayuki 2023-05-28 22:07:29 +00:00
stylesheet-cloning
svg Bug 1832902. Bump fuzz on svg/pattern-transformed-02.svg. r=firefox-svg-reviewers,longsonr 2023-05-12 21:18:19 +00:00
tab-size
table-anonymous-boxes Bug 1799580 - Remove display: -moz-popup. r=TYLin 2022-11-09 20:38:04 +00:00
table-background
table-bordercollapse Bug 1392106 - remove obsolete reftest win7 conditions. r=aryx 2022-05-19 12:27:29 +00:00
table-dom
table-html Bug 1392106 - remove obsolete reftest win7 conditions. r=aryx 2022-05-19 12:27:29 +00:00
table-overflow
table-width
text Bug 1253840 - patch 3 - Update test expectations. r=dholbert 2023-05-21 13:17:42 +00:00
text-decoration Bug 1793340 - Remove failure annotation for test that now seems to be passing on Win7. r=emilio 2022-10-04 08:21:26 +00:00
text-indent
text-overflow Bug 1809742 - Remove nativeThemePref annotations. r=dshin 2023-01-13 21:18:08 +00:00
text-shadow Bug 1749380 - Part 1 - Improve how WR handles bounding rects for off-screen surfaces r=gfx-reviewers 2022-02-23 20:49:26 +00:00
text-stroke Bug 1789612 - Backed out changeset 105858693e9a for causing tsvgx regression. r=gfx-reviewers,jgilbert 2022-09-19 09:40:23 +00:00
text-svgglyphs Bug 1825394 - Backed out changeset fcc38c48c35a (bug 1824531) due to tscrollx regressions. r=layout-reviewers,emilio,tnikkel 2023-04-03 10:11:04 +00:00
text-transform Bug 1697980 - Implement new uppercase mapping of eszett (U+00DF) to U+1E9E, but preffed-off by default due to inconsistent font support. r=emilio 2023-04-18 07:06:09 +00:00
transform Bug 1834079 - Move stroke fallback heuristic to after we attempt AA-Stroke. r=jrmuizel 2023-05-20 02:30:12 +00:00
transform-3d Bug 1821512 - Update fuzz for Skia update. r=jrmuizel 2023-04-16 15:34:50 +00:00
unicode
usercss
view-source
web-animations
webcomponents Bug 1798207 - Use shadow-including tree order to sort selection ranges. r=smaug 2022-11-11 12:21:25 +00:00
webkit-box Bug 1392106 - remove obsolete reftest win7 conditions. r=aryx 2022-05-19 12:27:29 +00:00
webkit-gradient
webm-video
writing-mode Bug 1817295 - Remove Thunderbird-specific rules from HTML user-agent stylesheet. r=dshin 2023-02-17 14:22:44 +00:00
xul Bug 1833403 - Simplify some appearance code. r=stransky,mac-reviewers,handyman,devtools-reviewers,mstange 2023-05-24 11:13:58 +00:00
xul-document-load
z-index
filters.svg
moz.build Bug 1774376 - update file-to-Bugzilla-component mappings for Graphics team r=perftest-reviewers,gfx-reviewers,sparky,aosmond,nical 2022-06-30 18:07:29 +00:00
reftest-qr.list
reftest.list Bug 1824957 - Remove a bunch of now completely dead XUL layout code. r=layout-reviewers,desktop-theme-reviewers,devtools-reviewers,dao,TYLin 2023-03-29 21:23:55 +00:00