Luca Greco 052fc46425 Bug 1727405 - Add a diagnostic assert to check that ClientManager::GetOrCreateForCurrentThread is not returning a stale ClientManager instance that is already shutdown. r=asuth ... While investigating an unexpected test failure triggered by a mochitest that was testing the identity WebExtensions API (D121683 from Bug 1723852) I did notice that the actual underlying issue was triggered by a leak (in particular the Extension API class in the initial draft of that D121683 patch was missing a RefPtr in the NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE macro used for that class) but the issue was presenting itself as an empty scriptURL in the ClientSource for the test case that was executed after the one that triggered tha leak, and far enough from where it was actually triggered. To make it easier to spot the issue nearer to the actual underlying issue, I think that it would be reasonable to add a diagnostic assertion to ClientManager::GetOrCreateForCurrentThread that would be triggered earlier if a leak was keeping the ClientManager instance alive in the idle DOM Worker Thread. Differential Revision: https://phabricator.services.mozilla.com/D123530		2021-09-02 21:24:58 +00:00
..
api	Bug 1726648 - Add a helper to trim brackets from nsID r=mccr8,smaug	2021-08-23 10:54:11 +00:00
manager	Bug 1727405 - Add a diagnostic assert to check that ClientManager::GetOrCreateForCurrentThread is not returning a stale ClientManager instance that is already shutdown. r=asuth	2021-09-02 21:24:58 +00:00
moz.build	Bug 1654103: Standardize on Black for Python code in mozilla-central.	2020-10-26 18:34:53 +00:00