gecko-dev/ipc/unixsocket
Nicholas Nethercote 34dcc7b852 Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm.
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.

In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.

> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));

In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.

> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");

This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
  be true" sense used in assertions.

A common variation on the side-effect-free case is the following.

> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");

--HG--
extra : rebase_source : 58788245021096efa8372a9dc1d597a611d45611
2016-09-02 17:12:24 +10:00
..
ConnectionOrientedSocket.cpp Bug 1268432: Replace |Task| with |Runnable| in B2G code r=fabrice 2016-05-02 10:27:15 -07:00
ConnectionOrientedSocket.h Bug 1261307: Convert Unix socket IPC code to |UniquePtr|, r=nfroyd 2016-04-05 13:40:11 +02:00
DataSocket.cpp Bug 1268432: Replace |Task| with |Runnable| in B2G code r=fabrice 2016-05-02 10:27:15 -07:00
DataSocket.h Bug 1268432: Replace |Task| with |Runnable| in B2G code r=fabrice 2016-05-02 10:27:15 -07:00
ListenSocket.cpp Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm. 2016-09-02 17:12:24 +10:00
ListenSocket.h Bug 1185478: Add leak checks to socket I/O classes 2015-07-21 08:06:29 +02:00
ListenSocketConsumer.cpp Bug 1166638: Add |ListenSocketConsumer|, r=kmachulis 2015-05-26 13:24:20 +02:00
ListenSocketConsumer.h Bug 1168806: Use 'consumer thread' in socket interface, r=kmachulis 2015-06-02 10:01:58 +02:00
moz.build Bug 1286877 - do not set c-basic-offset for python-mode; r=gps 2016-07-14 10:16:42 -06:00
SocketBase.cpp Bug 1268432: Replace |Task| with |Runnable| in B2G code r=fabrice 2016-05-02 10:27:15 -07:00
SocketBase.h Bug 1275299 - Make SocketTask a CancelableRunnable r=tzimmermann 2016-05-26 12:40:25 +02:00
StreamSocket.cpp Bug 1268432: Replace |Task| with |Runnable| in B2G code r=fabrice 2016-05-02 10:27:15 -07:00
StreamSocket.h Bug 1261307: Convert |StreamSocketConsumer::ReceiveSocketData| to |UniquePtr|, r=nfroyd 2016-04-05 13:40:11 +02:00
StreamSocketConsumer.cpp Bug 1166638: Add |StreamSocketConsumer|, r=kmachulis 2015-05-26 13:24:19 +02:00
StreamSocketConsumer.h Bug 1261307: Convert |StreamSocketConsumer::ReceiveSocketData| to |UniquePtr|, r=nfroyd 2016-04-05 13:40:11 +02:00
UnixSocketConnector.cpp Bug 1261307: Convert Unix socket IPC code to |UniquePtr|, r=nfroyd 2016-04-05 13:40:11 +02:00
UnixSocketConnector.h Bug 1261307: Convert Unix socket IPC code to |UniquePtr|, r=nfroyd 2016-04-05 13:40:11 +02:00