gecko-dev/netwerk/base/nsBase64Encoder.cpp
Nicholas Nethercote 3e439bb4f8 Bug 1376638 - Minimize uses of prmem.h. r=glandium.
It's silly to use prmem.h within Firefox code given that in our configuration
its functions are just wrappers for malloc() et al. (Indeed, in some places we
mix PR_Malloc() with free(), or malloc() with PR_Free().)

This patch removes all uses, except for the places where we need to use
PR_Free() to free something allocated by another NSPR function; in those cases
I've added a comment explaining which function did the allocation.

--HG--
extra : rebase_source : 0f781bca68b5bf3c4c191e09e277dfc8becffa09
2017-06-30 19:05:41 -07:00

68 lines
1.5 KiB
C++

/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "nsBase64Encoder.h"
#include "plbase64.h"
#include "prmem.h"
NS_IMPL_ISUPPORTS(nsBase64Encoder, nsIOutputStream)
NS_IMETHODIMP
nsBase64Encoder::Close()
{
return NS_OK;
}
NS_IMETHODIMP
nsBase64Encoder::Flush()
{
return NS_OK;
}
NS_IMETHODIMP
nsBase64Encoder::Write(const char* aBuf, uint32_t aCount, uint32_t* _retval)
{
mData.Append(aBuf, aCount);
*_retval = aCount;
return NS_OK;
}
NS_IMETHODIMP
nsBase64Encoder::WriteFrom(nsIInputStream* aStream, uint32_t aCount,
uint32_t* _retval)
{
return NS_ERROR_NOT_IMPLEMENTED;
}
NS_IMETHODIMP
nsBase64Encoder::WriteSegments(nsReadSegmentFun aReader,
void* aClosure,
uint32_t aCount,
uint32_t* _retval)
{
return NS_ERROR_NOT_IMPLEMENTED;
}
NS_IMETHODIMP
nsBase64Encoder::IsNonBlocking(bool* aNonBlocking)
{
*aNonBlocking = false;
return NS_OK;
}
nsresult
nsBase64Encoder::Finish(nsACString& result)
{
char* b64 = PL_Base64Encode(mData.get(), mData.Length(), nullptr);
if (!b64)
return NS_ERROR_OUT_OF_MEMORY;
result.Assign(b64);
PR_Free(b64); // PL_Base64Encode() uses PR_MALLOC().
// Free unneeded memory and allow reusing the object
mData.Truncate();
return NS_OK;
}