mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-21 01:05:45 +00:00
cd06f032af
Last attempt, a few years ago, blatantly failed because nautilus (the GNOME file manager) can't start PIE executables, which look like shared libraries, and that it thus considers not being executables. Downstreams don't actually have the problem, because users won't be launching Firefox from a file manager, but for mozilla.org builds, it is a problem because users would download, then extract, and then likely try to run the Firefox executable from a file manager. So for mozilla.org builds, we still need to find a way around the nautilus problem. A .desktop file could be a solution, but .desktop files have not actually been designed for this use case, which leads to: - having to use an awful one-liner shell wrapper to derive the path to the executable from that of the .desktop file, - not even being able to associate an icon, - the .desktop file not being copiable to a location where .desktop files would normally go, because it would then fail to find the executable. Another possibility is to go back to using a shell wrapper, but that's not entirely appealing. What we chose here is similar, where we have a small `firefox` wrapper that launches the real `firefox-bin` (which is still leftover from those old times where we had a shell wrapper, for reasons). The small `firefox` wrapper is a minimalist C executable that just finds the path to the `firefox-bin` executable and executes it with the same args it was called with. The wrapper is only enabled when the MOZ_NO_PIE_COMPAT environment variable is set, which we only take into account on Linux. The variable is only really meant to be used for mozilla.org builds, for the nautilus problem. Downstreams will just pick the default, which is changed to build PIE. On other platforms, PIE was already enabled by default, so we just remove the --enable-pie configure flag. Differential Revision: https://phabricator.services.mozilla.com/D5109 |
||
|---|---|---|
| .. | ||
| acwinpaths.m4 | ||
| alloc.m4 | ||
| altoptions.m4 | ||
| android.m4 | ||
| arch.m4 | ||
| clang-plugin.m4 | ||
| codeset.m4 | ||
| compiler-opts.m4 | ||
| config.guess | ||
| config.status.m4 | ||
| config.sub | ||
| expandlibs.m4 | ||
| frameptr.m4 | ||
| hooks.m4 | ||
| hotfixes.m4 | ||
| icu.m4 | ||
| install-sh | ||
| ios.m4 | ||
| lto.m4 | ||
| mozheader.m4 | ||
| mozprog.m4 | ||
| nspr-build.m4 | ||
| nspr.m4 | ||
| nss.m4 | ||
| pkg.m4 | ||
| sanitize.m4 | ||
| subconfigure.m4 | ||
| toolchain.m4 | ||
| zlib.m4 | ||