gecko-dev/dom/media/systemservices/MediaParent.h
Ehsan Akhgari 74c1d0047e Bug 1197185 - Give NonE10s a virtual destructor; r=jesup
The Parent template class inherits from both NonE10s and PMediaParent,
and the latter has a virtual destructor.  This confuses clang-tidy when
it wants to rewrite ~Parent() which is currently marked as virtual, and
it makes ~Parent() override which breaks the build since ~NonE10s() is
not virtual.  The easiest way to work around this seems to be making
~NonE10s() virtual.  See the discussion in
https://llvm.org/bugs/show_bug.cgi?id=24496 as well.
2015-08-21 17:53:35 -04:00

76 lines
2.3 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set sw=2 ts=8 et ft=cpp : */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef mozilla_MediaParent_h
#define mozilla_MediaParent_h
#include "MediaChild.h"
#include "mozilla/dom/ContentParent.h"
#include "mozilla/media/PMediaParent.h"
namespace mozilla {
namespace media {
// media::Parent implements the chrome-process side of ipc for media::Child APIs
// A "SameProcess" version may also be created to service non-e10s calls.
class OriginKeyStore;
class NonE10s
{
typedef mozilla::ipc::IProtocolManager<mozilla::ipc::IProtocol>::ActorDestroyReason
ActorDestroyReason;
public:
virtual ~NonE10s() {}
protected:
virtual bool RecvGetOriginKey(const uint32_t& aRequestId,
const nsCString& aOrigin,
const bool& aPrivateBrowsing,
const bool& aPersist) = 0;
virtual bool RecvSanitizeOriginKeys(const uint64_t& aSinceWhen,
const bool& aOnlyPrivateBrowsing) = 0;
virtual void
ActorDestroy(ActorDestroyReason aWhy) = 0;
};
// Super = PMediaParent or NonE10s
template<class Super>
class Parent : public Super
{
typedef mozilla::ipc::IProtocolManager<mozilla::ipc::IProtocol>::ActorDestroyReason
ActorDestroyReason;
public:
static Parent* GetSingleton();
virtual bool RecvGetOriginKey(const uint32_t& aRequestId,
const nsCString& aOrigin,
const bool& aPrivateBrowsing,
const bool& aPersist) override;
virtual bool RecvSanitizeOriginKeys(const uint64_t& aSinceWhen,
const bool& aOnlyPrivateBrowsing) override;
virtual void ActorDestroy(ActorDestroyReason aWhy) override;
explicit Parent(bool aSameProcess = false);
virtual ~Parent();
private:
nsRefPtr<OriginKeyStore> mOriginKeyStore;
bool mDestroyed;
bool mSameProcess;
CoatCheck<Pledge<nsCString>> mOutstandingPledges;
};
PMediaParent* AllocPMediaParent();
bool DeallocPMediaParent(PMediaParent *aActor);
} // namespace media
} // namespace mozilla
#endif // mozilla_MediaParent_h