gecko-dev/xpcom/base/nsWeakReference.cpp
Masayuki Nakano f337b95b60 Bug 1372829 - part2: mozilla::EditorBase should cache raw pointer of nsISelectionController and nsIDocument with nsWeakPtr r=froydnj,m_kato
mozilla::EditorBase stores nsISelectionController and nsIDocument with nsWeakPtr.  However, nsWeakPtr requires QI to retrieve actual pointer and it makes some damage to the performance.  If mozilla::WeakPter were available for them, it'd be great.  However, it's not available with nsISelectionController nor nsIDocument because it's possible to implement SupportsWeakPtr only with their subclasses but the subclasses shouldn't be referred by editor.  Therefore, this patch creates mozilla::CachedWeakPtr<class T> which stores both raw pointer (as cache) and nsWeakPtr and when its cache is requested, it checks if the object referred by nsWeakPtr is still alive.

Additionally, this patch hides the members from subclasses of EditorBase for reducing the maintenance cost.

MozReview-Commit-ID: FvtM7453Vv8

--HG--
extra : rebase_source : a524a8ea327c3993645fafa81db8aef65090f1e0
2017-06-20 00:55:00 +09:00

166 lines
3.9 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
// nsWeakReference.cpp
#include "mozilla/Attributes.h"
#include "nsWeakReference.h"
#include "nsCOMPtr.h"
#include "nsDebug.h"
#ifdef MOZ_THREAD_SAFETY_OWNERSHIP_CHECKS_SUPPORTED
#define MOZ_WEAKREF_DECL_OWNINGTHREAD nsAutoOwningThread _mWeakRefOwningThread;
#define MOZ_WEAKREF_ASSERT_OWNINGTHREAD \
_mWeakRefOwningThread.AssertOwnership("nsWeakReference not thread-safe")
#define MOZ_WEAKREF_ASSERT_OWNINGTHREAD_DELEGATED(that) \
(that)->_mWeakRefOwningThread.AssertOwnership("nsWeakReference not thread-safe")
#else
#define MOZ_WEAKREF_DECL_OWNINGTHREAD
#define MOZ_WEAKREF_ASSERT_OWNINGTHREAD do { } while (false)
#define MOZ_WEAKREF_ASSERT_OWNINGTHREAD_DELEGATED(that) do { } while (false)
#endif
class nsWeakReference final : public nsIWeakReference
{
public:
// nsISupports...
NS_DECL_ISUPPORTS
// nsIWeakReference...
NS_DECL_NSIWEAKREFERENCE
size_t SizeOfOnlyThis(mozilla::MallocSizeOf aMallocSizeOf) const override;
bool IsAlive() const override { return mReferent != nullptr; }
private:
MOZ_WEAKREF_DECL_OWNINGTHREAD
friend class nsSupportsWeakReference;
explicit nsWeakReference(nsSupportsWeakReference* aReferent)
: mReferent(aReferent)
// ...I can only be constructed by an |nsSupportsWeakReference|
{
}
~nsWeakReference()
// ...I will only be destroyed by calling |delete| myself.
{
MOZ_WEAKREF_ASSERT_OWNINGTHREAD;
if (mReferent) {
mReferent->NoticeProxyDestruction();
}
}
void
NoticeReferentDestruction()
// ...called (only) by an |nsSupportsWeakReference| from _its_ dtor.
{
MOZ_WEAKREF_ASSERT_OWNINGTHREAD;
mReferent = nullptr;
}
nsSupportsWeakReference* MOZ_NON_OWNING_REF mReferent;
};
nsresult
nsQueryReferent::operator()(const nsIID& aIID, void** aAnswer) const
{
nsresult status;
if (mWeakPtr) {
if (NS_FAILED(status = mWeakPtr->QueryReferent(aIID, aAnswer))) {
*aAnswer = 0;
}
} else {
status = NS_ERROR_NULL_POINTER;
}
if (mErrorPtr) {
*mErrorPtr = status;
}
return status;
}
nsIWeakReference* // or else |already_AddRefed<nsIWeakReference>|
NS_GetWeakReference(nsISupports* aInstancePtr, nsresult* aErrorPtr)
{
nsresult status;
nsIWeakReference* result = nullptr;
if (aInstancePtr) {
nsCOMPtr<nsISupportsWeakReference> factoryPtr =
do_QueryInterface(aInstancePtr, &status);
if (factoryPtr) {
status = factoryPtr->GetWeakReference(&result);
}
// else, |status| has already been set by |do_QueryInterface|
} else {
status = NS_ERROR_NULL_POINTER;
}
if (aErrorPtr) {
*aErrorPtr = status;
}
return result;
}
nsresult
nsSupportsWeakReference::GetWeakReference(nsIWeakReference** aInstancePtr)
{
if (!aInstancePtr) {
return NS_ERROR_NULL_POINTER;
}
if (!mProxy) {
mProxy = new nsWeakReference(this);
} else {
MOZ_WEAKREF_ASSERT_OWNINGTHREAD_DELEGATED(mProxy);
}
*aInstancePtr = mProxy;
nsresult status;
if (!*aInstancePtr) {
status = NS_ERROR_OUT_OF_MEMORY;
} else {
NS_ADDREF(*aInstancePtr);
status = NS_OK;
}
return status;
}
NS_IMPL_ISUPPORTS(nsWeakReference, nsIWeakReference)
NS_IMETHODIMP
nsWeakReference::QueryReferent(const nsIID& aIID, void** aInstancePtr)
{
MOZ_WEAKREF_ASSERT_OWNINGTHREAD;
return mReferent ? mReferent->QueryInterface(aIID, aInstancePtr) :
NS_ERROR_NULL_POINTER;
}
size_t
nsWeakReference::SizeOfOnlyThis(mozilla::MallocSizeOf aMallocSizeOf) const
{
return aMallocSizeOf(this);
}
void
nsSupportsWeakReference::ClearWeakReferences()
{
if (mProxy) {
mProxy->NoticeReferentDestruction();
mProxy = nullptr;
}
}