gecko-dev/xpcom/ds/nsPointerHashKeys.h
Emilio Cobos Álvarez 9b5ea61bed Bug 1849386 - Use consistent pointer hashing. r=nika,xpcom-reviewers
* DefaultHasher<T*> used HashGeneric<size_t>
 * nsPtrHashKey<T> used HashGeneric<T*>
 * nsRefPtrHashKey<T> used NS_PTR_TO_UINT32 >> 2

Make sure to always use HashGeneric<T*> for these.

Remove unused / redundant hash keys.

Differential Revision: https://phabricator.services.mozilla.com/D186553
2023-08-18 22:35:40 +00:00

50 lines
1.3 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
/* Definitions for nsPtrHashKey<T> and nsVoidPtrHashKey. */
#ifndef nsPointerHashKeys_h
#define nsPointerHashKeys_h
#include "nscore.h"
#include "mozilla/Attributes.h"
#include "mozilla/HashFunctions.h"
#include "PLDHashTable.h"
/**
* hashkey wrapper using T* KeyType
*
* @see nsTHashtable::EntryType for specification
*/
template <class T>
class nsPtrHashKey : public PLDHashEntryHdr {
public:
using KeyType = T*;
using KeyTypePointer = const T*;
explicit nsPtrHashKey(const T* aKey) : mKey(const_cast<T*>(aKey)) {}
nsPtrHashKey(nsPtrHashKey&& aToMove) = default;
~nsPtrHashKey() = default;
KeyType GetKey() const { return mKey; }
bool KeyEquals(KeyTypePointer aKey) const { return aKey == mKey; }
static KeyTypePointer KeyToPointer(KeyType aKey) { return aKey; }
static PLDHashNumber HashKey(KeyTypePointer aKey) {
return mozilla::HashGeneric(aKey);
}
enum { ALLOW_MEMMOVE = true };
protected:
T* MOZ_NON_OWNING_REF mKey;
};
using nsVoidPtrHashKey = nsPtrHashKey<const void>;
#endif // nsPointerHashKeys_h