mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-12-18 04:44:17 +00:00
3c0c3a2676
This patch was generated as follows: Run: `./mach esmify --imports . --prefix=toolkit/mozapps/extensions/AddonManager` In the output there are linter/prettifier errors due to unused XPCOMUtils or separate importESModule calls. These have been fixed manually and verified with `./mach lint --outgoing`. The `esmify` script also inserts many unwanted newlines around imports that are broken on two lines due to length. Due to the number of these, I fixed them programatically. 1. Create patch from the changes so far. 2. From the patch, delete all lines that consist of "+" (i.e. added blank line). 3. Reset the working dir and apply the revised patch. 4. Verify that the diff between step 1 and 3 looks reasonable. 5. Verify that this patch as a whole looks reasonable. Commands: ``` git diff > rename.diff :%g/^+$/d git commit -va -m WIP-rename git revert HEAD git apply --recount rename.diff git diff HEAD^ # and verify that the removed lines are ok. git commit -va # one last review to verify correctness of whole patch. git rebase -i HEAD~3 # drop the WIP + reverted commit, pick only the last. ``` `git apply` has the `--recount` option to force it to ignore mismatches in line counts, which happens because we deleted added lines (^+$) without fixing up the line counts in the file headers. Differential Revision: https://phabricator.services.mozilla.com/D179874 |
||
---|---|---|
.. | ||
android | ||
gtk | ||
mac | ||
rust | ||
tests | ||
windows | ||
AppDateTimeFormat.cpp | ||
AppDateTimeFormat.h | ||
cldr-quotes.inc | ||
cldr-quotes.pl | ||
components.conf | ||
encodingsgroups.properties | ||
LangPackMatcher.sys.mjs | ||
language.properties | ||
LocaleService.cpp | ||
LocaleService.h | ||
moz.build | ||
mozILocaleService.idl | ||
mozIOSPreferences.idl | ||
MozLocaleBindings.h | ||
nsLanguageAtomService.cpp | ||
nsLanguageAtomService.h | ||
nsUConvPropertySearch.cpp | ||
nsUConvPropertySearch.h | ||
OSPreferences.cpp | ||
OSPreferences.h | ||
PluralForm.sys.mjs | ||
props2arrays.py | ||
Quotes.cpp | ||
Quotes.h |