mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-31 06:05:44 +00:00
d0a151fdf5
Run checkstyle via:
./mach gradle app:checkstyle
This is intended to be added to automation in bug 1258787 and made more robust
in bug 1261486.
For the addition of future checks, it's worth noting Google's config is
available:
3e4367941c/src/main/resources/google_checks.xml
And this version contains links with descriptions of each of the tasks:
http://checkstyle.sourceforge.net/google_style.html
MozReview-Commit-ID: 5HvtQsyY2JQ
--HG--
extra : rebase_source : ea45bcfb88ec302e9f6e6526d9afdbf2c9c93f01
50 lines
1.6 KiB
XML
50 lines
1.6 KiB
XML
<?xml version="1.0"?>
|
|
<!-- This Source Code Form is subject to the terms of the Mozilla Public
|
|
- License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
- file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
|
|
<!DOCTYPE module PUBLIC
|
|
"-//Puppy Crawl//DTD Check Configuration 1.2//EN"
|
|
"http://www.puppycrawl.com/dtds/configuration_1_2.dtd">
|
|
|
|
<!-- TODO: Clean up code & add checks:
|
|
- WhitespaceAround
|
|
- EmptyLineSeparator
|
|
- NeedBraces
|
|
- LeftCurly // placement of "{" in new scope or literal
|
|
- RightCurly // placement of "}" in close scope or literal
|
|
- Indentation
|
|
- OneStatementPerLine
|
|
- OperatorWrap
|
|
- SeparatorWrap
|
|
- MultipleVariableDeclarations
|
|
- FallThrough
|
|
(I spent too much time already)
|
|
|
|
Maybe add:
|
|
- OneTopLevelClass
|
|
- OverloadMethodsDeclarationOrder
|
|
- Empty*Block // better to catch errors!
|
|
(I spent too much time already)
|
|
|
|
See http://checkstyle.sourceforge.net/google_style.html
|
|
for a good set of defaults.
|
|
-->
|
|
|
|
<module name="Checker">
|
|
<property name="charset" value="UTF-8"/>
|
|
|
|
<!-- TODO: <property name="fileExtensions" value="java, properties, xml"/> -->
|
|
|
|
<module name="FileTabCharacter"> <!-- No tabs! -->
|
|
<property name="eachLine" value="true"/>
|
|
</module>
|
|
|
|
<module name="TreeWalker">
|
|
<module name="NoLineWrap">
|
|
<property name="tokens" value="IMPORT,PACKAGE_DEF"/>
|
|
</module>
|
|
<module name="OuterTypeFilename"/> <!-- `class Lol` only in Lol.java -->
|
|
</module>
|
|
|
|
</module>
|