mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-12-11 08:13:35 +00:00
b3d842431f
This patch implements mozilla::NotNull, which is similar but not identicial to gsl::not_null. The current draft(?) implementation of gsl::not_null is at https://github.com/Microsoft/GSL/blob/master/include/gsl.h. The main difference is that not_null allows implicit conversion from T to not_null<T>. In contrast, NotNull only allows explicit conversion from T to NotNull<T> via WrapNotNull(). The rationale for this is that when converting from a less-constrained type to a more constrained type, implicit conversion is undesirable. For example, if I changed a function f from this: f(int* aPtr); to this: f(gsl::not_null<int*> aPtr); no call sites would have to be modified. But if I changed it to this: f(mozilla::NotNull<int*> aPtr); call sites *would* need to be modified. This is a good thing! It forces the author to audit the call sites for non-nullness, and encourages them to back-propagate NotNull throughout the code. The other difference between not_null and NotNull is that not_null disables pointer arithmetic, which means it cannot be used with array pointers. I have not implemented this restriction for NotNull because it seems arbitrary and unnecessary.
140 lines
3.2 KiB
Python
140 lines
3.2 KiB
Python
# -*- Mode: python; c-basic-offset: 4; indent-tabs-mode: nil; tab-width: 40 -*-
|
|
# vim: set filetype=python:
|
|
# This Source Code Form is subject to the terms of the Mozilla Public
|
|
# License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
|
|
TEST_DIRS += ['tests']
|
|
|
|
# On win we build two mfbt libs - mfbt linked to crt dlls here and in
|
|
# staticruntime we build a statically linked mfbt lib.
|
|
if CONFIG['OS_ARCH'] == 'WINNT':
|
|
DIRS += ['staticruntime']
|
|
|
|
Library('mfbt')
|
|
|
|
EXPORTS.mozilla = [
|
|
'Alignment.h',
|
|
'AllocPolicy.h',
|
|
'AlreadyAddRefed.h',
|
|
'Array.h',
|
|
'ArrayUtils.h',
|
|
'Assertions.h',
|
|
'Atomics.h',
|
|
'Attributes.h',
|
|
'BinarySearch.h',
|
|
'BloomFilter.h',
|
|
'BufferList.h',
|
|
'Casting.h',
|
|
'ChaosMode.h',
|
|
'Char16.h',
|
|
'CheckedInt.h',
|
|
'Compiler.h',
|
|
'Compression.h',
|
|
'DebugOnly.h',
|
|
'decimal/Decimal.h',
|
|
'double-conversion/double-conversion.h',
|
|
'double-conversion/utils.h',
|
|
'EndianUtils.h',
|
|
'EnumeratedArray.h',
|
|
'EnumeratedRange.h',
|
|
'EnumSet.h',
|
|
'FastBernoulliTrial.h',
|
|
'FloatingPoint.h',
|
|
'Function.h',
|
|
'GuardObjects.h',
|
|
'HashFunctions.h',
|
|
'IndexSequence.h',
|
|
'InitializerList.h',
|
|
'IntegerPrintfMacros.h',
|
|
'IntegerRange.h',
|
|
'IntegerTypeTraits.h',
|
|
'JSONWriter.h',
|
|
'Likely.h',
|
|
'LinkedList.h',
|
|
'MacroArgs.h',
|
|
'MacroForEach.h',
|
|
'MathAlgorithms.h',
|
|
'Maybe.h',
|
|
'MaybeOneOf.h',
|
|
'MemoryChecking.h',
|
|
'MemoryReporting.h',
|
|
'Move.h',
|
|
'NotNull.h',
|
|
'NullPtr.h',
|
|
'NumericLimits.h',
|
|
'Opaque.h',
|
|
'Pair.h',
|
|
'PodOperations.h',
|
|
'Poison.h',
|
|
'Range.h',
|
|
'RangedArray.h',
|
|
'RangedPtr.h',
|
|
'ReentrancyGuard.h',
|
|
'RefCounted.h',
|
|
'RefCountType.h',
|
|
'RefPtr.h',
|
|
'ReverseIterator.h',
|
|
'RollingMean.h',
|
|
'Saturate.h',
|
|
'Scoped.h',
|
|
'ScopeExit.h',
|
|
'SegmentedVector.h',
|
|
'SHA1.h',
|
|
'SizePrintfMacros.h',
|
|
'Snprintf.h',
|
|
'SplayTree.h',
|
|
'TaggedAnonymousMemory.h',
|
|
'TemplateLib.h',
|
|
'ThreadLocal.h',
|
|
'ToString.h',
|
|
'Tuple.h',
|
|
'TypedEnumBits.h',
|
|
'Types.h',
|
|
'TypeTraits.h',
|
|
'UniquePtr.h',
|
|
'UniquePtrExtensions.h',
|
|
'unused.h',
|
|
'Variant.h',
|
|
'Vector.h',
|
|
'WeakPtr.h',
|
|
'XorShift128PlusRNG.h',
|
|
]
|
|
|
|
if CONFIG['OS_ARCH'] == 'WINNT':
|
|
EXPORTS.mozilla += [
|
|
'WindowsVersion.h',
|
|
]
|
|
elif CONFIG['OS_ARCH'] == 'Linux':
|
|
EXPORTS.mozilla += [
|
|
'LinuxSignal.h',
|
|
]
|
|
|
|
include('objs.mozbuild')
|
|
|
|
UNIFIED_SOURCES += mfbt_src_cppsrcs
|
|
|
|
DEFINES['IMPL_MFBT'] = True
|
|
|
|
SOURCES += mfbt_nonunified_src_cppsrcs
|
|
|
|
DISABLE_STL_WRAPPING = True
|
|
|
|
# Suppress warnings in third-party LZ4 code.
|
|
# TODO: Remove these suppressions after bug 993267 is fixed.
|
|
|
|
if CONFIG['GNU_CXX']:
|
|
SOURCES['/mfbt/Compression.cpp'].flags += ['-Wno-unused-function']
|
|
CXXFLAGS += ['-Wno-error=shadow']
|
|
|
|
if CONFIG['CLANG_CXX']:
|
|
# Suppress warnings from third-party V8 Decimal code.
|
|
SOURCES['/mfbt/decimal/Decimal.cpp'].flags += ['-Wno-implicit-fallthrough']
|
|
|
|
if CONFIG['_MSC_VER']:
|
|
# Error 4804 is "'>' : unsafe use of type 'bool' in operation"
|
|
SOURCES['/mfbt/Compression.cpp'].flags += ['-wd4804']
|
|
|
|
if CONFIG['MOZ_NEEDS_LIBATOMIC']:
|
|
OS_LIBS += ['atomic']
|