Read-only Git mirror of the Mercurial gecko repositories at https://hg.mozilla.org. How to contribute: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
Go to file
Masayuki Nakano d40825b1e4 Bug 1463327 - part 3: Change scope of some methods of HTMLEditor which won't be called by non-helper classes of editing to protected r=m_kato
HTMLEditor has 2 type of public methods.  One is rue-public methods.  I.e.,
they should be able to be called by anybody.  E.g., command handlers, event
listeners, or JS via nsIEditor interface.  The other is semi-public methods.
They are not called by the above examples but called by other classes which
are helper classes to handle edit actions.  E.g., TextEditRules, HTMLEditRules,
HTMLEditUtils, CSSEditUtils and Transaction classes.

When we will implement InputEvent.inputType, we need to create new stack
class and create its instance at every true-public methods to manage current
inputType (like TextEditRules::AutoSafeEditorData).  Therefore, it should not
happen that new code starts to call semi-public methods without the new
stack class instance.

For preventing this issue, we should make HTMLEditor have only the true-public
methods as public.  The other public methods should be protected and their
users should be friend classes.  Then, we can protect such method from external
classes.

Note that this patch just moves the methods without any changes in HTMLEditor.h
(except removes BlockTransformationType since it's unused and replaces
ResizingRequestID with new enum class ResizeAt since normal enum isn't hit by
searchfox.org).

MozReview-Commit-ID: 7PC8E8vD7w2

--HG--
extra : rebase_source : 13f51565f2b89ab816ba529af18ee88193a9c932
2018-05-22 18:28:50 +09:00
.cargo Bug 1452603 - Update Cargo stuff for the serde bump. r=jrmuizel 2018-04-12 11:05:18 -04:00
.vscode
accessible Bug 1461959 - Removed OSX 10.6 reference. r=gbrown 2018-05-17 14:53:00 +03:00
browser Bug 1463685 - Change font-weight:500 to 600 to get a semibold font on Windows. r=mak 2018-05-24 14:03:35 +02:00
build Bug 1463921 - Re-run js configure when js/src/old-configure changes. r=gps 2018-05-23 17:22:09 -07:00
caps Bug 1453916 - Allow canvas extraction from webextension content-script even with resistFingerprinting turned on. r=kmag,bz 2018-05-14 20:49:32 +02:00
chrome Bug 1460940 - Clean up most remaining C++-side uses of nsIDOMDocument. r=bz 2018-05-11 19:46:15 +02:00
config bug 1463425 - Fix flake8/pep8 issue by hand in config/ r=gps 2018-05-22 06:22:46 -07:00
db Bug 1453193 - Upgrade to SQLite 3.23.1. r=mak 2018-04-11 09:04:00 -04:00
devtools Bug 1463408 part 2 - Add profiler feature seqstyle for forcing sequential styling when profiling. r=emilio,mstange 2018-05-23 19:35:03 +10:00
docshell Bug 1434553 - Implement nsIInputStreamLength and nsIAsyncInputStreamLength - part 9 - necko and docShell, r=mayhemer, r=smaug 2018-05-23 07:12:36 +02:00
dom Merge inbound to mozilla-central. a=merge 2018-05-24 12:37:58 +03:00
editor Bug 1463327 - part 3: Change scope of some methods of HTMLEditor which won't be called by non-helper classes of editing to protected r=m_kato 2018-05-22 18:28:50 +09:00
embedding
extensions Bug 1455601 - Sandbox AutoConfig if sandbox_enabled pref is set. r=kmag 2018-05-23 12:21:53 -05:00
gfx Bug 1462642 - [Wayland/EGL] Use dummy wl_egl_window instead of PBuffer, r=lsalzman 2018-05-22 10:34:32 +02:00
gradle/wrapper
hal Bug 1460940 - Clean up most remaining C++-side uses of nsIDOMDocument. r=bz 2018-05-11 19:46:15 +02:00
image Backed out changeset 6c8bf287d25b (bug 1462431) for web platform reftest failure. r=aosmond 2018-05-18 08:59:26 -04:00
intl Bug 1462958 - Avoid infinite recursion if resourceIds is empty. r=mossop 2018-05-19 20:14:00 -07:00
ipc Merge mozilla-central to mozilla-inbound 2018-05-23 13:05:09 +03:00
js Bug 1461938 part 26 - Move performanceMonitoring from JSCompartment to JS::Realm. r=luke 2018-05-23 15:27:36 +02:00
layout Bug 1463752 - Part 2: Avoid allocating AutoTArray when there are no items that can be merged together r=mattwoodrow 2018-05-22 23:46:11 +02:00
media Backed out changeset c13ca75c9bcb (bug 1450658) for Browser-Chrome failures on browser/base/content/test/webrtc/browser_devices_get_user_media_screen.js 2018-05-23 17:07:33 +03:00
memory Merge inbound to mozilla-central. a=merge 2018-05-24 12:37:58 +03:00
mfbt Bug 1462912 - fixed BufferList::Extract to handle the case where the call consumes the entirety of the BufferList; r=froydnj 2018-05-22 13:04:59 -04:00
mobile Merge inbound to mozilla-central. a=merge 2018-05-24 01:00:23 +03:00
modules Bug 1457084 - Increase max chunk memory usage limit, r=mayhemer 2018-05-23 05:03:00 +03:00
mozglue Bug 1462727 - Make WindowsMapRemoteView.cpp work with April 2018 Update SDK. r=aklotz 2018-05-19 02:12:14 +09:00
netwerk Merge inbound to mozilla-central. a=merge 2018-05-24 12:37:58 +03:00
nsprpub
other-licenses Merge inbound to mozilla-central. a=merge 2018-05-09 01:58:44 +03:00
parser Bug 1461701: Remove nsUpdateType and UPDATE_CONTENT_MODEL. r=smaug 2018-05-15 18:47:16 +02:00
python Backed out 3 changesets (bug 1346026) for Bugzilla linting 2018-05-23 19:42:13 +03:00
security Bug 1462640 - Allow content processes to mincore() individual pages. r=gcp 2018-05-18 17:36:47 -06:00
services Backed out changeset 240237473d9e (bug 1463624) for failing eslint at builds/worker/checkouts/gecko/services/sync/tests/unit/test_browserid_identity.js:279:9 on a CLOSED TREE 2018-05-24 03:04:36 +03:00
servo Bug 1463978 - Don't generate catch-all branch if a image layer keyword value is exhaustive. r=emilio 2018-05-24 14:12:55 +10:00
startupcache
storage Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj 2018-04-28 12:50:58 -07:00
taskcluster Merge inbound to mozilla-central. a=merge 2018-05-24 12:37:58 +03:00
testing Merge inbound to mozilla-central. a=merge 2018-05-24 12:37:58 +03:00
third_party Backed out 3 changesets (bug 1346026) for Bugzilla linting 2018-05-23 19:42:13 +03:00
toolkit Bug 1452666 - Simplify SessionHistory serialization code and test expanded principals are serialized and can restore tabs. r=bz,mikedeboer 2018-05-19 14:42:52 +01:00
tools Bug 1463408 part 2 - Add profiler feature seqstyle for forcing sequential styling when profiling. r=emilio,mstange 2018-05-23 19:35:03 +10:00
uriloader Bug 1463287: Add QueryInterface helper macro for concrete class types. r=bz 2018-05-21 16:33:18 -07:00
view Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj 2018-04-28 12:50:58 -07:00
widget Bug 1463753 - [DragAndDrop] Update mTarget(Wayland)DragContext unconditionally and check its validity after that, r=jhorak 2018-05-24 11:51:17 +02:00
xpcom Merge inbound to mozilla-central. a=merge 2018-05-24 01:00:23 +03:00
xpfe/appshell Bug 1458999: Nullcheck for release, assert elsewhere. r=enn 2018-05-22 22:06:41 +02:00
.arcconfig Bug 1460463 - Update .arcconfig to make history mutable; r=gps 2018-05-09 23:49:52 +00:00
.clang-format
.clang-format-ignore Bug 1449244 Remove SphinxBase r=drno 2018-03-27 12:04:10 -05:00
.cron.yml Bug 1462294 - remove unused date branch; r=Pike 2018-05-17 13:30:19 +00:00
.eslintignore Bug 1461785 - Update eslint ignore file to no longer ignore dom/media/mediasource. r=standard8 2018-05-14 16:49:39 -04:00
.eslintrc.js Bug 1463499 - Enable ESLint rule require-expected-throws-or-rejects for services/. r=markh 2018-05-16 19:06:24 +01:00
.flake8 bug 1463425 - Add more directories to the flake8 list r=ahal 2018-05-22 06:26:22 -07:00
.gdbinit
.gdbinit_python
.gitignore
.hgignore Bug 1454466 - Move raptor in-tree; r=ahal 2018-04-16 17:15:38 -04:00
.hgtags No bug - Tagging mozilla-central 93443d36d4bd53dba004f7b73430879f96daa681 with FIREFOX_NIGHTLY_61_END a=release DONTBUILD CLOSED TREE 2018-05-07 16:27:53 +00:00
.inferconfig
.lldbinit
.mailmap
.taskcluster.yml Bug 1415868 - change ACTION_TASK_GROUP_ID to be the taskGroupId of the target task; r=aki 2018-05-18 22:16:43 +00:00
.yamllint
.ycm_extra_conf.py
aclocal.m4
AUTHORS Bug 1459852 - Get rid of the AUTHORS list r=mossop 2018-05-08 10:37:41 +02:00
build.gradle Bug 1457863 - 1. Update kotlin to 1.2.41; r=nalexander 2018-05-02 13:49:57 -04:00
Cargo.lock Bug 1463251 - Part 1. Update regex in both webdriver and geckodriver. r=ato,jgraham 2018-05-21 22:24:30 +02:00
Cargo.toml Bug 1452603 - Update Cargo stuff for the serde bump. r=jrmuizel 2018-04-12 11:05:18 -04:00
client.mk Bug 1461836 - Write out complete configure dependencies from configure for consumption by make and non-make backends. r=mshal 2018-05-21 14:01:50 -07:00
client.py
CLOBBER Bug 1454912 - Use a .stub file as the target for all GENERATED_FILES rules; r=nalexander 2018-05-09 08:24:31 -04:00
configure.in
configure.py Bug 1461836 - Write out complete configure dependencies from configure for consumption by make and non-make backends. r=mshal 2018-05-21 14:01:50 -07:00
GNUmakefile
gradle.properties Bug 1453413 - Use aapt2 to build Firefox for Android. r=mcomella 2018-04-11 09:59:22 -07:00
gradlew
LEGAL
LICENSE
mach
Makefile.in Bug 1461836 - Write out complete configure dependencies from configure for consumption by make and non-make backends. r=mshal 2018-05-21 14:01:50 -07:00
moz.build Bug 1346026 - Vendor pipenv 2018.5.18 and transient dependencies; r=ahal 2018-05-17 19:06:20 +01:00
moz.configure Bug 1461836 - Write out complete configure dependencies from configure for consumption by make and non-make backends. r=mshal 2018-05-21 14:01:50 -07:00
mozilla-config.h.in Bug 1460600: Remove unsupported --enable-system-hunspell flag. r=glandium 2018-05-10 10:36:53 -07:00
old-configure.in Bug 1456552 Make Optimized MinGW builds use -O# instead of falling through and collecting a -O r=ted 2018-05-16 16:32:47 -05:00
package-lock.json Bug 1374699 - fixing compiler warnings for nrappkit. r=drno 2017-09-21 08:56:34 -05:00
package.json Bug 1456076 - Update ESLint to 4.19.1 & eslint-plugin-html to 4.0.3. r=mossop 2018-04-23 11:33:31 +01:00
Pipfile Backed out 3 changesets (bug 1346026) for Bugzilla linting 2018-05-23 19:42:13 +03:00
Pipfile.lock Backed out 3 changesets (bug 1346026) for Bugzilla linting 2018-05-23 19:42:13 +03:00
README.txt Bug 1460030 - Update the nightly URL in the README.txt file r=kohei 2018-05-08 21:22:10 +02:00
settings.gradle
test.mozbuild

An explanation of the Mozilla Source Code Directory Structure and links to
project pages with documentation can be found at:

    https://developer.mozilla.org/en/Mozilla_Source_Code_Directory_Structure

For information on how to build Mozilla from the source code, see:

    https://developer.mozilla.org/en/docs/Build_Documentation

To have your bug fix / feature added to Mozilla, you should create a patch and
submit it to Bugzilla (https://bugzilla.mozilla.org). Instructions are at:

    https://developer.mozilla.org/en/docs/Creating_a_patch
    https://developer.mozilla.org/en/docs/Getting_your_patch_in_the_tree

If you have a question about developing Mozilla, and can't find the solution
on https://developer.mozilla.org, you can try asking your question in a
mozilla.* Usenet group, or on IRC at irc.mozilla.org. [The Mozilla news groups
are accessible on Google Groups, or news.mozilla.org with a NNTP reader.]

You can download nightly development builds from the Mozilla FTP server.
Keep in mind that nightly builds, which are used by Mozilla developers for
testing, may be buggy. Firefox nightlies, for example, can be found at:

    https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/
            - or -
    https://www.mozilla.org/firefox/channel/desktop/#nightly